New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772550 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

ERROR:platform_sensor_provider_mac.cc(68)] Not implemented

Reported by kenorb@gmail.com, Oct 6 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3234.0 Safari/537.36

Steps to reproduce the problem:
The following error appear in the logs.

What is the expected behavior?

What went wrong?
[58713:46339:1006/224726.938534:ERROR:platform_sensor_provider_mac.cc(68)] Not implemented reached in virtual void device::PlatformSensorProviderMac::CreateSensorInternal(mojom::SensorType, mojo::ScopedSharedBufferMapping, const device::PlatformSensorProviderBase::CreateSensorCallback &)

Did this work before? N/A 

Chrome version: e7f0416cefe3af6fee4921a25611b0af4cedf868  Channel: canary
OS Version: OS X 10.12.0
Flash Version:
 
Cc: reillyg@chromium.org juncai@chromium.org
Components: Blink>Sensor
Labels: -Type-Bug -Pri-2 M-63 Pri-1 Type-Bug-Regression
Owner: mikhail....@intel.com
Status: Assigned (was: Unconfirmed)
Seems like this is due to this patch - https://chromium.googlesource.com/chromium/src/+/21e2fed8405b6a3ba251d11b6470232f2f1e896f

Looping to the owner and reviewer.
Labels: -Pri-1 -Type-Bug-Regression Pri-3 Type-Bug
Owner: reillyg@chromium.org
Status: Started (was: Assigned)
Not a regression. PlatformSensorProviderMac has always had this NOTIMPLEMENTED() here, which is incorrect. Other platforms run the callback with nullptr without logging an error.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bcdaf2af8d419b260899d08dd0c4200f28aad06

commit 5bcdaf2af8d419b260899d08dd0c4200f28aad06
Author: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Date: Tue Oct 10 15:11:10 2017

Remove NOTIMPLEMENTED() call from PlatformSensorProviderMac

Bug:  772550 
Change-Id: I9aba49f8ec15865147abfe13bc280b173b6337b3
Reviewed-on: https://chromium-review.googlesource.com/708257
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Cr-Commit-Position: refs/heads/master@{#507667}
[modify] https://crrev.com/5bcdaf2af8d419b260899d08dd0c4200f28aad06/services/device/generic_sensor/platform_sensor_provider_mac.cc

Owner: mikhail....@intel.com
Status: Fixed (was: Started)
Thanks Mikhail!

Sign in to add a comment