New issue
Advanced search Search tips

Issue 772543 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[CRD iOS] NSLog audit & cleanup

Project Member Reported by yuweih@chromium.org, Oct 6 2017

Issue description

NSLogs bypasses the LOG(INFO) check and could spam the console. We should replace NSLog with LOG/VLOG macros, NOT_IMPLEMENTED, etc.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e449d4b9ab7dce6339b34ebc4950eab1dc12e4c7

commit e449d4b9ab7dce6339b34ebc4950eab1dc12e4c7
Author: Yuwei Huang <yuweih@chromium.org>
Date: Tue Oct 10 23:28:45 2017

[CRD iOS] Cleaning Up NSLogs

This CL cleans up the NSLogs by:
* Replacing some NSLogs with the Chromium LOG(severity), severity > INFO
* Replacing some others with NOTREACHED()
* Removing some NSLogs

Bug:  772543 
Change-Id: I3e140c4454ed95a8ea6fc5deb651ffd7a2960051
Reviewed-on: https://chromium-review.googlesource.com/706416
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507820}
[modify] https://crrev.com/e449d4b9ab7dce6339b34ebc4950eab1dc12e4c7/remoting/ios/app/app_delegate.mm
[modify] https://crrev.com/e449d4b9ab7dce6339b34ebc4950eab1dc12e4c7/remoting/ios/app/first_launch_view_presenter.mm
[modify] https://crrev.com/e449d4b9ab7dce6339b34ebc4950eab1dc12e4c7/remoting/ios/app/help_and_feedback.mm
[modify] https://crrev.com/e449d4b9ab7dce6339b34ebc4950eab1dc12e4c7/remoting/ios/app/host_view_controller.mm
[modify] https://crrev.com/e449d4b9ab7dce6339b34ebc4950eab1dc12e4c7/remoting/ios/app/pin_entry_view.mm
[modify] https://crrev.com/e449d4b9ab7dce6339b34ebc4950eab1dc12e4c7/remoting/ios/app/settings/remoting_settings_view_controller.h
[modify] https://crrev.com/e449d4b9ab7dce6339b34ebc4950eab1dc12e4c7/remoting/ios/keychain_wrapper.mm
[modify] https://crrev.com/e449d4b9ab7dce6339b34ebc4950eab1dc12e4c7/remoting/ios/session/remoting_client.mm

Comment 2 by yuweih@chromium.org, Oct 14 2017

Status: Fixed (was: Assigned)
Labels: M-64

Sign in to add a comment