New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 772541 link

Starred by 2 users
Status: Fixed
Owner:
wylieb@chromium.org
Closed: Oct 2017
Cc:
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Previous timeouts not allowing reruns to run.

Project Member Reported by wylieb@chromium.org, Oct 6 2017 
The flake analysis isn't being reset.

This is because when an analysis ends in error after a timeout, the timeout counter isn't being reset. When a new analysis is run, the pipeline sees the counter is already over the max so it aborts immediately.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/495c5d595ed5e9d7f5487d223a4aa877c0d91824

commit 495c5d595ed5e9d7f5487d223a4aa877c0d91824
Author: Brandon Wylie <wylieb@chromium.org>
Date: Fri Oct 06 22:57:43 2017

[Findit] Flake Analyzer - Previous timeouts preventing forced reruns from running

MasterFlakeAnalysis' timeout counter isn't being reset when aborted
so reruns of that same analysis aren't allowed to start.

Bug:772541
Change-Id: Ibed473bb0c81c7f35083b5c4a0e0a7e891a51528
Reviewed-on: https://chromium-review.googlesource.com/706100
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/495c5d595ed5e9d7f5487d223a4aa877c0d91824/appengine/findit/waterfall/flake/test/determine_true_pass_rate_pipeline_test.py
[modify] https://crrev.com/495c5d595ed5e9d7f5487d223a4aa877c0d91824/appengine/findit/waterfall/flake/determine_true_pass_rate_pipeline.py

Comment 2 by wylieb@chromium.org, Oct 9 2017

Labels: dGVzdA--

Comment 3 by wylieb@chromium.org, Oct 11 2017

Status: Fixed (was: Started)
►

Sign in to add a comment