New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772533 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Fix mosys warnings

Project Member Reported by sjg@chromium.org, Oct 6 2017

Issue description

mosys warns a bit, should fix:

platform/fizz/memory.c:68:12: warning: unused function 'dimm_fizz_dimm_count' [-Wunused-function]
static int dimm_fizz_dimm_count(struct platform_intf *intf)
           ^
platform/fizz/memory.c:168:29: warning: unused variable 'dimm_fizz_spd_cb' [-Wunused-variable]
static struct memory_spd_cb dimm_fizz_spd_cb = {
                            ^


lib/flashrom/flashrom.c:301:6: warning: unused variable 'i' [-Wunused-variable]
        int i = 0;
            ^

 

Comment 1 by sjg@chromium.org, Oct 16 2017

Cc: adurbin@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/mosys/+/f05c3e9b6ecd0e9f8f40598b1bbb1e3cfa5be93e

commit f05c3e9b6ecd0e9f8f40598b1bbb1e3cfa5be93e
Author: Chris Ching <chingcodes@chromium.org>
Date: Thu Oct 19 17:09:31 2017

Remove unused code

* remove unused function dimm_fizz_dimm_count
* remove unused var dimm_fizz_spd_read

BRANCH=none
BUG= chromium:772533 
TEST=FEATURES=test emerge-fizz mosys

Change-Id: Ia52b462d49f40185928e0b0b690137e752527806
Reviewed-on: https://chromium-review.googlesource.com/722171
Commit-Ready: Chris Ching <chingcodes@chromium.org>
Tested-by: Chris Ching <chingcodes@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/f05c3e9b6ecd0e9f8f40598b1bbb1e3cfa5be93e/platform/fizz/memory.c

Status: Fixed (was: Untriaged)

Sign in to add a comment