New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772509 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug

Blocking:
issue 826087



Sign in to add a comment

[Findit] Flake Analyzer - Some timed out swarming tasks may still be salvaged

Project Member Reported by lijeffrey@chromium.org, Oct 6 2017

Issue description

Some Swarming tasks still have the test json results even they timed out. For example, https://chromium-swarm.appspot.com/task?id=390417419270be10&refresh=10&show_raw=1

As long as there are usable results, it may not be necessary to rerun the task.
 
Labels: -Pri-3 Pri-2
Owner: wylieb@chromium.org
Status: Assigned (was: Available)
Cc: wylieb@chromium.org
 Issue 808947  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d6da1ce364f22463e18c714d88a0fd7960a48ba8

commit d6da1ce364f22463e18c714d88a0fd7960a48ba8
Author: Brandon Wylie <wylieb@chromium.org>
Date: Mon Mar 12 23:07:32 2018

[Findit] Flake Analyzer - Salvage failed swarming tasks

Even if a swarming task failed, if it still has the fields required
to add to a data point then the task should be used. This cl adds a
check for the fields required to create a data point.

Bug:772509
Change-Id: I8241ba728fee321bbd295920e435acfc517f4c70
Reviewed-on: https://chromium-review.googlesource.com/953182
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/d6da1ce364f22463e18c714d88a0fd7960a48ba8/appengine/findit/services/flake_failure/flake_analysis_util.py
[modify] https://crrev.com/d6da1ce364f22463e18c714d88a0fd7960a48ba8/appengine/findit/services/flake_failure/pass_rate_util.py
[modify] https://crrev.com/d6da1ce364f22463e18c714d88a0fd7960a48ba8/appengine/findit/services/flake_failure/test/flake_analysis_util_test.py
[modify] https://crrev.com/d6da1ce364f22463e18c714d88a0fd7960a48ba8/appengine/findit/services/flake_failure/data_point_util.py
[modify] https://crrev.com/d6da1ce364f22463e18c714d88a0fd7960a48ba8/appengine/findit/services/flake_failure/test/data_point_util_test.py
[modify] https://crrev.com/d6da1ce364f22463e18c714d88a0fd7960a48ba8/appengine/findit/waterfall/flake/update_flake_analysis_data_points_pipeline.py
[modify] https://crrev.com/d6da1ce364f22463e18c714d88a0fd7960a48ba8/appengine/findit/waterfall/flake/test/update_flake_analysis_data_points_pipeline_test.py
[modify] https://crrev.com/d6da1ce364f22463e18c714d88a0fd7960a48ba8/appengine/findit/services/flake_failure/test/pass_rate_util_test.py

Comment 4 by wylieb@chromium.org, Mar 27 2018

Labels: -Pri-2 Pri-0

Comment 5 by wylieb@chromium.org, Mar 27 2018

Blocking: 826087
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 30 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 13 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by wylieb@chromium.org, Apr 13 2018

Status: Fixed (was: Assigned)

Sign in to add a comment