New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772505 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Debug builds of Chrome for Mac crashing when typing Hangul

Project Member Reported by rlanday@chromium.org, Oct 6 2017

Issue description

Chrome Version: 63.0.3235.0 (Developer Build) (64-bit)
OS: macOS 10.12.6

What steps will reproduce the problem?
(1) Go to editpad.org
(2) Switch your system keyboard to Korean (I tested on 2-Set Korean)
(3) Type a letter on your keyboard to start composing some Hangul and then hit return

What is the expected result?

Browser should not crash.

What happens instead?

Browser process crashes.


[96677:775:1006/131119.642093:FATAL:render_widget_host_latency_tracker.cc(286)] Check failed: event.GetType() == WebInputEvent::kChar || event.GetType() == WebInputEvent::kRawKeyDown. 
0   libbase.dylib                       0x000000010a89756e base::debug::StackTrace::StackTrace(unsigned long) + 174
1   libbase.dylib                       0x000000010a89762d base::debug::StackTrace::StackTrace(unsigned long) + 29
2   libbase.dylib                       0x000000010a8958dc base::debug::StackTrace::StackTrace() + 28
3   libbase.dylib                       0x000000010a92e83f logging::LogMessage::~LogMessage() + 479
4   libbase.dylib                       0x000000010a92c1a5 logging::LogMessage::~LogMessage() + 21
5   libcontent.dylib                    0x00000001286893e6 content::RenderWidgetHostLatencyTracker::OnInputEvent(blink::WebInputEvent const&, ui::LatencyInfo*) + 886
6   libcontent.dylib                    0x00000001288dde3f content::RenderWidgetHostImpl::DispatchInputEventWithLatencyInfo(blink::WebInputEvent const&, ui::LatencyInfo*) + 79
7   libcontent.dylib                    0x00000001288dfaeb content::RenderWidgetHostImpl::ForwardKeyboardEventWithCommands(content::NativeWebKeyboardEvent const&, ui::LatencyInfo const&, std::__1::vector<content::EditCommand, std::__1::allocator<content::EditCommand> > const*, bool*) + 1371
8   libcontent.dylib                    0x00000001288df581 content::RenderWidgetHostImpl::ForwardKeyboardEventWithLatencyInfo(content::NativeWebKeyboardEvent const&, ui::LatencyInfo const&) + 49
9   libcontent.dylib                    0x000000012893b6ae -[RenderWidgetHostViewCocoa keyEvent:wasKeyEquivalent:] + 8206
10  libcontent.dylib                    0x0000000128939688 -[RenderWidgetHostViewCocoa keyEvent:] + 200
11  libui_base.dylib                    0x000000010b25fd99 -[BaseView keyDown:] + 57
12  AppKit                              0x00007fff878a32cc -[NSWindow(NSEventRouting) _reallySendEvent:isDelayedEvent:] + 4086
13  AppKit                              0x00007fff878a1f0a -[NSWindow(NSEventRouting) sendEvent:] + 541
14  libchrome_dll.dylib                 0x00000001168bcaba -[ChromeEventProcessingWindow sendEvent:] + 122
15  AppKit                              0x00007fff877274a8 -[NSApplication(NSEvent) sendEvent:] + 4768
16  libchrome_dll.dylib                 0x0000000110e039e3 __34-[BrowserCrApplication sendEvent:]_block_invoke + 259
17  libbase.dylib                       0x000000010a93387a base::mac::CallWithEHFrame(void () block_pointer) + 10
18  libchrome_dll.dylib                 0x0000000110e0376f -[BrowserCrApplication sendEvent:] + 575
19  AppKit                              0x00007fff86fa1427 -[NSApplication run] + 1002
20  libbase.dylib                       0x000000010a9944b8 base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 312
21  libbase.dylib                       0x000000010a991254 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 116
22  libbase.dylib                       0x000000010a98049b base::MessageLoop::Run() + 299
23  libbase.dylib                       0x000000010aa7dc96 base::RunLoop::Run() + 262
24  libchrome_dll.dylib                 0x0000000110e10888 ChromeBrowserMainParts::MainMessageLoopRun(int*) + 376
25  libcontent.dylib                    0x0000000127967b97 content::BrowserMainLoop::RunMainMessageLoopParts() + 455
26  libcontent.dylib                    0x00000001279719ec content::BrowserMainRunnerImpl::Run() + 396
27  libcontent.dylib                    0x000000012795b24d content::BrowserMain(content::MainFunctionParams const&) + 397
28  libcontent.dylib                    0x000000012a17dc09 content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) + 585
29  libcontent.dylib                    0x000000012a17f430 content::ContentMainRunnerImpl::Run() + 1280
30  libcontent.dylib                    0x000000012a17bddd content::ContentServiceManagerMainDelegate::RunEmbedderProcess() + 61
31  libembedder.dylib                   0x000000010a3a9777 service_manager::Main(service_manager::MainParams const&) + 1911
32  libcontent.dylib                    0x000000012a17d979 content::ContentMain(content::ContentMainParams const&) + 89
33  libchrome_dll.dylib                 0x000000010eef9bbe ChromeMain + 270
34  Chromium                            0x00000001087d5de6 main + 630
35  libdyld.dylib                       0x00007fff9ec3b235 start + 1

Trace/BPT trap: 5


 
Cc: nzolghadr@chromium.org tdres...@chromium.org
Owner: dtapu...@chromium.org
Whoops, I missed this.

Dave, could someone on the input team dig into this?
Cc: dtapu...@chromium.org
Components: Blink>Input
Labels: Hotlist-Input-Dev
Owner: eirage@chromium.org
eirage@ can you take a look?
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ec96ea3b62270dc5fb308efb0e02e2002bc98e7

commit 9ec96ea3b62270dc5fb308efb0e02e2002bc98e7
Author: Ella Ge <eirage@chromium.org>
Date: Thu Oct 19 13:44:59 2017

set latency_info source_event_type on fake KeyUp

latency_info.source_event_type for fake KeyUp event
should be OTHER instead of KEYPRESS.

Bug:  772505 
Change-Id: Ie43e31426e345f427f0eeb9863fbd0449c1c67dc
Reviewed-on: https://chromium-review.googlesource.com/727370
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510072}
[modify] https://crrev.com/9ec96ea3b62270dc5fb308efb0e02e2002bc98e7/content/browser/renderer_host/render_widget_host_view_mac.mm

Comment 4 by eirage@chromium.org, Oct 19 2017

Status: Fixed (was: Assigned)

Sign in to add a comment