This is an intermediate goal before we have full-fledged chrome UI for Fuchsia.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6af0b54f5fa9656e42a3fcf252488a927b031ab8 commit 6af0b54f5fa9656e42a3fcf252488a927b031ab8 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Mon Oct 09 22:36:04 2017 Update GN files to make is_chromecast compatible with is_fuchsia With these changes GN is happy when target_os="Fuchsia" and is_chromecast=true. Build still fails. TBR=scottmg@chromium.org Bug: 772488 Change-Id: I335bc08d555b6a851f4afbd296bf05e9cdc9b4e9 Reviewed-on: https://chromium-review.googlesource.com/703876 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#507513} [modify] https://crrev.com/6af0b54f5fa9656e42a3fcf252488a927b031ab8/build/config/chromecast_build.gni [modify] https://crrev.com/6af0b54f5fa9656e42a3fcf252488a927b031ab8/chrome/app/BUILD.gn [modify] https://crrev.com/6af0b54f5fa9656e42a3fcf252488a927b031ab8/chrome/browser/BUILD.gn [modify] https://crrev.com/6af0b54f5fa9656e42a3fcf252488a927b031ab8/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/6af0b54f5fa9656e42a3fcf252488a927b031ab8/chrome/test/BUILD.gn [modify] https://crrev.com/6af0b54f5fa9656e42a3fcf252488a927b031ab8/chromecast/app/BUILD.gn [modify] https://crrev.com/6af0b54f5fa9656e42a3fcf252488a927b031ab8/chromecast/browser/BUILD.gn [modify] https://crrev.com/6af0b54f5fa9656e42a3fcf252488a927b031ab8/chromecast/crash/BUILD.gn [modify] https://crrev.com/6af0b54f5fa9656e42a3fcf252488a927b031ab8/chromecast/net/BUILD.gn [modify] https://crrev.com/6af0b54f5fa9656e42a3fcf252488a927b031ab8/chromecast/renderer/BUILD.gn [modify] https://crrev.com/6af0b54f5fa9656e42a3fcf252488a927b031ab8/components/crash/content/app/BUILD.gn [modify] https://crrev.com/6af0b54f5fa9656e42a3fcf252488a927b031ab8/components/crash/content/browser/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b98909890c716667ef542d1d215cd2b0d1cf14f commit 7b98909890c716667ef542d1d215cd2b0d1cf14f Author: Sergey Ulanov <sergeyu@chromium.org> Date: Mon Oct 09 23:20:45 2017 Make cast_shell buildable for Fuchsia 1. Added ifdefs around crash-reporting, bug 753619 . 2. Added CastContentWindowFuchsia. 4. Disabled NetworkChangeNotifierFactoryCast - will need to add a Fuchsia-specific implementation once we have an API Bug: 772488 , 753619 Change-Id: Id48af74ccdb003230233a6061bbf49412a571ce6 Reviewed-on: https://chromium-review.googlesource.com/705399 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#507529} [modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/BUILD.gn [modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/app/cast_main_delegate.cc [modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/app/cast_main_delegate.h [modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/base/file_utils.cc [modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/browser/BUILD.gn [modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/browser/cast_browser_main_parts.cc [modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/browser/cast_content_browser_client.cc [add] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/browser/cast_content_window_aura.cc [rename] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/browser/cast_content_window_aura.h [delete] https://crrev.com/b81f263e6f4535b7b311d180976078d9274dbc89/chromecast/browser/cast_content_window_linux.cc [modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/browser/metrics/cast_metrics_service_client.cc [modify] https://crrev.com/7b98909890c716667ef542d1d215cd2b0d1cf14f/chromecast/renderer/cast_content_renderer_client.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e35c3590ded464a01804bd405a8485ee4083806 commit 1e35c3590ded464a01804bd405a8485ee4083806 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Wed Oct 11 01:49:42 2017 Add skeleton for MediaPipelineBackend on Fuchsia. This CL adds skeleton for implementation of the media backend library. Will integrate it with the system in a separate CL. Bug: 772488 Change-Id: I9b8c7226eca2d34bbd607be2ad793dfe39a1eaac Reviewed-on: https://chromium-review.googlesource.com/710510 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#507857} [modify] https://crrev.com/1e35c3590ded464a01804bd405a8485ee4083806/chromecast/BUILD.gn [add] https://crrev.com/1e35c3590ded464a01804bd405a8485ee4083806/chromecast/media/cma/backend/fuchsia/BUILD.gn [add] https://crrev.com/1e35c3590ded464a01804bd405a8485ee4083806/chromecast/media/cma/backend/fuchsia/audio_decoder_fuchsia.cc [add] https://crrev.com/1e35c3590ded464a01804bd405a8485ee4083806/chromecast/media/cma/backend/fuchsia/audio_decoder_fuchsia.h [add] https://crrev.com/1e35c3590ded464a01804bd405a8485ee4083806/chromecast/media/cma/backend/fuchsia/cast_media_shlib_fuchsia.cc [add] https://crrev.com/1e35c3590ded464a01804bd405a8485ee4083806/chromecast/media/cma/backend/fuchsia/media_capabilities_shlib_fuchsia.cc [add] https://crrev.com/1e35c3590ded464a01804bd405a8485ee4083806/chromecast/media/cma/backend/fuchsia/media_pipeline_backend_fuchsia.cc [add] https://crrev.com/1e35c3590ded464a01804bd405a8485ee4083806/chromecast/media/cma/backend/fuchsia/media_pipeline_backend_fuchsia.h [add] https://crrev.com/1e35c3590ded464a01804bd405a8485ee4083806/chromecast/media/cma/backend/fuchsia/media_pipeline_backend_fuchsia_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f73f9111adc2bc95497b23d879e2d5d5453d02d5 commit f73f9111adc2bc95497b23d879e2d5d5453d02d5 Author: Kevin Marshall <kmarshall@chromium.org> Date: Wed Oct 11 21:50:17 2017 Inline Chromecast's "file_utils" contents and remove the source files. Bug: 772488 Change-Id: I9861cd06f3b1eab19e0bb15250f202e96cb35f06 Reviewed-on: https://chromium-review.googlesource.com/710616 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#508132} [modify] https://crrev.com/f73f9111adc2bc95497b23d879e2d5d5453d02d5/chromecast/base/BUILD.gn [delete] https://crrev.com/8a8997210055ba84753f6a333def51f830006bf8/chromecast/base/file_utils.cc [delete] https://crrev.com/8a8997210055ba84753f6a333def51f830006bf8/chromecast/base/file_utils.h [modify] https://crrev.com/f73f9111adc2bc95497b23d879e2d5d5453d02d5/chromecast/crash/linux/synchronized_minidump_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9db4b1582e7bac38d95f0b22e6904d4fa0cf07eb commit 9db4b1582e7bac38d95f0b22e6904d4fa0cf07eb Author: Kevin Marshall <kmarshall@chromium.org> Date: Wed Oct 11 22:29:43 2017 Make chrome/browser's WebRTC deps contingent on |enable_webrtc|. Bug: 772488 Change-Id: Ic990bdece21790e46eb5218fbdba69a6eea3c020 Reviewed-on: https://chromium-review.googlesource.com/714121 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#508147} [modify] https://crrev.com/9db4b1582e7bac38d95f0b22e6904d4fa0cf07eb/chrome/browser/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51a73d2f8791f87cd5708281f6c3fd5e48729050 commit 51a73d2f8791f87cd5708281f6c3fd5e48729050 Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Oct 12 19:51:16 2017 Add Fuchsia (target_os=fuchsia) to the list of Policy platforms. Bug: 772488 Change-Id: I51a3ecfdb37b68b1646802710a02ce06681260a7 Reviewed-on: https://chromium-review.googlesource.com/710862 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: James Robinson <jamesr@chromium.org> Cr-Commit-Position: refs/heads/master@{#508394} [modify] https://crrev.com/51a73d2f8791f87cd5708281f6c3fd5e48729050/components/policy/tools/generate_policy_source.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e2d5b46ff88f3bebecbe99275e1bef039294f38 commit 0e2d5b46ff88f3bebecbe99275e1bef039294f38 Author: Kevin Marshall <kmarshall@chromium.org> Date: Tue Oct 17 18:51:45 2017 Add Fuchsia-specific enums and ifdefs to WebsiteSettingsRegistry. Bug: 772488 Change-Id: Ie71f5b620b59c9618bbe4c05b61dad23ba37fb23 Reviewed-on: https://chromium-review.googlesource.com/710861 Reviewed-by: Raymes Khoury <raymes@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#509462} [modify] https://crrev.com/0e2d5b46ff88f3bebecbe99275e1bef039294f38/components/content_settings/core/browser/website_settings_registry.cc [modify] https://crrev.com/0e2d5b46ff88f3bebecbe99275e1bef039294f38/components/content_settings/core/browser/website_settings_registry.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b9c8c1bb9543a1e60eab3d5826a16bdda4a46ab commit 9b9c8c1bb9543a1e60eab3d5826a16bdda4a46ab Author: Sergey Ulanov <sergeyu@chromium.org> Date: Tue Oct 17 23:30:02 2017 Remove incorrect DCHECK in IsNativeGpuMemoryBufferConfigurationSupported() GetNativeGpuMemoryBufferType() returns EMPTY_BUFFER on all platforms other than MacOS and Linux, so when running cast_shell on Fuchsia a DCHECK in IsNativeGpuMemoryBufferConfigurationSupported() was failing. Replaced that DCHECK with an if statement that returns false in that case. Bug: 772488 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icaeba966b46f1846540c3137e675ae223593fa7e Reviewed-on: https://chromium-review.googlesource.com/723592 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#509590} [modify] https://crrev.com/9b9c8c1bb9543a1e60eab3d5826a16bdda4a46ab/gpu/ipc/common/gpu_memory_buffer_support.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ef2d7df6df2812191ba5881201ca8b31e4b1619 commit 6ef2d7df6df2812191ba5881201ca8b31e4b1619 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Wed Oct 18 20:39:50 2017 Move ALSA dependencies out of StreamMixerAlsa Previously StreamMixerAlsa was responsible for mixing multiple streams and playing mixed stream using ALSA. This CL separate these two features into two separate classes. Now StreamMixerAlsa doesn't call ALSA directly, instead it calls MixerOutputStream interface to play mixed stream. AudioOutputStream is implemented AudioOutputStreamAlsa for ALSA. This change will allow to reuse the mixer on platforms that don't implement ALSA, such as Fuchsia. In a separate CL I will rename StreamMixerAlsa to StreamMixer and will move it out of the ALSA directory. Bug: 772488 Change-Id: I55e1b53d1884e303f0de54066450f3f9e8338755 Reviewed-on: https://chromium-review.googlesource.com/714516 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#509858} [modify] https://crrev.com/6ef2d7df6df2812191ba5881201ca8b31e4b1619/chromecast/media/cma/backend/alsa/BUILD.gn [add] https://crrev.com/6ef2d7df6df2812191ba5881201ca8b31e4b1619/chromecast/media/cma/backend/alsa/mixer_output_stream_alsa.cc [add] https://crrev.com/6ef2d7df6df2812191ba5881201ca8b31e4b1619/chromecast/media/cma/backend/alsa/mixer_output_stream_alsa.h [modify] https://crrev.com/6ef2d7df6df2812191ba5881201ca8b31e4b1619/chromecast/media/cma/backend/alsa/stream_mixer_alsa.cc [modify] https://crrev.com/6ef2d7df6df2812191ba5881201ca8b31e4b1619/chromecast/media/cma/backend/alsa/stream_mixer_alsa.h [modify] https://crrev.com/6ef2d7df6df2812191ba5881201ca8b31e4b1619/chromecast/media/cma/backend/alsa/stream_mixer_alsa_unittest.cc [add] https://crrev.com/6ef2d7df6df2812191ba5881201ca8b31e4b1619/chromecast/media/cma/backend/mixer_output_stream.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/026a20aa5f74138d864aa0b40711831818350a52 commit 026a20aa5f74138d864aa0b40711831818350a52 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Wed Oct 18 22:23:31 2017 Chromecast: Move audio post-processing and mixing out of backend/alsa dir. Moved audio-processing code that doesn't have dependency on alsa out of chromecast/media/cma/backend/alsa to chromecast/media/cma/backend . This will allow to use this code on other platform that don't use ALSA Bug: 772488 Change-Id: I142557999d7bb0046f8a9de2143a66b1e06ca963 Reviewed-on: https://chromium-review.googlesource.com/716807 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#509895} [modify] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/BUILD.gn [modify] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/BUILD.gn [modify] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/alsa/BUILD.gn [modify] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc [modify] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/alsa/audio_decoder_alsa.h [modify] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/alsa/cast_media_shlib.cc [modify] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/alsa/media_pipeline_backend_alsa.h [delete] https://crrev.com/14aa2e0e93ed0d0f1e72009f44e8ff0167a8749d/chromecast/media/cma/backend/alsa/stream_mixer_alsa_input.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/alsa/stream_mixer_unittest.cc [modify] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/alsa/volume_control.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/cast_audio_json.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/cast_audio_json.h [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/filter_group.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/filter_group.h [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/filter_group_unittest.cc [modify] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/fuchsia/BUILD.gn [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processing_pipeline.h [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processing_pipeline_impl.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processing_pipeline_impl.h [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processing_pipeline_parser.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processing_pipeline_parser.h [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processor_factory.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processor_factory.h [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processors/governor.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processors/governor.h [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processors/governor_create.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processors/governor_unittest.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processors/post_processor_unittest.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processors/post_processor_unittest.h [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processors/saturated_gain.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processors/saturated_gain.h [copy] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processors/saturated_gain_create.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/post_processors/saturated_gain_unittest.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/stream_mixer.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/stream_mixer.h [add] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/stream_mixer_input.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/stream_mixer_input.h [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/stream_mixer_input_impl.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/stream_mixer_input_impl.h [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/volume_map.cc [rename] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/media/cma/backend/volume_map.h [modify] https://crrev.com/026a20aa5f74138d864aa0b40711831818350a52/chromecast/public/media/audio_post_processor_shlib.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f61ca1d5f202920c05dbe12f660123ae9bf11f4b commit f61ca1d5f202920c05dbe12f660123ae9bf11f4b Author: Sergey Ulanov <sergeyu@chromium.org> Date: Thu Oct 19 01:40:26 2017 Move MediaPipelineBackendAlsa out of alsa directory Renamed and moved parts of the audio-only backend: alsa/MediaPipelineBackendAlsa -> MediaPipelineBackendAudio alsa/AudioDecoderAlsa -> AudioDecoderForMixer alsa/media_codec_support_cast_audio.cc -> media_codec_support_cast_audio.cc This will allow to reuse these classes on platforms that don't implement ALSA. TBR=dalecurtis@chromium.org Bug: 772488 Change-Id: I2bc557c1dd9359d2690dc984a75116af48685ebc Reviewed-on: https://chromium-review.googlesource.com/719459 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#509967} [modify] https://crrev.com/f61ca1d5f202920c05dbe12f660123ae9bf11f4b/chromecast/media/cma/backend/BUILD.gn [rename] https://crrev.com/f61ca1d5f202920c05dbe12f660123ae9bf11f4b/chromecast/media/cma/backend/DEPS [modify] https://crrev.com/f61ca1d5f202920c05dbe12f660123ae9bf11f4b/chromecast/media/cma/backend/alsa/BUILD.gn [modify] https://crrev.com/f61ca1d5f202920c05dbe12f660123ae9bf11f4b/chromecast/media/cma/backend/alsa/alsa_wrapper.cc [modify] https://crrev.com/f61ca1d5f202920c05dbe12f660123ae9bf11f4b/chromecast/media/cma/backend/alsa/cast_media_shlib.cc [delete] https://crrev.com/5356c29c2baeffbc8684541feead29e9ef1d555a/chromecast/media/cma/backend/alsa/media_pipeline_backend_alsa.cc [modify] https://crrev.com/f61ca1d5f202920c05dbe12f660123ae9bf11f4b/chromecast/media/cma/backend/alsa/volume_control.cc [modify] https://crrev.com/f61ca1d5f202920c05dbe12f660123ae9bf11f4b/chromecast/media/cma/backend/android/media_pipeline_backend_android.h [rename] https://crrev.com/f61ca1d5f202920c05dbe12f660123ae9bf11f4b/chromecast/media/cma/backend/audio_decoder_for_mixer.cc [rename] https://crrev.com/f61ca1d5f202920c05dbe12f660123ae9bf11f4b/chromecast/media/cma/backend/audio_decoder_for_mixer.h [rename] https://crrev.com/f61ca1d5f202920c05dbe12f660123ae9bf11f4b/chromecast/media/cma/backend/media_codec_support_cast_audio.cc [add] https://crrev.com/f61ca1d5f202920c05dbe12f660123ae9bf11f4b/chromecast/media/cma/backend/media_pipeline_backend_audio.cc [rename] https://crrev.com/f61ca1d5f202920c05dbe12f660123ae9bf11f4b/chromecast/media/cma/backend/media_pipeline_backend_audio.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c5c4e4e82920a6eb7460e5117f7f1a0cb453165 commit 5c5c4e4e82920a6eb7460e5117f7f1a0cb453165 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Thu Oct 19 06:29:02 2017 Replace cast_alsa_cma_backend_unittests with cast_audio_backend_unittests All tests that were executed in cast_alsa_cma_backed_unittests are now built as cast_audio_backend_unittest. Updated all buildbot configs to run the new test binary and removed the old one. Bug: 772488 Change-Id: I8339687c082c8ffb828e9676700cd6f7e39ecfe9 Reviewed-on: https://chromium-review.googlesource.com/719726 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#510011} [modify] https://crrev.com/5c5c4e4e82920a6eb7460e5117f7f1a0cb453165/chromecast/BUILD.gn [modify] https://crrev.com/5c5c4e4e82920a6eb7460e5117f7f1a0cb453165/chromecast/media/cma/backend/BUILD.gn [modify] https://crrev.com/5c5c4e4e82920a6eb7460e5117f7f1a0cb453165/chromecast/media/cma/backend/alsa/BUILD.gn [modify] https://crrev.com/5c5c4e4e82920a6eb7460e5117f7f1a0cb453165/testing/buildbot/chromium.linux.json [modify] https://crrev.com/5c5c4e4e82920a6eb7460e5117f7f1a0cb453165/testing/buildbot/gn_isolate_map.pyl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d3e5ceb2036af5333bb8bef4c54046767cd3f460 commit d3e5ceb2036af5333bb8bef4c54046767cd3f460 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Thu Oct 19 06:30:34 2017 Move VolumeControl class out of ALSA directory Moved VolumeControl from backend/alsa to backend directory. To remove ALSA dependency added SystemVolumeControl interface that abstracts functionaly implemented in AlsaVolumeControl. Bug: 772488 Change-Id: I40575d873df00829b445dc8309ad0a61038009c8 Reviewed-on: https://chromium-review.googlesource.com/720076 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#510014} [modify] https://crrev.com/d3e5ceb2036af5333bb8bef4c54046767cd3f460/chromecast/media/cma/backend/BUILD.gn [modify] https://crrev.com/d3e5ceb2036af5333bb8bef4c54046767cd3f460/chromecast/media/cma/backend/alsa/BUILD.gn [modify] https://crrev.com/d3e5ceb2036af5333bb8bef4c54046767cd3f460/chromecast/media/cma/backend/alsa/alsa_volume_control.cc [modify] https://crrev.com/d3e5ceb2036af5333bb8bef4c54046767cd3f460/chromecast/media/cma/backend/alsa/alsa_volume_control.h [add] https://crrev.com/d3e5ceb2036af5333bb8bef4c54046767cd3f460/chromecast/media/cma/backend/system_volume_control.h [rename] https://crrev.com/d3e5ceb2036af5333bb8bef4c54046767cd3f460/chromecast/media/cma/backend/volume_control.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/042c62afc88095c7d46b4283eedf52479f149b8a commit 042c62afc88095c7d46b4283eedf52479f149b8a Author: Sergey Ulanov <sergeyu@chromium.org> Date: Thu Oct 19 17:19:23 2017 Implement MediaPipelineBackend for Fuchsia The new backend reuses most of ALSA backend. There are two parts that are different: - Added new AudioOutputStreamFuchsia to be used instead of AudioOutputStreamAlsa. - Added stub for SystemVolumeControl. Bug: 772488 Change-Id: Icacb070323f30c3d7e6a50bd1f5cf5a58c4251f9 Reviewed-on: https://chromium-review.googlesource.com/722323 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: James Robinson <jamesr@chromium.org> Cr-Commit-Position: refs/heads/master@{#510116} [modify] https://crrev.com/042c62afc88095c7d46b4283eedf52479f149b8a/chromecast/media/base/slew_volume_unittests.cc [modify] https://crrev.com/042c62afc88095c7d46b4283eedf52479f149b8a/chromecast/media/cma/backend/audio_decoder_for_mixer.cc [modify] https://crrev.com/042c62afc88095c7d46b4283eedf52479f149b8a/chromecast/media/cma/backend/fuchsia/BUILD.gn [delete] https://crrev.com/fc2b2f04ed20d88113c10951036ca403891c435f/chromecast/media/cma/backend/fuchsia/audio_decoder_fuchsia.cc [delete] https://crrev.com/fc2b2f04ed20d88113c10951036ca403891c435f/chromecast/media/cma/backend/fuchsia/audio_decoder_fuchsia.h [modify] https://crrev.com/042c62afc88095c7d46b4283eedf52479f149b8a/chromecast/media/cma/backend/fuchsia/cast_media_shlib_fuchsia.cc [add] https://crrev.com/042c62afc88095c7d46b4283eedf52479f149b8a/chromecast/media/cma/backend/fuchsia/fuchsia_volume_control.cc [add] https://crrev.com/042c62afc88095c7d46b4283eedf52479f149b8a/chromecast/media/cma/backend/fuchsia/fuchsia_volume_control.h [delete] https://crrev.com/fc2b2f04ed20d88113c10951036ca403891c435f/chromecast/media/cma/backend/fuchsia/media_capabilities_shlib_fuchsia.cc [delete] https://crrev.com/fc2b2f04ed20d88113c10951036ca403891c435f/chromecast/media/cma/backend/fuchsia/media_pipeline_backend_fuchsia.cc [delete] https://crrev.com/fc2b2f04ed20d88113c10951036ca403891c435f/chromecast/media/cma/backend/fuchsia/media_pipeline_backend_fuchsia.h [delete] https://crrev.com/fc2b2f04ed20d88113c10951036ca403891c435f/chromecast/media/cma/backend/fuchsia/media_pipeline_backend_fuchsia_unittest.cc [add] https://crrev.com/042c62afc88095c7d46b4283eedf52479f149b8a/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.cc [add] https://crrev.com/042c62afc88095c7d46b4283eedf52479f149b8a/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.h [add] https://crrev.com/042c62afc88095c7d46b4283eedf52479f149b8a/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/619126dd677519e89c7ac7be390c35fc7090e24d commit 619126dd677519e89c7ac7be390c35fc7090e24d Author: Sergey Ulanov <sergeyu@chromium.org> Date: Fri Oct 20 15:49:02 2017 Restore //chromecast/media/cma/backend:null GN target This target was removed in https://chromium-review.googlesource.com/c/chromium/src/+/716807. There is internal code that depends on this target. Bug: 772488 Change-Id: I944b68d42192c21ec8ebd9f6d4deaa14779dca09 Reviewed-on: https://chromium-review.googlesource.com/729743 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#510447} [modify] https://crrev.com/619126dd677519e89c7ac7be390c35fc7090e24d/chromecast/media/cma/backend/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/602a84a64e268806c1624e3c888d09ff15435da0 commit 602a84a64e268806c1624e3c888d09ff15435da0 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Mon Oct 23 21:20:01 2017 chromecast: Link media backend statically on Fuchsia Currently there is only one backend on Fuchsia, so we don't benefit from building the backend as a shared library. Also separated media_resource_tracker in //chromecast/media/base into a separate target. This was necessary to avoid circular dependencies between gn targets. Bug: 772488 Change-Id: Ide5c2cbc909ea77c7bec375f77fd82a1f4855144 Reviewed-on: https://chromium-review.googlesource.com/731835 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#510921} [modify] https://crrev.com/602a84a64e268806c1624e3c888d09ff15435da0/chromecast/media/BUILD.gn [modify] https://crrev.com/602a84a64e268806c1624e3c888d09ff15435da0/chromecast/media/base/BUILD.gn [modify] https://crrev.com/602a84a64e268806c1624e3c888d09ff15435da0/chromecast/media/cdm/BUILD.gn [modify] https://crrev.com/602a84a64e268806c1624e3c888d09ff15435da0/chromecast/media/cma/backend/fuchsia/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/659b0198872b272fb6696e4b7936553b86c08e9b commit 659b0198872b272fb6696e4b7936553b86c08e9b Author: Sergey Ulanov <sergeyu@chromium.org> Date: Tue Oct 24 18:30:08 2017 Add post_processor_test_support to unbreak internal chromecast build post_processor_test_support target was removed in https://crrev.com/509895 , but there are internal targets that still depend on it. Bug: 772488 Change-Id: I836004b40dc7663e6a674b5fb9ced4b0b121274e Merge-With: eureka-internal/113285 Reviewed-on: https://chromium-review.googlesource.com/734138 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Stephen Lanham <slan@chromium.org> Reviewed-by: Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#511213} [modify] https://crrev.com/659b0198872b272fb6696e4b7936553b86c08e9b/chromecast/media/cma/backend/BUILD.gn [add] https://crrev.com/659b0198872b272fb6696e4b7936553b86c08e9b/chromecast/media/cma/backend/post_processors/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f6732d497dc292fef6ef6e7c63faca52ce43ce4 commit 9f6732d497dc292fef6ef6e7c63faca52ce43ce4 Author: Scott Graham <scottmg@chromium.org> Date: Tue Oct 24 19:20:44 2017 Remove unnecessary global AtExitManager in cast_media_shlib_fuchsia.cc Causes DCHECK when run with those on when main loop's AtExitManager is constructed. Bug: 772488 Change-Id: Iffd0d97230985c07f81ff8fc6931099bfc58b7a8 Reviewed-on: https://chromium-review.googlesource.com/735516 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#511231} [modify] https://crrev.com/9f6732d497dc292fef6ef6e7c63faca52ce43ce4/chromecast/media/cma/backend/fuchsia/cast_media_shlib_fuchsia.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25c98d924c8e0b76bd01daf53997a978576af3da commit 25c98d924c8e0b76bd01daf53997a978576af3da Author: Sergey Ulanov <sergeyu@chromium.org> Date: Tue Oct 24 23:16:25 2017 Don't compile cast_audio_backend_unittests on Android cast_tests was depending on cast_audio_backend_unittests, but these unittests are not intended to be compiled on Android. Bug: 772488 Change-Id: I2923c9d6b127887fe187a9fa4b99b13e070a1d52 Reviewed-on: https://chromium-review.googlesource.com/736609 Reviewed-by: Stephen Lanham <slan@chromium.org> Commit-Queue: Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#511297} [modify] https://crrev.com/25c98d924c8e0b76bd01daf53997a978576af3da/chromecast/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/549c712977c9bd8c81ac978548be8fa0f84fa7e9 commit 549c712977c9bd8c81ac978548be8fa0f84fa7e9 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Wed Oct 25 07:02:36 2017 Add views::MenuConfig::Init() implementation for Fuchsia Component build of cast_shell was failing without this Bug: 772488 , 754782 Change-Id: I6d819a3af53d445ee03598a85db830a7fa49f8ac Reviewed-on: https://chromium-review.googlesource.com/734703 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#511399} [modify] https://crrev.com/549c712977c9bd8c81ac978548be8fa0f84fa7e9/ui/views/BUILD.gn [add] https://crrev.com/549c712977c9bd8c81ac978548be8fa0f84fa7e9/ui/views/controls/menu/menu_config_fuchsia.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd2f4f3694722c49e2f50c0e416a4f779878ffdb commit cd2f4f3694722c49e2f50c0e416a4f779878ffdb Author: Sergey Ulanov <sergeyu@chromium.org> Date: Thu Oct 26 01:11:56 2017 Extend exe_runner.py for Fuchsia to allow passing addional files. Now exe_runner.py accepts --extra-file option that allows to add additional files to bootfs. This option will be useful to pass configuration file file cast_shell. Bug: 772488 Change-Id: Ic2b97ccf6b7a999e58cf5721af8e8d944b4120bc Reviewed-on: https://chromium-review.googlesource.com/738911 Reviewed-by: James Robinson <jamesr@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#511679} [modify] https://crrev.com/cd2f4f3694722c49e2f50c0e416a4f779878ffdb/build/fuchsia/exe_runner.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08e68b9785ccbc23ff46dd739ed2ec47a6b8b708 commit 08e68b9785ccbc23ff46dd739ed2ec47a6b8b708 Author: Scott Graham <scottmg@chromium.org> Date: Thu Oct 26 02:00:13 2017 Don't gncheck #include of Linux header in cross-platform code scottmg@around:/work/cr/src$ gn gen out/fuchgncheck --args='target_os="fuchsia" is_chromecast=true' --check ERROR at //third_party/WebKit/Source/platform/wtf/typed_arrays/ArrayBufferContents.cpp:32:11: Include not allowed. ^--------------------------------------- It is not in any dependency of //third_party/WebKit/Source/platform/wtf:wtf The include file is in the target(s): //sandbox/linux:sandbox_services which should somehow be reachable. Bug: 707031, 772488 Change-Id: If109ffa0365a5ad676f1c580b4f0ea117c32eb23 Reviewed-on: https://chromium-review.googlesource.com/738819 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#511692} [modify] https://crrev.com/08e68b9785ccbc23ff46dd739ed2ec47a6b8b708/third_party/WebKit/Source/platform/wtf/typed_arrays/ArrayBufferContents.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2fb2566349af93f14d580a1d66879c7c4aac3f6 commit a2fb2566349af93f14d580a1d66879c7c4aac3f6 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Thu Oct 26 17:39:45 2017 Update cast_audio_json.cc for Fuchsia kCastAudioJsonFilePath is used to specify path for audio cast_shell. Previously it was always set to /etc/cast_audio.json, but that makes little sense for Fuchsia. Added ifdef to set the pat to /system/data/cast_audio.json Bug: 772488 Change-Id: I35363dc710a92a1eaea18135119a30b39b77e583 Reviewed-on: https://chromium-review.googlesource.com/737488 Reviewed-by: James Robinson <jamesr@chromium.org> Reviewed-by: Stephen Lanham <slan@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#511867} [modify] https://crrev.com/a2fb2566349af93f14d580a1d66879c7c4aac3f6/chromecast/media/cma/backend/cast_audio_json.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/613bdd6fbfc49acf332c7867ae495f4502c6f526 commit 613bdd6fbfc49acf332c7867ae495f4502c6f526 Author: Kevin Marshall <kmarshall@chromium.org> Date: Thu Oct 26 21:32:04 2017 Fuchsia: add blocking wait until Internet connectivity is achieved. Without this check, test and binary executables can start running before the network interface has an IP address, increasing the likelihood of unexpected failures. Bug: 772488 Change-Id: Iecf1b0c56a23898b009f216658796b7034fffcaa Reviewed-on: https://chromium-review.googlesource.com/740161 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#511963} [modify] https://crrev.com/613bdd6fbfc49acf332c7867ae495f4502c6f526/build/fuchsia/exe_runner.py [modify] https://crrev.com/613bdd6fbfc49acf332c7867ae495f4502c6f526/build/fuchsia/runner_common.py [modify] https://crrev.com/613bdd6fbfc49acf332c7867ae495f4502c6f526/build/fuchsia/test_runner.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/daf3a31611a0e4d7d4d4df164933bf07862a83c2 commit daf3a31611a0e4d7d4d4df164933bf07862a83c2 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Fri Oct 27 18:26:21 2017 Add media_client as a dependency for fuchsia media cast backend Previously backend didn't have explicit dependency on media_client. It still compiled in non-component builds because //media also pulls libmedia_client. Bug: 772488 Change-Id: I00207b0bea4c90193d531a0ea9b1c08f2c244f14 Reviewed-on: https://chromium-review.googlesource.com/740913 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#512245} [modify] https://crrev.com/daf3a31611a0e4d7d4d4df164933bf07862a83c2/chromecast/media/cma/backend/fuchsia/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c1ec8bddd65ff6ceb15cfd2b11a10911654161d commit 4c1ec8bddd65ff6ceb15cfd2b11a10911654161d Author: Scott Graham <scottmg@chromium.org> Date: Fri Oct 27 21:03:27 2017 fuchsia: Make cast_test_lists buildable As part of getting fuchsia cast audio bot on Chromium waterfall. Bug: 772488 , 778863 Change-Id: I5c669344799c6c0ade03543ac5f9de94c1634c47 TBR: halliwell@chromium.org Reviewed-on: https://chromium-review.googlesource.com/741068 Reviewed-by: Scott Graham <scottmg@chromium.org> Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#512274} [modify] https://crrev.com/4c1ec8bddd65ff6ceb15cfd2b11a10911654161d/chromecast/BUILD.gn [modify] https://crrev.com/4c1ec8bddd65ff6ceb15cfd2b11a10911654161d/storage/browser/fileapi/dragged_file_util_unittest.cc [modify] https://crrev.com/4c1ec8bddd65ff6ceb15cfd2b11a10911654161d/storage/browser/fileapi/local_file_util_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85b5b438b5501d19d876aba8be1fd3f858f4b9cc commit 85b5b438b5501d19d876aba8be1fd3f858f4b9cc Author: Sergey Ulanov <sergeyu@chromium.org> Date: Mon Oct 30 08:02:29 2017 Roll Fuchsia SDK to 04840186b5fc14dc35b12e77f8028330a4bd8333 The new SDK contians bugfixes for media_client library to avoid crashing when playing audio. Bug: 772488 Change-Id: I3c6139a4e75c5a86c363c3773a599e9dba270dd6 Reviewed-on: https://chromium-review.googlesource.com/739764 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#512454} [modify] https://crrev.com/85b5b438b5501d19d876aba8be1fd3f858f4b9cc/DEPS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7cd40415981ef18fcbf87b6647cc4333c5fe76d commit b7cd40415981ef18fcbf87b6647cc4333c5fe76d Author: Sergey Ulanov <sergeyu@chromium.org> Date: Sun Nov 05 08:14:11 2017 Update MediaResourceTracker to initialize VolumeControl Currently public version of cast_shell doesn't initialize VolumeControl, as resilt volume is set to 0 in StreamMixer. This change updates MediaResourceTracker to initialize VolumeControl, which ensures that volume is set to a reasonable value in the mixer. Bug: 772488 Merge-With: eureka-internal/115825 Change-Id: Ia9b8af14998466c9603925cd0ede9978e2df8296 Reviewed-on: https://chromium-review.googlesource.com/741029 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#514064} [modify] https://crrev.com/b7cd40415981ef18fcbf87b6647cc4333c5fe76d/chromecast/media/base/media_resource_tracker.cc [modify] https://crrev.com/b7cd40415981ef18fcbf87b6647cc4333c5fe76d/chromecast/media/cma/backend/volume_control.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cc89df1e519ad71f3913a43278d8fcb57707388 commit 0cc89df1e519ad71f3913a43278d8fcb57707388 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Fri Dec 01 18:18:03 2017 Don't modify global state in CastMediaShlib::Initialize() on Fuchsia. CastMediaShlib::Initialize() was calling logging::SetLogItems() and chromecast::InitCommandLineShlib(). On Fuchsia the media backend is compiled statically with cast_shell, so these calls make little sense. Removed them. Bug: 772488 Change-Id: Ia7ec535e9afc891f00dd32f3a1e179d36707b092 Reviewed-on: https://chromium-review.googlesource.com/801351 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#520987} [modify] https://crrev.com/0cc89df1e519ad71f3913a43278d8fcb57707388/chromecast/media/cma/backend/fuchsia/cast_media_shlib_fuchsia.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cdff69dff93c5367e4d8e12de9e2a888f4237fa commit 6cdff69dff93c5367e4d8e12de9e2a888f4237fa Author: Sergey Ulanov <sergeyu@chromium.org> Date: Fri Dec 01 20:41:51 2017 [chromecast] Add --audio-output-sample-rate for Fuchsia It is possible to set fixed sample rate in cast_shell on Linux with --alsa-fixed-output-sample-rate, but it wasn't possible on Fuchsia. Added --audio-output-sample-rate, which allows to set fixed sample rate on both platforms. For backward compatibility kept the old ALSA-specific flag, but it's marked as deprecated now. Bug: 772488 Change-Id: I0f980f09b432768ff9bb51191a9b1ec31e89274f Reviewed-on: https://chromium-review.googlesource.com/798066 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521050} [modify] https://crrev.com/6cdff69dff93c5367e4d8e12de9e2a888f4237fa/chromecast/base/chromecast_switches.cc [modify] https://crrev.com/6cdff69dff93c5367e4d8e12de9e2a888f4237fa/chromecast/base/chromecast_switches.h [modify] https://crrev.com/6cdff69dff93c5367e4d8e12de9e2a888f4237fa/chromecast/media/cma/backend/alsa/mixer_output_stream_alsa.cc [modify] https://crrev.com/6cdff69dff93c5367e4d8e12de9e2a888f4237fa/chromecast/media/cma/backend/alsa/mixer_output_stream_alsa.h [modify] https://crrev.com/6cdff69dff93c5367e4d8e12de9e2a888f4237fa/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.cc [modify] https://crrev.com/6cdff69dff93c5367e4d8e12de9e2a888f4237fa/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.h [modify] https://crrev.com/6cdff69dff93c5367e4d8e12de9e2a888f4237fa/chromecast/media/cma/backend/mixer_output_stream.h [modify] https://crrev.com/6cdff69dff93c5367e4d8e12de9e2a888f4237fa/chromecast/media/cma/backend/stream_mixer.cc [modify] https://crrev.com/6cdff69dff93c5367e4d8e12de9e2a888f4237fa/chromecast/media/cma/backend/stream_mixer.h
Comment 1 by sergeyu@chromium.org
, Oct 6 2017