AutofillManager is becoming a monolithic class that handles too much. We'd like to refactor the form data importing and credit card saving logic out of it in order to reliably make new advancements for credit card upload.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae27f7f5f1d2f578e9dbe999473eec9856c96e91 commit ae27f7f5f1d2f578e9dbe999473eec9856c96e91 Author: Jared Saul <jsaul@google.com> Date: Fri Oct 27 03:40:46 2017 Refactor form import and credit card upload logic into new classes Bug: 772483 Change-Id: I74c4691fc77a9418be5bf12bea53449b5b049e9e Reviewed-on: https://chromium-review.googlesource.com/705774 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#512081} [modify] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/BUILD.gn [modify] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/DEPS [modify] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/autofill_manager.h [modify] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/autofill_merge_unittest.cc [add] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/credit_card_save_manager.cc [add] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/credit_card_save_manager.h [add] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/credit_card_save_manager_unittest.cc [add] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/form_data_importer.cc [add] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/form_data_importer.h [add] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/form_data_importer_unittest.cc [modify] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/payments/payments_client.cc [modify] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/payments/payments_client.h [modify] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/personal_data_manager.cc [modify] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/personal_data_manager.h [modify] https://crrev.com/ae27f7f5f1d2f578e9dbe999473eec9856c96e91/components/autofill/core/browser/personal_data_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83221ad0f569a1ac8f64e3ebd72c329bb3625ad3 commit 83221ad0f569a1ac8f64e3ebd72c329bb3625ad3 Author: Jared Saul <jsaul@google.com> Date: Tue Oct 31 01:53:14 2017 Refactor duplicate code into single method Bug: 772483 Change-Id: I752b22807c89b44e3d5629239ad9aad582fc6493 Reviewed-on: https://chromium-review.googlesource.com/742127 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#512710} [modify] https://crrev.com/83221ad0f569a1ac8f64e3ebd72c329bb3625ad3/components/autofill/core/browser/credit_card_save_manager.cc [modify] https://crrev.com/83221ad0f569a1ac8f64e3ebd72c329bb3625ad3/components/autofill/core/browser/credit_card_save_manager.h [modify] https://crrev.com/83221ad0f569a1ac8f64e3ebd72c329bb3625ad3/components/autofill/core/browser/form_data_importer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/922ac6a52155a0659cf76a4ff34bb77a7f2173af commit 922ac6a52155a0659cf76a4ff34bb77a7f2173af Author: Jared Saul <jsaul@google.com> Date: Thu Nov 30 19:35:03 2017 Extract DialogEventObserver from PaymentRequest browsertest To be used in SaveCardBubbleViewsBrowsertest Bug: 772483 Change-Id: Ia5ffc7fb180465aec335f8e6a37feb200aebdccf Reviewed-on: https://chromium-review.googlesource.com/792264 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#520639} [add] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/autofill/dialog_event_waiter.h [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/cvc_unmask_view_controller_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/empty_update_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/error_message_view_controller_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/modifiers_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_method_view_controller_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_request_blob_url_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_request_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_request_can_make_payment_metrics_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_request_completion_status_metrics_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_request_debit_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_request_journey_logger_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_request_no_update_with_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_request_payment_app_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_request_payment_response_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_request_shipping_address_instance_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/payment_request_use_stats_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/browser/ui/views/payments/shipping_option_view_controller_browsertest.cc [modify] https://crrev.com/922ac6a52155a0659cf76a4ff34bb77a7f2173af/chrome/test/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e224543a2b8c125fd6d32471d9391d5b938fea4f commit e224543a2b8c125fd6d32471d9391d5b938fea4f Author: Jared Saul <jsaul@google.com> Date: Fri Dec 01 14:39:50 2017 Fix comments missed by DialogEventObserver -> DialogEventWaiter rename Bug: 772483 Change-Id: I7a655761660e3d10f25fb0d39f51b13a48c97662 Reviewed-on: https://chromium-review.googlesource.com/802818 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#520932} [modify] https://crrev.com/e224543a2b8c125fd6d32471d9391d5b938fea4f/chrome/browser/ui/views/payments/payment_request_browsertest_base.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e9ef0349561fd852ca34aadbf498a40d8436891 commit 7e9ef0349561fd852ca34aadbf498a40d8436891 Author: Jared Saul <jsaul@google.com> Date: Tue Dec 19 19:30:50 2017 Introduce SaveCardBubbleViews browsertests Bug: 772483 Change-Id: Ieaeae132ee02698c9a5fa6b12cfe195f2318ed00 Reviewed-on: https://chromium-review.googlesource.com/786641 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#525109} [modify] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/chrome/browser/autofill/risk_util.cc [modify] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/chrome/browser/autofill/risk_util.h [modify] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/chrome/browser/ui/autofill/chrome_autofill_client.h [add] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/chrome/browser/ui/views/autofill/dialog_view_ids.h [modify] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/chrome/browser/ui/views/autofill/save_card_bubble_views.cc [modify] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/chrome/browser/ui/views/autofill/save_card_bubble_views.h [add] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc [add] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc [add] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h [modify] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/chrome/test/BUILD.gn [modify] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/components/autofill/core/browser/autofill_manager.h [modify] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/components/autofill/core/browser/credit_card_save_manager.cc [modify] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/components/autofill/core/browser/credit_card_save_manager.h [modify] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/components/autofill/core/browser/form_data_importer.h [add] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/components/test/data/autofill/credit_card_upload_done.html [add] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/components/test/data/autofill/credit_card_upload_form_address_and_cc.html [add] https://crrev.com/7e9ef0349561fd852ca34aadbf498a40d8436891/components/test/data/autofill/credit_card_upload_form_shipping_address.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02ec0fcb594715c5528474b84c7b5e00a6d78832 commit 02ec0fcb594715c5528474b84c7b5e00a6d78832 Author: Jared Saul <jsaul@google.com> Date: Wed Jan 10 00:07:03 2018 [Autofill] Remove fake geolocation code from SaveCardBubbleViewsBrowserTest Bug: 772483 , 791155 Change-Id: I31e3043f5c2f8d4b861171e0a800494a123e7c19 Reviewed-on: https://chromium-review.googlesource.com/853085 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#528177} [modify] https://crrev.com/02ec0fcb594715c5528474b84c7b5e00a6d78832/chrome/browser/autofill/risk_util.cc [modify] https://crrev.com/02ec0fcb594715c5528474b84c7b5e00a6d78832/chrome/browser/autofill/risk_util.h [modify] https://crrev.com/02ec0fcb594715c5528474b84c7b5e00a6d78832/chrome/browser/ui/autofill/chrome_autofill_client.cc [modify] https://crrev.com/02ec0fcb594715c5528474b84c7b5e00a6d78832/chrome/browser/ui/autofill/chrome_autofill_client.h [modify] https://crrev.com/02ec0fcb594715c5528474b84c7b5e00a6d78832/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc [modify] https://crrev.com/02ec0fcb594715c5528474b84c7b5e00a6d78832/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
Comment 1 by bugdroid1@chromium.org
, Oct 27 2017