New issue
Advanced search Search tips

Issue 772475 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.1%-9% regression in system_health.memory_desktop at 506287:506419

Project Member Reported by fmea...@chromium.org, Oct 6 2017

Issue description

Looks like a revert, lets verify.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=772475

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=005ec6924117dac861fc3392b25f2d9c92405bf79db80ca88489ed73f25f43dc


Bot(s) for this bug's original alert(s):

android-nexus5X
android-one
chromium-rel-win10
Cc: marja@chromium.org
Owner: marja@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author marja@chromium.org ===

Hi marja@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Marja Hölttä
  Commit : fa3b73fffe232b601d2a94f129446f41c765a86e
  Date   : Wed Oct 04 08:23:11 2017
  Subject: [parser] Skipping inner funcs: Turn flag back on.

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/foreground/https_m_facebook_com_rihanna
  Change       : 8.66% | 4438654.66667 -> 4823161.33333

Revision                           Result                  N
chromium@506286                    4438655 +- 191054       6      good
chromium@506329                    4444989 +- 179647       6      good
chromium@506350                    4439451 +- 222725       6      good
chromium@506359                    4451181 +- 163173       6      good
chromium@506365                    4427247 +- 177922       6      good
chromium@506367                    4481691 +- 265000       6      good
chromium@506367,v8@bfb43f8c12      4419007 +- 305010       6      good
chromium@506367,v8@d4da17c6e3      4382572 +- 231477       6      good
chromium@506367,v8@fa3b73fffe      4821007 +- 54049.9      6      bad       <--
chromium@506368                    4855782 +- 212725       6      bad
chromium@506371                    4823161 +- 69579.5      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=https.m.facebook.com.rihanna memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8966459383473871216


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Oct 11 2017

Issue 772471 has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Oct 11 2017

Issue 773025 has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Oct 13 2017

Cc: u...@chromium.org
 Issue 774465  has been merged into this issue.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Oct 14 2017

Issue 774096 has been merged into this issue.
Cc: hablich@chromium.org
+hablich who reviewed the CL: are the regressions expected? 
marja, any progress on this regression? There are a lot of memory regressions on this bug, did you investigate?

Comment 10 by marja@chromium.org, Mar 19 2018

Status: WontFix (was: Assigned)
Afaics nothing more actionable here. The feature is trading memory against speed, and some amount of memory regressions are expected.

However, the V8 off heap memory regressed more than we would've wanted, but I fixed that:

https://chromium-review.googlesource.com/750782 << this is the main fix for off-v8-heap memory regressions


Sign in to add a comment