New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 772473 link

Starred by 2 users
Status: Duplicate
Merged: issue 824115
Owner: ----
Closed: Mar 2018
Cc:
█ hirono@chromium.org
fukino@chromium.org
█ oka@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Gallery is not suggested in OPEN when .png extension is removed

Project Member Reported by oka@chromium.org, Oct 6 2017 
Google Chrome	60.0.3112.114 (Official Build) (64-bit)
Platform	9592.96.0 (Official Build) stable-channel samus

What steps will reproduce the problem?
(1) Download a png file (you can use the attached one).
(2) Remove .png from the extension from Right click -> Rename
(3) Click OPEN focusing the renamed file

What is the expected result?
It should be opened with Gallery.

What happens instead?
It's not. If you have ARC++, there's Photo as a candidate, but not Gallery.
ink.png
4.2 MB View Download

Comment 1 by kinaba@chromium.org, Oct 7 2017

Cc: hirono@chromium.org fukino@chromium.org
I guess that this is because the Gallery app is registered only against the extension:
https://cs.chromium.org/chromium/src/ui/file_manager/gallery/manifest.json?l=37
not to the mime types.

Does adding 
    "types": [
      "image/png",
      "image/jpeg",
      ...
    ],
to the manifest fixes the issue?

Comment 2 by hirono@chromium.org, Oct 10 2017 

I agree with kinba@-san's assessment.

Comment 3 by weifangsun@chromium.org, Oct 10 2017

Labels: M-64

Comment 4 by oka@chromium.org, Oct 17 2017 

I added types.
Gallery was suggested for extension-less png.
But opening it, Gallery didn't show the image.
It says 'No images in this directory'.

Comment 5 by oka@chromium.org, Oct 17 2017

Owner: oka@chromium.org

Comment 6 by weifangsun@chromium.org, Dec 8 2017

Labels: -M-64 M-65

Comment 7 by weifangsun@chromium.org, Jan 30 2018

Labels: -M-65 M-66

Comment 8 by fukino@chromium.org, Feb 2 2018 

Gallery app filters files using only file extensions.
https://codesearch.chromium.org/chromium/src/ui/file_manager/file_manager/common/js/file_type.js?type=cs&q=FileType.isImage&sq=package:chromium&l=384

We should pass mime type from content metadata to FileType.isImage().
At this moment, Gallery app does not have cache mechanism for entry metadata, so introducing it should have some overhead. We should measure the impact.

Comment 10 by weifangsun@chromium.org, Feb 6 2018

Cc: oka@chromium.org
Owner: ----
Status: Available (was: Untriaged)

Comment 11 by sashab@chromium.org, Feb 16 2018

Labels: CrOS-FilesApp-FileIntents
<files-triage>

Comment 12 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-FileIntents CrOSFilesFeature-FileIntents

Comment 13 by weifangsun@chromium.org, Feb 28 2018

Labels: M-69

Comment 14 by weifangsun@chromium.org, Feb 28 2018

Labels: -M-66

Comment 15 by lucmult@chromium.org, Mar 22 2018

Mergedinto: 824115
Status: Duplicate (was: Available)
I'm marking this a dupe of  crbug.com/824115 .

I'm not copying the CC list, if you're still interested on this bug, please CC to  crbug.com/824115 .
►

Sign in to add a comment