The statues are not printed in alphabetic order of the keys on chrome://interventions-internals. |
|||||||
Issue descriptionThe statuses of the enabled/disabled modes of Previews should be listed alphabetically. Right now the order is Offline, Lofi and Amp Redirection.
,
Nov 2 2017
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60ceadfbf73da2c341f0c4cf7e2a5766d4a55895 commit 60ceadfbf73da2c341f0c4cf7e2a5766d4a55895 Author: Thanh Le <thanhdle@chromium.org> Date: Fri Nov 03 17:36:50 2017 Sort previews statuses on "Previews Mode" of chrome://interventions-internals. Bug: 772458 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia7cb1b1d0d0b5139b4cbeac0cd98393fbed96d30 Reviewed-on: https://chromium-review.googlesource.com/752577 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Thanh Le <thanhdle@chromium.org> Cr-Commit-Position: refs/heads/master@{#513825} [modify] https://crrev.com/60ceadfbf73da2c341f0c4cf7e2a5766d4a55895/chrome/browser/resources/interventions_internals/index.js [modify] https://crrev.com/60ceadfbf73da2c341f0c4cf7e2a5766d4a55895/chrome/test/data/webui/interventions_internals_browsertest.js
,
Nov 3 2017
,
Nov 4 2017
,
Nov 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c989fe2c730ae46d7fbc24021b28c589d8927bcc commit c989fe2c730ae46d7fbc24021b28c589d8927bcc Author: Sky Malice <skym@chromium.org> Date: Fri Nov 03 23:54:19 2017 Revert "Sort previews statuses on "Previews Mode" of chrome://interventions-internals." This reverts commit 60ceadfbf73da2c341f0c4cf7e2a5766d4a55895. Reason for revert: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64447/steps/unit_tests Original change's description: > Sort previews statuses on "Previews Mode" of chrome://interventions-internals. > > Bug: 772458 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Ia7cb1b1d0d0b5139b4cbeac0cd98393fbed96d30 > Reviewed-on: https://chromium-review.googlesource.com/752577 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Thanh Le <thanhdle@chromium.org> > Cr-Commit-Position: refs/heads/master@{#513825} TBR=ryansturm@chromium.org,thanhdle@chromium.org Change-Id: I9463619c8abd86736c49f830371da91113741d25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772458 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/753863 Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#513970} [modify] https://crrev.com/c989fe2c730ae46d7fbc24021b28c589d8927bcc/chrome/browser/resources/interventions_internals/index.js [modify] https://crrev.com/c989fe2c730ae46d7fbc24021b28c589d8927bcc/chrome/test/data/webui/interventions_internals_browsertest.js
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f184c0e09513df0cd24d704014e696d5c4fd8ac commit 6f184c0e09513df0cd24d704014e696d5c4fd8ac Author: Thanh Le <thanhdle@chromium.org> Date: Tue Nov 07 01:41:00 2017 Reland "Sort previews statuses on "Previews Mode" of chrome://interventions-internals." This is a reland of 60ceadfbf73da2c341f0c4cf7e2a5766d4a55895 Original change's description: > Sort previews statuses on "Previews Mode" of chrome://interventions-internals. > > Bug: 772458 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Ia7cb1b1d0d0b5139b4cbeac0cd98393fbed96d30 > Reviewed-on: https://chromium-review.googlesource.com/752577 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Thanh Le <thanhdle@chromium.org> > Cr-Commit-Position: refs/heads/master@{#513825} Bug: 772458 Change-Id: I2929573b9887b608fee020a5dc19e25507aa26fb Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/755546 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Thanh Le <thanhdle@chromium.org> Cr-Commit-Position: refs/heads/master@{#514341} [modify] https://crrev.com/6f184c0e09513df0cd24d704014e696d5c4fd8ac/chrome/browser/resources/interventions_internals/index.js [modify] https://crrev.com/6f184c0e09513df0cd24d704014e696d5c4fd8ac/chrome/test/data/webui/interventions_internals_browsertest.js
,
Nov 7 2017
,
Dec 5 2017
,
Dec 5 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by thanhdle@chromium.org
, Oct 6 2017