What steps will reproduce the problem? (1) Enable night light mode (2) Enable accessibility large mouse cursor (3) Disable accessibility large mouse cursor What is the expected result? Night light is still enabled for the mouse cursor. What happens instead? Night light is disabled for the the mouse cursor. Proposed solution: Combine [1] and [2] and move them into cursor_window_controller.cc [1] https://cs.chromium.org/chromium/src/ash/accessibility/accessibility_controller.cc?gsn=RequiresCursorCompositing&l=95 [2] https://cs.chromium.org/chromium/src/ash/system/night_light/night_light_controller.cc?type=cs&sq=package:chromium&l=169
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d07448f4c053023b35ebd2282dd22c485c5b8a57 commit d07448f4c053023b35ebd2282dd22c485c5b8a57 Author: Weidong Guo <weidongg@chromium.org> Date: Wed Oct 18 03:35:18 2017 Make cursor compositing disabled only whe no feature is usng it Changes: Combine AccessibilityController::RequresCursorCompositing() with NightLightController::GetEnabled() and move the function to CursorWindowController. BUG= 772457 Change-Id: I8b662c0a68aff6bdd0d69852f5516b4b9f564d3f Reviewed-on: https://chromium-review.googlesource.com/706058 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#509676} [modify] https://crrev.com/d07448f4c053023b35ebd2282dd22c485c5b8a57/ash/accessibility/accessibility_controller.cc [modify] https://crrev.com/d07448f4c053023b35ebd2282dd22c485c5b8a57/ash/accessibility/accessibility_controller.h [modify] https://crrev.com/d07448f4c053023b35ebd2282dd22c485c5b8a57/ash/display/cursor_window_controller.cc [modify] https://crrev.com/d07448f4c053023b35ebd2282dd22c485c5b8a57/ash/display/cursor_window_controller.h [modify] https://crrev.com/d07448f4c053023b35ebd2282dd22c485c5b8a57/ash/display/cursor_window_controller_unittest.cc [modify] https://crrev.com/d07448f4c053023b35ebd2282dd22c485c5b8a57/ash/shell.cc [modify] https://crrev.com/d07448f4c053023b35ebd2282dd22c485c5b8a57/ash/shell.h [modify] https://crrev.com/d07448f4c053023b35ebd2282dd22c485c5b8a57/ash/system/night_light/night_light_controller.cc [modify] https://crrev.com/d07448f4c053023b35ebd2282dd22c485c5b8a57/chrome/browser/chromeos/accessibility/magnification_manager.cc [modify] https://crrev.com/d07448f4c053023b35ebd2282dd22c485c5b8a57/testing/buildbot/filters/ash_unittests_mash.filter
Comment 1 by weidongg@chromium.org
, Oct 14 2017