New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772444 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 776266

Blocking:
issue 771765



Sign in to add a comment

Master PFQ has not been running since 10/04

Project Member Reported by pho...@chromium.org, Oct 6 2017

Issue description

Cc: steve...@chromium.org jen...@chromium.org
Owner: dgarr...@chromium.org
Status: Started (was: Untriaged)
I need to move it to LUCI anyway.

Does anyone know exactly what Git repositories trigger builds for it?
I'll trigger a build manually for now.
Oh... someone already did.
If I read the current waterfall config correctly, this is the scheduler for that builder:

release_poller = gitiles_poller.GitilesPoller(
    repo_url=config.Master.git_server_url + '/chromium/src',
    branches=[re.compile('refs/tags/*')],
    pollInterval=30,
    svn_branch='releases')

I started a CL, but it looks like LUCI Scheduler doesn't have all of the support needed.

https://chromium-review.googlesource.com/c/chromiumos/chromite/+/706061
Blocking: 771765
I'm just going to kick it off manually a couple times this weekend until we can resolve it on Monday.
Cc: derat@chromium.org afakhry@chromium.org
Labels: OS-Chrome
Cc: kbleicher@chromium.org
Can we manually be uprevving Chrome until this is fixed? We have two M63 dev releases this week and don't wanna ship a week old Chrome...
Follow  issue 773446 .
We can manually trigger builds (which people have been doing), but they have been failing.

I'm working on getting a more robust mechanism for triggering the builds, but that is independent of the builds passing or failing.
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 13 2017

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/6baf2435364e6b8645566605aaa84447d1e214b3

commit 6baf2435364e6b8645566605aaa84447d1e214b3
Author: Don Garrett <dgarrett@google.com>
Date: Fri Oct 13 00:35:07 2017

luci-scheduler: Schedule master-chromium-pfq.

This creates a master builder for the chromium-pfq that is triggered
by the creation of new tags for the repository.

BUG= chromium:772444 
    chromium:751272
TEST=None

Change-Id: I24ff6fef4ee16a4dfa719fb9ec0310903d0de84b
Reviewed-on: https://chromium-review.googlesource.com/706061
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/6baf2435364e6b8645566605aaa84447d1e214b3/luci-scheduler.cfg

Cc: tandrii@chromium.org
This fix has landed, but is causing issues in LUCI Scheduler. 

I found the new trigger was both failing and Paused. I presume tandrii@ paused it and is working on a fix, but I'm not certain.
Correct, we've paused it, but I totally forgot to work on a fix today. Basic problem is that there are many refs, that the poller can't finish first run.
Owner: tandrii@chromium.org
Just pass this back to me and/or unpause when you're ready.
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/experimental/+/a5e0952181dae8c1cb8de7e67be1cf30abed224c

commit a5e0952181dae8c1cb8de7e67be1cf30abed224c
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Mon Oct 16 21:07:20 2017

Test many refs/* triggering.

TBR=vadimsh@chromium.org

Bug:  772444 
Change-Id: I48e36567da3c1edca1ee075c1afa9961ac88ba0c
Reviewed-on: https://chromium-review.googlesource.com/721875
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/a5e0952181dae8c1cb8de7e67be1cf30abed224c/luci-scheduler-dev.cfg

Blockedon: 776266
Owner: dgarr...@chromium.org
Status: Assigned (was: Started)
Sorry for taking long. Underlying bug fixed, and job unpaused:

https://luci-scheduler.appspot.com/jobs/chromiumos-chromite/master-chromium-pfq-trigger

With current once every 15 minutes frequency, it'll take 32 hours to process the 13k backlog of refs (100 refs at a time). So, either wait till Saturday and/or increase frequency of runs.
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/44b994d057d898eef39cd9c315fb1c6a81385633

commit 44b994d057d898eef39cd9c315fb1c6a81385633
Author: Don Garrett <dgarrett@google.com>
Date: Fri Oct 20 01:37:03 2017

luci-scheduler: Speed up master-chromium-pfq-trigger.

Run master-chromium-pfq-trigger once per minute instead of once per 15
minutes.

BUG= chromium:772444 
TEST=None

Change-Id: I3efc91b9aa2bd21729ae8e41344eacf509141260
Reviewed-on: https://chromium-review.googlesource.com/729312
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/44b994d057d898eef39cd9c315fb1c6a81385633/luci-scheduler.cfg

Waiting to verify.

Afterwards, there is some cleanup work to remove the broken scheduler from the chromeos waterfall code.
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c7a937be121fa7ab3ea8163af184f6d9c19b158f

commit c7a937be121fa7ab3ea8163af184f6d9c19b158f
Author: Don Garrett <dgarrett@google.com>
Date: Fri Oct 20 19:17:32 2017

Fix master-chromium-pfq trigger.

Forgot to add "triggers" value to master-chromium-pfq-trigger.

BUG= chromium:772444 
    chromium:751272
TEST=None

Change-Id: Ia1b10876db0ba389558254b7abc49d43decbd89d
Reviewed-on: https://chromium-review.googlesource.com/721616
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/c7a937be121fa7ab3ea8163af184f6d9c19b158f/luci-scheduler.cfg

Status: Fixed (was: Assigned)

Comment 24 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 25 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment