New issue
Advanced search Search tips

Issue 772420 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in right_type()->Is(Type::PlainPrimitive()) in js-typed-lowering.cc

Project Member Reported by ClusterFuzz, Oct 6 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5501392897966080

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  right_type()->Is(Type::PlainPrimitive()) in js-typed-lowering.cc
  v8::internal::compiler::JSBinopReduction::ConvertInputsToNumber
  ReduceSpeculativeNumberBinop
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=47283:47284

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5501392897966080

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Labels: -Security_Impact-Head
(impacts by clusterfuzz for d8 can be wrong)
Project Member

Comment 2 by ClusterFuzz, Oct 6 2017

Components: Blink>JavaScript>Compiler
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, Oct 6 2017

Labels: Test-Predator-AutoOwner
Owner: rmcilroy@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/493a7d6475378cfe48148eaf2c60ea9c5df9d4ea ([TurboFan] Delete AstGraphBuilder.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 7 2017

Labels: Pri-1
Status: Started (was: Assigned)
t
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/3118f473950b4b707d78622053fc4934a2d3f13a

commit 3118f473950b4b707d78622053fc4934a2d3f13a
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Tue Oct 17 16:12:49 2017

[TurboFan] Fix type checks for lowering SpeculativeNumberBinop.

Ensure we only lower SpeculativeNumberBinops to a pure operator for
non-string plain primitives. Previously we could lower if a value might be
the-hole, however this would fail a CHECK in ConvertInputsToNumber which
expects a plain primitive.

BUG= chromium:772420 

Change-Id: I0c755d10db7afd9cabfb638eca5662d70dfc8d51
Reviewed-on: https://chromium-review.googlesource.com/715717
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48649}
[modify] https://crrev.com/3118f473950b4b707d78622053fc4934a2d3f13a/src/compiler/js-typed-lowering.cc
[modify] https://crrev.com/3118f473950b4b707d78622053fc4934a2d3f13a/src/compiler/types.h
[add] https://crrev.com/3118f473950b4b707d78622053fc4934a2d3f13a/test/mjsunit/compiler/regress-772420.js

Status: Fixed (was: Started)
Project Member

Comment 8 by ClusterFuzz, Oct 18 2017

ClusterFuzz has detected this issue as fixed in range 48648:48649.

Detailed report: https://clusterfuzz.com/testcase?key=5501392897966080

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  right_type()->Is(Type::PlainPrimitive()) in js-typed-lowering.cc
  v8::internal::compiler::JSBinopReduction::ConvertInputsToNumber
  ReduceSpeculativeNumberBinop
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=47283:47284
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48648:48649

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5501392897966080

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Oct 18 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5501392897966080 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Oct 18 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner
Project Member

Comment 13 by sheriffbot@chromium.org, Jan 24 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment