A couple of blink modules have only 1 file each and jumbo will not help then. That goes for offscreencanvas and offscreencanvas2d for instance.
Why not merge all canvas modules and save ourselves some overhead?
modules that should be merged imho
canvas
canvas2d
offscreencanvas
offscreencanvas2d
imagebitmap
Also under core, we have imagebitmap and offscreencanvas directories that have very little in them, and their location in the directory tree is questionable. These interface implementations really belong under core/html/canvas IMHO.
bratell: I can do that; we're more familiar with the structures of these folders. How soon do you expect this to be done? Do you have a general guideline of Jumbo project that every refactoring work must follow?
There is no deadline here. It was just something I could do while waiting for compilations.
I noticed the tiny modules when wondering why jumbo only made modules compile 4x faster when it made core compile 14x faster and noticing that it compiled single files instead of *jumbo* files.
It's better if you do it, but I did a merge with git mv, rpl and git cl format which resulted in https://chromium-review.googlesource.com/c/chromium/src/+/728261
If you want to use it, feel free!
bratell@: just wanna confirm with you. Does Jumbo compile on a per-module basis or per-directory basis? Does nesting the existing directories in deeper directory path work for Jumbo?
Comment 1 by junov@chromium.org
, Oct 16 2017Status: Assigned (was: Untriaged)