New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772404 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

tools/metrics/rappor/pretty_print_test.py doesn't pass

Project Member Reported by asvitk...@chromium.org, Oct 6 2017

Issue description

tools/metrics/rappor/pretty_print_test.py doesn't pass at TOT in Chromium.

I think it's been broken for a while. Output:

EEEE
======================================================================
ERROR: testInvalidTypes (__main__.ActionXmlTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./tools/metrics/rappor/pretty_print_test.py", line 116, in testInvalidTypes
    self.assertFalse(pretty_print.GetInvalidTypeErrors(
AttributeError: 'module' object has no attribute 'GetInvalidTypeErrors'

======================================================================
ERROR: testIsPretty (__main__.ActionXmlTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./tools/metrics/rappor/pretty_print_test.py", line 99, in testIsPretty
    result = pretty_print.UpdateXML(PRETTY_XML)
AttributeError: 'module' object has no attribute 'UpdateXML'

======================================================================
ERROR: testMissingOwners (__main__.ActionXmlTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./tools/metrics/rappor/pretty_print_test.py", line 110, in testMissingOwners
    self.assertFalse(pretty_print.GetMissingOwnerErrors([BASIC_METRIC]))
AttributeError: 'module' object has no attribute 'GetMissingOwnerErrors'

======================================================================
ERROR: testParsing (__main__.ActionXmlTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./tools/metrics/rappor/pretty_print_test.py", line 103, in testParsing
    comments, config = pretty_print.RAPPOR_XML_TYPE.Parse(PRETTY_XML)
AttributeError: 'module' object has no attribute 'RAPPOR_XML_TYPE'

----------------------------------------------------------------------
Ran 4 tests in 0.000s

FAILED (errors=4)


We should fix it and when it's fixed, it can be added to the metrics_python_tests test suite I added under https://bugs.chromium.org/p/chromium/issues/detail?id=757504
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3198224d8205daf80a856d42418c936350ae0729

commit 3198224d8205daf80a856d42418c936350ae0729
Author: Steven Holte <holte@google.com>
Date: Tue Aug 14 01:24:43 2018

Update rappor xml tests and add to test target.

Bug:  772404 
Change-Id: I7cb5b15f10aec3db6f28be16d7035bcc7b4d8525
Reviewed-on: https://chromium-review.googlesource.com/1173360
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582783}
[modify] https://crrev.com/3198224d8205daf80a856d42418c936350ae0729/tools/metrics/BUILD.gn
[modify] https://crrev.com/3198224d8205daf80a856d42418c936350ae0729/tools/metrics/rappor/pretty_print_test.py

Status: Fixed (was: Assigned)

Sign in to add a comment