New issue
Advanced search Search tips

Issue 772400 link

Starred by 3 users
Status: Fixed
Owner:
marinaciocea@chromium.org
Closed: Dec 21
Cc:
guidou@chromium.org
hbos@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug


Participants' hotlists:
WebRTC-1.0-Spec-Compliance


Sign in to add a comment

Make remote video tracks report correct values for width and height

Project Member Reported by guidou@chromium.org, Oct 6 2017 
At the moment, RemoteMediaStreamVideoSource does not make this information available, so getSettings() on remote tracks do not report any dimensions or frameRate.

It should be possible to dig into the WebRTC layer and get the information for the video dimensions, or implement a heuristic that makes these values available once the first frame from the remote connection is decoded.

Comment 1 by guidou@chromium.org, Oct 12 2017

Description: Show this description

Comment 2 by marinaciocea@chromium.org, Sep 12

Owner: marinaciocea@chromium.org

Comment 3 by marinaciocea@chromium.org, Oct 19

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0d6d54c3102eb0b0ad815fd9365e9d8b4583eca

commit d0d6d54c3102eb0b0ad815fd9365e9d8b4583eca
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Mon Dec 17 15:57:57 2018

Update track settings on frame delivery.

Update track settings (width, height and aspect ratio) on
frame delivery if either width or height of the frame has changed since
the last update. This CL affects both local and remote tracks.

Bug:  772400 
Change-Id: I8d02370601cffe330bf874c89579431e6bdd01bf
Reviewed-on: https://chromium-review.googlesource.com/c/1373469
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617129}
[modify] https://crrev.com/d0d6d54c3102eb0b0ad815fd9365e9d8b4583eca/content/browser/webrtc/webrtc_browsertest.cc
[modify] https://crrev.com/d0d6d54c3102eb0b0ad815fd9365e9d8b4583eca/content/renderer/BUILD.gn
[add] https://crrev.com/d0d6d54c3102eb0b0ad815fd9365e9d8b4583eca/content/renderer/media/stream/media_stream_types.h
[modify] https://crrev.com/d0d6d54c3102eb0b0ad815fd9365e9d8b4583eca/content/renderer/media/stream/media_stream_video_source.cc
[modify] https://crrev.com/d0d6d54c3102eb0b0ad815fd9365e9d8b4583eca/content/renderer/media/stream/media_stream_video_source.h
[modify] https://crrev.com/d0d6d54c3102eb0b0ad815fd9365e9d8b4583eca/content/renderer/media/stream/media_stream_video_track.cc
[modify] https://crrev.com/d0d6d54c3102eb0b0ad815fd9365e9d8b4583eca/content/renderer/media/stream/media_stream_video_track.h
[modify] https://crrev.com/d0d6d54c3102eb0b0ad815fd9365e9d8b4583eca/content/renderer/media/stream/media_stream_video_track_unittest.cc
[modify] https://crrev.com/d0d6d54c3102eb0b0ad815fd9365e9d8b4583eca/content/renderer/media/stream/video_track_adapter.cc
[modify] https://crrev.com/d0d6d54c3102eb0b0ad815fd9365e9d8b4583eca/content/renderer/media/stream/video_track_adapter.h
[modify] https://crrev.com/d0d6d54c3102eb0b0ad815fd9365e9d8b4583eca/content/test/data/media/peerconnection-call.html
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2389411ce9d264ee55e54003359059540be2d8ad

commit 2389411ce9d264ee55e54003359059540be2d8ad
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Fri Dec 21 10:14:45 2018

Return frame rate on getSettings() for remote video tracks.

Compute frame rate and update remote track settings if frame rate changes
by more than 1% in 1 second interval or if it hasn't been updated in the
last 5 seconds.

Design doc: http://doc/12-fIEwYtwKCCXelevph4YL7PjnT8bTvQ-davipidDFs

Bug:  772400 
Change-Id: I8286fc1236f5f7343dc058e6c67f5de0739f0a50
Reviewed-on: https://chromium-review.googlesource.com/c/1386106
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618493}
[modify] https://crrev.com/2389411ce9d264ee55e54003359059540be2d8ad/content/renderer/media/stream/media_stream_types.h
[modify] https://crrev.com/2389411ce9d264ee55e54003359059540be2d8ad/content/renderer/media/stream/media_stream_video_track.cc
[modify] https://crrev.com/2389411ce9d264ee55e54003359059540be2d8ad/content/renderer/media/stream/media_stream_video_track.h
[modify] https://crrev.com/2389411ce9d264ee55e54003359059540be2d8ad/content/renderer/media/stream/video_track_adapter.cc
[modify] https://crrev.com/2389411ce9d264ee55e54003359059540be2d8ad/content/test/data/media/peerconnection-call.html

Comment 6 by marinaciocea@chromium.org, Dec 21

Status: Fixed (was: Started)
►

Sign in to add a comment