MediaStreamTrack getSettings .width is weird for remote media streams |
||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/61.0.3163.100 Chrome/61.0.3163.100 Safari/537.36 Steps to reproduce the problem: 1. go to https://webrtc.github.io/samples/src/content/peerconnection/pc1/ 2. make a call 3. check remoteVideo.srcObject.getVideoTracks()[0].getSettings() What is the expected behavior? the .width matches remoteVideo.srcObject.videoWidth? Or is not set for a remote mediaStream? What went wrong? .width is 32767 in M63 (canary) and 2147483647 in M61. Did this work before? No Does this work in other browsers? Yes Chrome version: 61.0.3163.100 Channel: stable OS Version: Flash Version: Shockwave Flash 16.0 r0
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb6d00ed8809773f78a0de686ac61db7122b40a9 commit bb6d00ed8809773f78a0de686ac61db7122b40a9 Author: Guido Urdaneta <guidou@chromium.org> Date: Thu Oct 12 11:24:53 2017 Do not set settings for video tracks without format. This affects tracks connected to a MediaStreamRemoteVideoSource, which does not provide a format. Currently, these tracks report 32678 as placeholder width/height because the real dimensions are unknown. It is better to leave these values undefined instead of providing incorrect values. Bug: 772358 Change-Id: Iaa243d8453e7de1cd8206d99c9249dae6bc1aee2 Reviewed-on: https://chromium-review.googlesource.com/704836 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#508312} [modify] https://crrev.com/bb6d00ed8809773f78a0de686ac61db7122b40a9/content/browser/webrtc/webrtc_browsertest.cc [modify] https://crrev.com/bb6d00ed8809773f78a0de686ac61db7122b40a9/content/renderer/media/media_stream_video_source.cc [modify] https://crrev.com/bb6d00ed8809773f78a0de686ac61db7122b40a9/content/test/data/media/peerconnection-call.html
,
Oct 12 2017
this is consistent with firefox btw. Thanks guido!
,
Oct 13 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by guidou@chromium.org
, Oct 6 2017Status: Assigned (was: Unconfirmed)