Regression : Sad face is seen in 'Browser Sample' app on reloading a page.
Reported by
avsha...@etouch.net,
Oct 6 2017
|
|||||||
Issue descriptionChrome version : 63.0.3234.0 (Official Build) 1d130aa149687b0c8df63ae8276f4ef07afca8cd-refs/heads/master@{#506936} 32/64 bit OS : Windows(7,8,10), Linux(14.04 LTS), Mac(10.12.6) Test URL : https://chrome.google.com/webstore/detail/browser-sample/edggnmnajhcbhlnpjnogkjpghaikidaa What steps will reproduce the problem? 1. Launch chrome, navigate to above test URL and install a 'Browser Sample' app. 2. Launch 'Browser Sample' app and click on 'Simulate Crash' button seen on the app toolbar. ("Aw snap!" message is shown). 3. Now click on 'Reload' button and observe. Actual Result : Sad face is seen in 'Browser Sample' app on reloading a page. Expected Result : Page should reload properly on clicking 'Reload' button in 'Browser Sample' app. This is a regression issue broken in ‘M-63’ and using the per-revision bisect providing the bisect results, Good build : 63.0.3223.0 (Revision : 503965) Bad build : 63.0.3225.0 (Revision : 504540) You are probably looking for a change made after 504421 (known good), but no later than 504422 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/1b62135c07abbd0fb531b03fddb3c2114cb06698..3131414035a033d1fb624913474dbdac04158198 Suspect : https://chromium.googlesource.com/chromium/src/+/3131414035a033d1fb624913474dbdac04158198 @lfg : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank you.
,
Oct 10 2017
M-63 will be branched in next few days, and would be good to have all the Beta blockers resolved before branch point. cc'ing nasko@ as well for inputs.
,
Oct 10 2017
M63 is branching on this Thursday (10/12) and M63 beta promotion is coming very soon. Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix ASAP. Thank you.
,
Oct 10 2017
There's a workaround of closing and reopening the app window. While this is not ideal, we shouldn't block beta releases over this bug since it can only manifest itself on crashes/kills. I'll move this to ReleaseBlock-Stable so it doesn't block the beta. I expect to have a fix later this week, so it should be good to merge for next week's beta.
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aed1fed1e341e7a39071560fbecedced31c65030 commit aed1fed1e341e7a39071560fbecedced31c65030 Author: Lucas Furukawa Gadani <lfg@chromium.org> Date: Fri Oct 13 17:34:14 2017 Reattach inner WebContents when recreating its RenderWidgetHostView. Bug: 772354 Change-Id: Ie82bb502cbfbf989d653d45ba7e73164de448d26 Reviewed-on: https://chromium-review.googlesource.com/713949 Reviewed-by: James MacLean <wjmaclean@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#508741} [modify] https://crrev.com/aed1fed1e341e7a39071560fbecedced31c65030/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/aed1fed1e341e7a39071560fbecedced31c65030/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/aed1fed1e341e7a39071560fbecedced31c65030/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/aed1fed1e341e7a39071560fbecedced31c65030/testing/buildbot/filters/mus.browser_tests.filter
,
Oct 13 2017
,
Oct 13 2017
The fix has landed, I think M63 hasn't branched yet, so there's no need to merge. I'll verify on tomorrow's canary.
,
Oct 13 2017
Actually, it looks like the branch happened yesterday at https://crrev.com/8fc7b086a27fcb626bcd8248bfcc321ac4825754 , so I'm requesting a merge.
,
Oct 14 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 16 2017
** Bulk Edit ** Please merge your change to M63 branch 3239 before 5:00 PM PT Monday (10/16) so we can take it in for next dev release. Thank you.
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea41cce309d22e53535f9bf88c053e39ea209a7a commit ea41cce309d22e53535f9bf88c053e39ea209a7a Author: Lucas Furukawa Gadani <lfg@chromium.org> Date: Mon Oct 16 17:02:16 2017 Reattach inner WebContents when recreating its RenderWidgetHostView. Bug: 772354 Change-Id: Ie82bb502cbfbf989d653d45ba7e73164de448d26 Reviewed-on: https://chromium-review.googlesource.com/713949 Reviewed-by: James MacLean <wjmaclean@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#508741} (cherry picked from commit aed1fed1e341e7a39071560fbecedced31c65030) TBR=creis@chromium.org,kenrb@chromium.org,wjmaclean@chromium.org NOTRY=true NOPRESUBMIT=true Change-Id: Ib8f5ed55ed080a98b076c3ef9625fb670b6c21df Reviewed-on: https://chromium-review.googlesource.com/721682 Reviewed-by: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#13} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/ea41cce309d22e53535f9bf88c053e39ea209a7a/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/ea41cce309d22e53535f9bf88c053e39ea209a7a/content/browser/web_contents/web_contents_impl.cc [modify] https://crrev.com/ea41cce309d22e53535f9bf88c053e39ea209a7a/content/browser/web_contents/web_contents_impl.h [modify] https://crrev.com/ea41cce309d22e53535f9bf88c053e39ea209a7a/testing/buildbot/filters/mus.browser_tests.filter |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ranjitkan@chromium.org
, Oct 6 2017