Issue metadata
Sign in to add a comment
|
Clear ownership model between SigninViewController and its delegate |
||||||||||||||||||||||||
Issue descriptionAutomated tests for the below commit have been missing.Please add test coverage ASAP to avoid regressions in future. CL: ---- https://chromium.googlesource.com/chromium/src/+/96c972ea0b7a98c522ae2c4aaee22a9d324fad38 Ref Bug: --------- https://bugs.chromium.org/p/chromium/issues/detail?id=771872 Thank you...!!
,
Oct 16 2017
,
Oct 17 2017
Off to msarda@ since I don't have any throughput for sign in anymore!
,
Oct 18 2017
The life-time of the SigninViewController and SigninViewControllerDelegate is impossible to reason about - the controller of the delegate depend on one another, but somehow no one owns the other one. I think this explains why we end up in strange crashes like the ones in https://bugs.chromium.org/p/chromium/issues/detail?id=772745 or the revert in CL https://chromium-review.googlesource.com/c/chromium/src/+/707199 I think I would need to do a full pass over the ownership of these objects in order to find if we can have an ownership between the controller and its delegate. Lowering the priority of this bug and renaming it.
,
Oct 18 2017
Bug 774175 talks about ownership in this case.
,
Oct 18 2017
,
Oct 18 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by a...@chromium.org
, Oct 6 2017