New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772331 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>,

Project Member Reported by ClusterFuzz, Oct 6 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6129151760400384

Fuzzer: libFuzzer_net_host_resolver_impl_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x60700002b3cf
Crash State:
  base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>,
  base::FuzzedDataProvider::ConsumeUint32InRange
  base::FuzzedDataProvider::ConsumeUint8
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=504079:504126

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6129151760400384

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 6 2017

Labels: OS-Linux
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 6 2017

Labels: M-63
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 6 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 6 2017

Labels: Pri-1
Components: Internals>Network
Owner: fdoray@chromium.org
Status: Assigned (was: Untriaged)
fdoray, could this have been caused by https://chromium.googlesource.com/chromium/src/+/a2d01bae3fbe6fd4c6433ef1163350d25945b298 ?

Comment 6 by fdoray@chromium.org, Oct 12 2017

yes, fixing this in on my TODO list
Project Member

Comment 7 by ClusterFuzz, Oct 17 2017

ClusterFuzz has detected this issue as fixed in range 509032:509158.

Detailed report: https://clusterfuzz.com/testcase?key=6129151760400384

Fuzzer: libFuzzer_net_host_resolver_impl_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Heap-buffer-overflow READ 1
Crash Address: 0x60700002b3cf
Crash State:
  base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>,
  net::FuzzedHostResolverProc::Resolve
  net::HostResolverImpl::ProcTask::DoLookup
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=504079:504126
Fixed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=509032:509158

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6129151760400384

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Oct 17 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6129151760400384 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 17 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
fdoray@ - is there a fix we should be looking to merge to M63?
Cc: mge...@chromium.org
Hi mgersh@ - Might this be related to your "Fix threading in HostResolverImpl fuzzer" change?
Yes, it has the same cause as  issue 769235 , which was fixed by that CL. No need to merge anything, the bug was in the fuzzer itself.
Labels: -Security_Impact-Head -ReleaseBlock-Stable Security_Impact-None
thanks mgersh@!
Project Member

Comment 14 by sheriffbot@chromium.org, Jan 23 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: mmenke@chromium.org

Sign in to add a comment