New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 772301 link

Starred by 2 users
Status: Fixed
Owner:
einbinder@chromium.org
Closed: Oct 2017
Cc:
nyerramilli@chromium.org
caseq@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted hover effect stays on 'Record' icon in Devtools

Reported by nutan.ga...@etouch.net, Oct 6 2017 
Chrome Version: 63.0.3234.0 1d130aa149687b0c8df63ae8276f4ef07afca8cd-refs/heads/master@{#506936}
OS:Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6)

Step to reproduce:
1. Launch chrome, open devtools and navigate to performance section
2. Click on 'Record icon', record for a while and click on 'Stop' button
3. Click on 'Clear' icon and observe on 'Record' icon

Actual: Unwanted hover effect stays on 'Record' icon in Devtools
Expected: Hover effect should not stay. 

This is a Regression issue, broken in 'M-60'
Good Build: 60.0.3097.0
Bad Build: 60.0.3098.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/ac1414588aedb11ae6a11223c7c3cca1057a4773..9f244bd91e540e716aa156a4ee29cfb47558fed4?pretty=fuller&n=100

Suspecting: r471208?

@einbinder: Kindly help to re-assign if your change is not the cause for this issue.

Note: Unable to perform bisect using hasbisect-per-revision hence providing bisect using old script.
Actual Video.mov
4.5 MB Download
Expected Video.mov
5.0 MB Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9e96677e59a4625aa0603441be06edd485f742a

commit b9e96677e59a4625aa0603441be06edd485f742a
Author: Joel Einbinder <einbinder@chromium.org>
Date: Thu Oct 26 01:22:09 2017

DevTools: Use :hover instead of .hover for toolbar buttons

Bug:  772301 
Change-Id: I623cdee6e30dbe3287af7afcc8adb84a59ba16eb
Reviewed-on: https://chromium-review.googlesource.com/738613
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511681}
[modify] https://crrev.com/b9e96677e59a4625aa0603441be06edd485f742a/third_party/WebKit/Source/devtools/front_end/ui/Toolbar.js
[modify] https://crrev.com/b9e96677e59a4625aa0603441be06edd485f742a/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css

Comment 2 by einbinder@chromium.org, Oct 26 2017

Status: Fixed (was: Assigned)

Comment 3 by nutan.ga...@etouch.net, Oct 27 2017

Labels: TE-Verified-64.0.3251.0 TE-Verified-M64
Retested above issue on Windows(7,8,10), Mac(10.12.6) & Linux (14.04 LTS) OS using latest Dev #64.0.3251.0 build and issue seems fixed. Kindly review an attached video.

Thank you!
Fixed Video.mov
4.1 MB Download
►

Sign in to add a comment