New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772300 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

init: the executation time of chromeos-touch-update takes long time.

Project Member Reported by akahuang@chromium.org, Oct 6 2017

Issue description

The upstart job `chromeos-touch-update` checks whether the touch firmware needs update or not before UI starts. Currently, it takes about 220 ms to finish if no touch firmware needs to update. It might be kind of long because it directly affect the timing that UI shows up. We should try to reduce the time in no-op case.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/touch_updater/+/fb25c84cd4526099247350114535604672db7e9a

commit fb25c84cd4526099247350114535604672db7e9a
Author: Chih-Yu Huang <akahuang@google.com>
Date: Fri Oct 13 21:44:45 2017

Convert chromeos-touch-update.conf to a shell script.

Now we use `boot-update-firmware` to centralize the jobs that block UI
at boot. We modified the `chromeos-touch-update` upstart job to a
shell script, and executed it in `boot-update-firmware`.

Also, we should speed up the overall script in the no-op case, because
it blocks the UI at boot. we move all the condition part to background
process, because it takes about half of time iterating all I2C
interface. Now the no-op case timing is reduced from 220ms to 120ms.

BUG= chromium:772300 
TEST=reboot device and check the shell script is executed.
CQ-DEPEND=CL:704456, CL:704420

Change-Id: Ib2c0382a488fb3ec2abd0972e3e2a181f4867470
Reviewed-on: https://chromium-review.googlesource.com/704455
Commit-Ready: Chih-Yu Huang <akahuang@chromium.org>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/fb25c84cd4526099247350114535604672db7e9a/scripts/chromeos-touch-update.sh
[delete] https://crrev.com/80ffdbbded1e80fa5fad677f78b96f61587750d5/scripts/chromeos-touch-update.conf

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4868953b790be4c0ea591e3c234fdaf70718a65b

commit 4868953b790be4c0ea591e3c234fdaf70718a65b
Author: Chih-Yu Huang <akahuang@google.com>
Date: Fri Oct 13 21:44:45 2017

touch_updater: remove to install init conf.

Because we modified `chromeos-touch-update.conf` to a shell script in
CL:704455, we remove to install the conf file.

BUG= chromium:772300 
TEST=emerge-poppy touch_updater and
     check `chromeos-touch-update.conf` is not installed
CQ-DEPEND=CL:704455, CL:704420

Change-Id: I5c55af9b1df40d7fbb252dde87d91fb1e640865a
Reviewed-on: https://chromium-review.googlesource.com/704456
Commit-Ready: Chih-Yu Huang <akahuang@chromium.org>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4868953b790be4c0ea591e3c234fdaf70718a65b/chromeos-base/touch_updater/touch_updater-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/864f7899a9e28d40816f6526a304e794f0448e20

commit 864f7899a9e28d40816f6526a304e794f0448e20
Author: Chih-Yu Huang <akahuang@google.com>
Date: Fri Oct 13 21:44:45 2017

init: Call chromeos-touch-update.sh in boot-update-firmware.

Now we use `boot-update-firmware` to centralize the jobs that block UI
at boot. We modified the `chromeos-touch-update` upstart job to a
shell script, and executed it in `boot-update-firmware`.

BUG= chromium:772300 
TEST=reboot device and see chromeos-touch-update.sh is executed.
CQ-DEPEND=CL:704455, CL:704456

Change-Id: Ica4ff55a01580649da9840c9658e073cdc46ebca
Reviewed-on: https://chromium-review.googlesource.com/704420
Commit-Ready: Chih-Yu Huang <akahuang@chromium.org>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/864f7899a9e28d40816f6526a304e794f0448e20/init/upstart/boot-update-firmware.conf

Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment