appinstalled event does not fire on Desktop |
||||
Issue descriptionChrome Version: 63 OS: Windows, Linux, Chrome OS What steps will reproduce the problem? (1) https://killer-marmot.appspot.com/web/ (2) Menu -> More tools -> Add to Desktop What is the expected result? It prints "Got appinstalled!!!" (in the web page). What happens instead? It does not. Should fire this event once the app completes installation. (If that's hard, we can also do it when we start installation.) This is already implemented on Android and has existing approvals on Intent to Ship (https://groups.google.com/a/chromium.org/d/msg/blink-dev/_kZHUBQHSXo/1PkuGAOiCAAJ); perhaps ping this thread again before landing. Spec: https://www.w3.org/TR/appmanifest/#dfn-appinstalled
,
Oct 31 2017
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2757e2b8b808dbbca7e4a13dc9032f0b61b7684c commit 2757e2b8b808dbbca7e4a13dc9032f0b61b7684c Author: Piotr Swigon <piotrs@chromium.org> Date: Mon Nov 06 05:03:29 2017 [WebApps] Fire appinstalled event on Desktop. Bug: 772282 Change-Id: Iade3f8f27de1cfa508e12b97e5966f1ed2c3e91a Reviewed-on: https://chromium-review.googlesource.com/745702 Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Piotr Swigon <piotrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#514087} [modify] https://crrev.com/2757e2b8b808dbbca7e4a13dc9032f0b61b7684c/chrome/browser/banners/app_banner_manager.h [modify] https://crrev.com/2757e2b8b808dbbca7e4a13dc9032f0b61b7684c/chrome/browser/extensions/bookmark_app_helper.cc
,
Nov 6 2017
This should now be fixed, but the event is only fired is experimental banners are enabled.
,
Nov 15 2017
Thanks Piotr!
,
Oct 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mgiuca@chromium.org
, Oct 6 2017