New issue
Advanced search Search tips

Issue 772260 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 609747



Sign in to add a comment

UrlPatternIndex: Separator character (^) does not match the end of text.

Project Member Reported by karandeepb@chromium.org, Oct 6 2017

Issue description

The separator character "^" should also match the end of text, as per the EasyList conventions. E.g. see https://adblockplus.org/filter-cheatsheet/. 

However, this fails currently. E.g the test case 
{{"page2^", kAnchorNone, kAnchorNone}, "http://example.com/page2", true},
in SubresourceFilterUrlPatternTest.MatchesUrl will fail.

There's also a TODO to this effect in the code - https://cs.chromium.org/chromium/src/components/url_pattern_index/fuzzy_pattern_matching.h?type=cs&sq=package:chromium
 
Blocking: -60974 609747
Status: Available (was: Untriaged)
Will mark this as Available for now.
Owner: karandeepb@chromium.org
Status: Assigned (was: Available)
Blocking: -696822
Cc: -engedy@chromium.org -pkalinnikov@chromium.org
Not blocking crbug.com/696822

Sign in to add a comment