Effective-make-and-model string comparisons should be case-insensitive |
||||
Issue descriptionHP, at least, is inconsistent about capitalization between * metadata it supplies with ppds * What a printer self-reports. We should make the effective-make-and-model comparisons in ppd_provider case insensitive. The plan of record to do this is to modify the metadata_v2 repo on the server side to downcase all effective_make_and_model strings (which also affects the sharding), and just downcase on the client side as well before attempting a lookup.
,
Oct 11 2017
Should this be done before we migrate to metadata_v2?
,
Oct 11 2017
Ha, just commented on the other bug. We could do this in two steps, but it's considerably simpler to just solve this and the other bug at the same time, I think.
,
Nov 2 2017
This should get fixed with the metadata v2 migration
,
Nov 7 2017
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67e8adb8266847cf4f50a9c4b72f5135d1788e8d commit 67e8adb8266847cf4f50a9c4b72f5135d1788e8d Author: Luum Habtemariam <luum@chromium.org> Date: Fri Jan 05 00:01:21 2018 Migrate to metadata v2 and support PPD Restrictions Migrate printer metadata to v2. This also allows for certain restrictions to be placed on the model to determine whether or not the printer should be displayed. This change also reflects the metadata v2 change of lowercasing all effective_make_and_model strings. BUG= chromium:772207 , chromium:773766 Change-Id: I687c90b240df511ddffbf8a349ac2d1503321902 Reviewed-on: https://chromium-review.googlesource.com/831112 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#527156} [modify] https://crrev.com/67e8adb8266847cf4f50a9c4b72f5135d1788e8d/chrome/browser/chromeos/printing/ppd_provider_factory.cc [modify] https://crrev.com/67e8adb8266847cf4f50a9c4b72f5135d1788e8d/chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc [modify] https://crrev.com/67e8adb8266847cf4f50a9c4b72f5135d1788e8d/chromeos/printing/ppd_provider.cc [modify] https://crrev.com/67e8adb8266847cf4f50a9c4b72f5135d1788e8d/chromeos/printing/ppd_provider.h [modify] https://crrev.com/67e8adb8266847cf4f50a9c4b72f5135d1788e8d/chromeos/printing/ppd_provider_unittest.cc
,
Jan 5 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by skau@chromium.org
, Oct 11 2017