Issue metadata
Sign in to add a comment
|
DCheck failed on exit: Callpack passed to EmbeddedSearch::HistorySyncCheck() never run |
||||||||||||||||||||||
Issue descriptionVersion: 63.0.3234.0 (ToT build) I opened a new tab, type "x", hit Enter, then Alt+F4. treib: related to issue 627747 ? Stack(s): [1063:1183:1005/161907.834241:ERROR:service_manager.cc(157)] Connection InterfaceProviderSpec prevented service: content_renderer from binding interface: blink::mojom::ReportingServiceProxy exposed by: content_browser [1063:1063:1005/161920.055919:FATAL:interface_endpoint_client.cc(32)] Check failed: !is_valid. The callback passed to EmbeddedSearch::HistorySyncCheck() was never run. #0 0x7f5992d50907 base::debug::StackTrace::StackTrace() #1 0x7f5992d780d1 logging::LogMessage::~LogMessage() #2 0x7f5991ec78cb mojo::(anonymous namespace)::DCheckIfInvalid() #3 0x55ce830f53d7 _ZN4base8internal9BindStateIMN6chrome5mojom48EmbeddedSearch_HistorySyncCheck_ProxyToResponderEFvbEJNS0_13PassedWrapperINSt3__110unique_ptrIS4_NS8_14default_deleteIS4_EEEEEEEED2Ev #4 0x55ce830f5331 _ZN4base8internal9BindStateIMN6chrome5mojom48EmbeddedSearch_HistorySyncCheck_ProxyToResponderEFvbEJNS0_13PassedWrapperINSt3__110unique_ptrIS4_NS8_14default_deleteIS4_EEEEEEEE7DestroyEPKNS0_13BindStateBaseE #5 0x55ce830f27b3 chrome::mojom::EmbeddedSearchStubDispatch::AcceptWithResponder() #6 0x55ce841d92c7 chrome::mojom::EmbeddedSearchStub<>::AcceptWithResponder() #7 0x7f5991ec4f8e mojo::InterfaceEndpointClient::HandleValidatedMessage() #8 0x7f5991ec48b6 mojo::FilterChain::Accept() #9 0x7f5991ec637c mojo::InterfaceEndpointClient::HandleIncomingMessage() #10 0x7f5991dff2bb IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnProxyThread() #11 0x7f5991dfd111 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12_GLOBAL__N_132ChannelAssociatedGroupControllerEFvN4mojo7MessageEEJ13scoped_refptrIS5_ENS0_13PassedWrapperIS7_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #12 0x7f5992d51157 base::debug::TaskAnnotator::RunTask() #13 0x7f5992d819d0 base::internal::IncomingTaskQueue::RunTask() #14 0x7f5992d83e67 base::MessageLoop::RunTask() #15 0x7f5992d845ca base::MessageLoop::DoWork() #16 0x7f5992d864fa base::(anonymous namespace)::WorkSourceDispatch() #17 0x7f59886efe04 g_main_context_dispatch #18 0x7f59886f0048 <unknown> #19 0x7f59886f00ec g_main_context_iteration #20 0x7f5992d86253 base::MessagePumpGlib::Run() #21 0x7f5992d8390a base::MessageLoop::Run() #22 0x7f5992db6e26 base::RunLoop::Run() #23 0x55ce83261fae ChromeBrowserMainParts::MainMessageLoopRun() #24 0x7f59904a8ac2 content::BrowserMainLoop::RunMainMessageLoopParts() #25 0x7f59904ab93b content::BrowserMainRunnerImpl::Run() #26 0x7f59904a3da8 content::BrowserMain() #27 0x7f5990d6993f content::RunNamedProcessTypeMain() #28 0x7f5990d6a3c7 content::ContentMainRunnerImpl::Run() #29 0x7f5993261fd0 service_manager::Main() #30 0x7f5990d68d12 content::ContentMain() #31 0x55ce82db91cc ChromeMain #32 0x7f5986080f45 __libc_start_main #33 0x55ce82db9029 <unknown> Received signal 6 #0 0x7f5992d50907 base::debug::StackTrace::StackTrace() #1 0x7f5992d503df base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f5992e90330 <unknown> #3 0x7f5986095c37 gsignal #4 0x7f5986099028 abort #5 0x7f5992d4e4f2 base::debug::BreakDebugger() #6 0x7f5992d784a3 logging::LogMessage::~LogMessage() #7 0x7f5991ec78cb mojo::(anonymous namespace)::DCheckIfInvalid() #8 0x55ce830f53d7 _ZN4base8internal9BindStateIMN6chrome5mojom48EmbeddedSearch_HistorySyncCheck_ProxyToResponderEFvbEJNS0_13PassedWrapperINSt3__110unique_ptrIS4_NS8_14default_deleteIS4_EEEEEEEED2Ev #9 0x55ce830f5331 _ZN4base8internal9BindStateIMN6chrome5mojom48EmbeddedSearch_HistorySyncCheck_ProxyToResponderEFvbEJNS0_13PassedWrapperINSt3__110unique_ptrIS4_NS8_14default_deleteIS4_EEEEEEEE7DestroyEPKNS0_13BindStateBaseE #10 0x55ce830f27b3 chrome::mojom::EmbeddedSearchStubDispatch::AcceptWithResponder() #11 0x55ce841d92c7 chrome::mojom::EmbeddedSearchStub<>::AcceptWithResponder() #12 0x7f5991ec4f8e mojo::InterfaceEndpointClient::HandleValidatedMessage() #13 0x7f5991ec48b6 mojo::FilterChain::Accept() #14 0x7f5991ec637c mojo::InterfaceEndpointClient::HandleIncomingMessage() #15 0x7f5991dff2bb IPC::(anonymous namespace)::ChannelAssociatedGroupController::AcceptOnProxyThread() #16 0x7f5991dfd111 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12_GLOBAL__N_132ChannelAssociatedGroupControllerEFvN4mojo7MessageEEJ13scoped_refptrIS5_ENS0_13PassedWrapperIS7_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #17 0x7f5992d51157 base::debug::TaskAnnotator::RunTask() #18 0x7f5992d819d0 base::internal::IncomingTaskQueue::RunTask() #19 0x7f5992d83e67 base::MessageLoop::RunTask() #20 0x7f5992d845ca base::MessageLoop::DoWork() #21 0x7f5992d864fa base::(anonymous namespace)::WorkSourceDispatch() #22 0x7f59886efe04 g_main_context_dispatch #23 0x7f59886f0048 <unknown> #24 0x7f59886f00ec g_main_context_iteration #25 0x7f5992d86253 base::MessagePumpGlib::Run() #26 0x7f5992d8390a base::MessageLoop::Run() #27 0x7f5992db6e26 base::RunLoop::Run() #28 0x55ce83261fae ChromeBrowserMainParts::MainMessageLoopRun() #29 0x7f59904a8ac2 content::BrowserMainLoop::RunMainMessageLoopParts() #30 0x7f59904ab93b content::BrowserMainRunnerImpl::Run() #31 0x7f59904a3da8 content::BrowserMain() #32 0x7f5990d6993f content::RunNamedProcessTypeMain() #33 0x7f5990d6a3c7 content::ContentMainRunnerImpl::Run() #34 0x7f5993261fd0 service_manager::Main() #35 0x7f5990d68d12 content::ContentMain() #36 0x55ce82db91cc ChromeMain #37 0x7f5986080f45 __libc_start_main #38 0x55ce82db9029 <unknown> r8: ffff9b0a8a3fbc10 r9: ffff9b0a8a3fbc00 r10: 0000000000000008 r11: 0000000000000206 r12: 00007ffca4426860 r13: 00000000000000a7 r14: 00007ffca4426858 r15: 00007ffca4426850 di: 0000000000000427 si: 0000000000000427 bp: 00007ffca4426410 bx: 00007ffca4426410 dx: 0000000000000006 ax: 0000000000000000 cx: 00007f5986095c37 sp: 00007ffca4426268 ip: 00007f5986095c37 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. [1:1:0100/000000.174322:ERROR:broker_posix.cc(43)] Invalid node channel message e
,
Oct 6 2017
,
Oct 6 2017
,
Oct 9 2017
Issue 772421 has been merged into this issue.
,
Oct 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16c803a1c68bf3a1c46d7d524350feac4a743c91 commit 16c803a1c68bf3a1c46d7d524350feac4a743c91 Author: Marc Treib <treib@chromium.org> Date: Mon Oct 09 08:41:19 2017 Instant IPC: Always run Mojo return value callbacks If we don't, Mojo gets unhappy and DCHECKs. Followup to crrev.com/c/695227, which introduced the Mojo return values. Bug: 772191 Change-Id: I55daeff424217cfe622c5364ae960bea723f94f4 Reviewed-on: https://chromium-review.googlesource.com/704734 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#507339} [modify] https://crrev.com/16c803a1c68bf3a1c46d7d524350feac4a743c91/chrome/browser/ui/search/search_ipc_router.cc [modify] https://crrev.com/16c803a1c68bf3a1c46d7d524350feac4a743c91/chrome/browser/ui/search/search_ipc_router_unittest.cc
,
Oct 9 2017
,
Oct 9 2017
Thatnks for the fix! FWIW, media/base/ has ScopedCallbackRunner which does this automatically... but it's in media/base/ :-/ Maybe we should consider moving it out?
,
Oct 9 2017
Since that sounded vaguely familiar, I searched and found a recent discussion about this: https://groups.google.com/a/chromium.org/d/topic/chromium-dev/ZfL_XhGZ7tA/discussion Seems there is general agreement about moving it to base/, but looks like nobody got around to actually doing it.
,
Oct 9 2017
I had the same issue in Issue 772511
,
Oct 9 2017
Issue 772511 has been merged into this issue.
,
Oct 24 2017
,
Dec 12 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by treib@chromium.org
, Oct 6 2017