The version numbers in software_rendering_list.json and gpu_driver_bug_list.json are painful to maintain. Instead, we can generate links to the correct version of these files via, for example: https://chromium.googlesource.com/chromium/src/+/d6cc8b72e6cc0d79db438da47fda28971880eb87/gpu/config/gpu_driver_bug_list.json https://chromium.googlesource.com/chromium/src/+/d6cc8b72e6cc0d79db438da47fda28971880eb87/gpu/config/software_rendering_list.json about:version already has the chromium commit hash. Still digging through the source code to figure out where it's available.
It's generated into out/[Flavor]/gen/components/version_info/version_info_values.h : https://cs.chromium.org/chromium/src/out/Debug/gen/components/version_info/version_info_values.h?type=cs&sq=package:chromium&l=9 Produced by components/version_info/BUILD.gn : https://cs.chromium.org/chromium/src/components/version_info/BUILD.gn?type=cs&q=version_info_values.h&l=55
I think to generate URLs we're going to want just the hash, excluding the "-heads/3163@{#1250}". But for all non-dev builds, the version should work just as well, e.g.: https://chromium.googlesource.com/chromium/src/+/61.0.3163.100/gpu/config/gpu_driver_bug_list.json
Agreed. Kai, would you be willing to pick this up?
https://chromium-review.googlesource.com/c/chromium/src/+/728950
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96bd9ef90d95efa332485195e03c63477b90bb07 commit 96bd9ef90d95efa332485195e03c63477b90bb07 Author: Kai Ninomiya <kainino@chromium.org> Date: Fri Oct 20 21:30:37 2017 Replace GPU list versions with Chromium git hashes This removes the manually-updated software_rendering_list and gpu_driver_bug_list versions, replacing them with Chromium git commit hashes. These hashes are used to generate permalinks, like this one: http://chromium.googlesource.com/chromium/src/+/57c9d07b416b5a2ea23d28247300e4af36329bdc/gpu/config/software_rendering_list.json Bug: 772177 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id23a5e05506492999a43cd173e4659095f75fe4c Reviewed-on: https://chromium-review.googlesource.com/728950 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#510568} [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/DEPS [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/build/check_gn_headers_whitelist.txt [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/build/util/lastchange.py [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/content/browser/gpu/gpu_data_manager_impl.cc [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/content/browser/gpu/gpu_data_manager_impl.h [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/content/browser/gpu/gpu_data_manager_impl_private.cc [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/content/browser/gpu/gpu_data_manager_impl_private.h [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/content/browser/gpu/gpu_data_manager_impl_private_unittest.cc [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/content/browser/gpu/gpu_data_manager_testing_autogen.cc [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/content/browser/gpu/gpu_data_manager_testing_autogen.h [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/content/browser/gpu/gpu_internals_ui.cc [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/content/browser/resources/gpu/browser_bridge_tests.js [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/content/browser/resources/gpu/info_view.js [add] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/gpu/config/.gitignore [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/gpu/config/gpu_blacklist.cc [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/gpu/config/gpu_blacklist_unittest.cc [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/gpu/config/gpu_control_list.cc [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/gpu/config/gpu_control_list.h [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/gpu/config/gpu_control_list_testing_autogen.cc [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/gpu/config/gpu_control_list_testing_autogen.h [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/gpu/config/gpu_control_list_unittest.cc [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/gpu/config/gpu_driver_bug_list.cc [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/gpu/config/gpu_driver_bug_list.json [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/gpu/config/process_json.py [modify] https://crrev.com/96bd9ef90d95efa332485195e03c63477b90bb07/gpu/config/software_rendering_list.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2a713e4264a275054b53b35397585355474d455 commit d2a713e4264a275054b53b35397585355474d455 Author: Kai Ninomiya <kainino@chromium.org> Date: Mon Oct 23 22:09:13 2017 Fix typo introduced in http://crrev.com/c/728950 TBR=dpranke@chromium.org Bug: 772177 Change-Id: I4330cc9799c134f6741e197b67fbc29600a12dff Reviewed-on: https://chromium-review.googlesource.com/734305 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#510936} [modify] https://crrev.com/d2a713e4264a275054b53b35397585355474d455/build/util/lastchange.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/3eab95a2d59d2ed3d983079c2fb1a0e449b858f3 commit 3eab95a2d59d2ed3d983079c2fb1a0e449b858f3 Author: Olivier Tilloy <olivier.tilloy@canonical.com> Date: Fri Nov 03 18:42:10 2017 Make the export_tarball script generate gpu_lists_version.h Since https://chromium-review.googlesource.com/c/chromium/src/+/728950, gpu_lists_version.h is generated by lastchange.py, but the script that generates source tarballs hadn't been updated accordingly. Bug: 772177 Change-Id: If62b273567c83bef18e140904613b3971ecbadb2 Reviewed-on: https://chromium-review.googlesource.com/744009 Reviewed-by: Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/3eab95a2d59d2ed3d983079c2fb1a0e449b858f3/scripts/slave/recipe_modules/chromium/resources/export_tarball.py
Olivier, thanks for taking care of that. I had a patch open https://crrev.com/c/729263 but forgot to push to get it reviewed, apologies for leaving the issue there.
Comment 1 by kbr@chromium.org
, Oct 5 2017