Previews Blacklist crashes in debug mode when the URL doesn't have a host |
||||
Issue descriptionOriginally from CL https://chromium-review.googlesource.com/c/chromium/src/+/703715, by rlanday@chromium.org. Chrome Version: 63.0.3233.0 OS: Android (but probably reproducible on Desktop too with other file URIs) What steps will reproduce the problem? (1) Run a debug build of Chrome, with a preview type enabled, e.g. Client LoFi (2) Navigate to "file:///sdcard" (3) Chrome crashes What is the expected result? The page loads normally without crashing What happens instead? Chrome crashes. Note that Release builds don't crash - the DCHECK is just skipped and everything seems to work fine.
,
Oct 5 2017
Thanks for finding this. I'm surprised we haven't seen this by now, but I plan to block all non-host previews from the blacklist perspective, as it's very likely we don't want to provide a preview for these.
,
Oct 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1007d4202e961bbf529e2e4f87a885041c664ca commit b1007d4202e961bbf529e2e4f87a885041c664ca Author: Ryan Sturm <ryansturm@chromium.org> Date: Fri Oct 06 02:39:21 2017 Prevent previews when the url has no host In this case, we don't want to serve a preview. Bug: 772175 Change-Id: I320d6ad26cb7cf51dba9797447e388816115df91 Reviewed-on: https://chromium-review.googlesource.com/703859 Reviewed-by: Scott Little <sclittle@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#506955} [modify] https://crrev.com/b1007d4202e961bbf529e2e4f87a885041c664ca/components/previews/core/previews_io_data.cc [modify] https://crrev.com/b1007d4202e961bbf529e2e4f87a885041c664ca/components/previews/core/previews_io_data_unittest.cc
,
Oct 6 2017
,
Dec 5 2017
,
Dec 5 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sclit...@chromium.org
, Oct 5 2017