New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 772160 link

Starred by 6 users
Status: Fixed
Owner:
xhw...@chromium.org
Closed: Apr 2018
Cc:
bbudge@chromium.org
█ raymes@chromium.org
jrumm...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue 403462
issue 764143
Blocking:
issue 799169
issue 349201
issue 739797
issue 770958



Sign in to add a comment

Remove pepper CDM support

Project Member Reported by xhw...@chromium.org, Oct 5 2017 
Track all work to remove pepper CDM support after we fully switch to use mojo CDM.

Here's a partial list:
- WebHelperPlugin, PepperCdmWrapperImpl
- PpapiDecryptor, ContentDecryptorDelegate
- All PPB_contentDecryptor and PPP_contentDecryptor pepper APIs
- All other CDM specific pepper APIs (e.g. Platform Verification, Output Protection, Plugin Private File System). Note that the backend will be hooked up with related mojo services and are still needed.
- PpapiCdmAdapter
- Update WidevineCdmComponentInstaller to remove adapter related logic
- Update CdmHostFiles to remove adapter related logic
- Update installer and build bundle code to remove CDM adapter
- Remove IsInternalPluginAvailableForMimeType and additional_param_* in plugin info.
- Remove CDM specific logic in ppapi_thread.*
- Refactor media/cdm/ppapi folder
- Remove all ppapi/ dependency in media/

Comment 1 by xhw...@chromium.org, Nov 16 2017

Labels: -M-65 M-66

Comment 2 by xhw...@chromium.org, Nov 16 2017

Blocking: 770958

Comment 3 by xhw...@chromium.org, Nov 16 2017

Blocking: 349201

Comment 4 by xhw...@chromium.org, Nov 16 2017

Blockedon: 764143

Comment 5 by xhw...@chromium.org, Nov 16 2017

Description: Show this description

Comment 6 by xhw...@chromium.org, Jan 4 2018

Blocking: 799169

Comment 7 by xhw...@chromium.org, Jan 25 2018

Labels: -M-66 M-67

Comment 8 by xhw...@chromium.org, Feb 20 2018

Blocking: 739797

Comment 9 by xhw...@chromium.org, Feb 22 2018

Blockedon: 403462

Comment 10 by xhw...@chromium.org, Feb 22 2018

Blocking: -403462

Comment 11 by xhw...@chromium.org, Mar 2 2018

Cc: bbudge@chromium.org raymes@chromium.org
bbudge/raymes (as ppapi/ OWNERS): We do not need content_decrypt*.{h,cc,idl} [1] now. Shall we just remove all of them or keep them as is until PPAPI is deprecated? Note that these APIs are private so I feel it's okay to remove them.

[1] https://cs.chromium.org/search/?q=content_decrypt+file:%5Esrc/ppapi/+package:%5Echromium$&p=1&type=cs

Comment 12 by xhw...@chromium.org, Mar 2 2018

Status: Started (was: Assigned)

Comment 13 by raymes@chromium.org, Mar 4 2018 

We would just need to check that they aren't used by Flash. You could reach out to laforge or ihf to find out.
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e9c641be334a8f5e709ed89cf4d056bff25cef9

commit 2e9c641be334a8f5e709ed89cf4d056bff25cef9
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Tue Mar 06 22:53:51 2018

media: Remove kMojoCdm feature

Now Mojo CDM is enabled by default on desktop platforms (when library
CDM is enabled), remove kMojoCdm feature.

Will start to remove pepper CDM support in later CLs.

Bug:  772160 
Change-Id: Id5b0692db992500d97cd5902f1ddd97147ab97d9
Reviewed-on: https://chromium-review.googlesource.com/946430
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541224}
[modify] https://crrev.com/2e9c641be334a8f5e709ed89cf4d056bff25cef9/chrome/browser/media/encrypted_media_browsertest.cc
[modify] https://crrev.com/2e9c641be334a8f5e709ed89cf4d056bff25cef9/content/renderer/media/media_factory.cc
[modify] https://crrev.com/2e9c641be334a8f5e709ed89cf4d056bff25cef9/media/base/key_systems.cc
[modify] https://crrev.com/2e9c641be334a8f5e709ed89cf4d056bff25cef9/media/base/media_switches.cc
[modify] https://crrev.com/2e9c641be334a8f5e709ed89cf4d056bff25cef9/media/base/media_switches.h
[modify] https://crrev.com/2e9c641be334a8f5e709ed89cf4d056bff25cef9/media/mojo/README.md
[modify] https://crrev.com/2e9c641be334a8f5e709ed89cf4d056bff25cef9/testing/buildbot/filters/mash.browser_tests.filter
[modify] https://crrev.com/2e9c641be334a8f5e709ed89cf4d056bff25cef9/testing/variations/fieldtrial_testing_config.json
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b21649d8d9172e0e4c40d8b862f64735fa7588f4

commit b21649d8d9172e0e4c40d8b862f64735fa7588f4
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Wed Mar 07 04:45:58 2018

media: Remove PpapiDecryptor and friends

Removes content/renderer classes supporting pepper CDM. It stops at the
blink/chromium boundary and content/ppapi boundary. Blink and ppapi/
classes will be removed/cleaned in later CLs.

Bug:  772160 
Change-Id: I12c30fdbda55a9db36cc3d6115eac5a30f0eb743
Reviewed-on: https://chromium-review.googlesource.com/947887
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541341}
[modify] https://crrev.com/b21649d8d9172e0e4c40d8b862f64735fa7588f4/content/renderer/BUILD.gn
[delete] https://crrev.com/ebec8905106872889a8d3c8cae8ec1122830ab40/content/renderer/media/cdm/pepper_cdm_wrapper.h
[delete] https://crrev.com/ebec8905106872889a8d3c8cae8ec1122830ab40/content/renderer/media/cdm/pepper_cdm_wrapper_impl.cc
[delete] https://crrev.com/ebec8905106872889a8d3c8cae8ec1122830ab40/content/renderer/media/cdm/pepper_cdm_wrapper_impl.h
[delete] https://crrev.com/ebec8905106872889a8d3c8cae8ec1122830ab40/content/renderer/media/cdm/ppapi_decryptor.cc
[delete] https://crrev.com/ebec8905106872889a8d3c8cae8ec1122830ab40/content/renderer/media/cdm/ppapi_decryptor.h
[delete] https://crrev.com/ebec8905106872889a8d3c8cae8ec1122830ab40/content/renderer/media/cdm/render_cdm_factory.cc
[delete] https://crrev.com/ebec8905106872889a8d3c8cae8ec1122830ab40/content/renderer/media/cdm/render_cdm_factory.h
[delete] https://crrev.com/ebec8905106872889a8d3c8cae8ec1122830ab40/content/renderer/pepper/content_decryptor_delegate.cc
[delete] https://crrev.com/ebec8905106872889a8d3c8cae8ec1122830ab40/content/renderer/pepper/content_decryptor_delegate.h
[modify] https://crrev.com/b21649d8d9172e0e4c40d8b862f64735fa7588f4/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/b21649d8d9172e0e4c40d8b862f64735fa7588f4/content/renderer/pepper/pepper_plugin_instance_impl.h
Project Member

Comment 16 by bugdroid1@chromium.org, Mar 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb566a2bc3012a3d65e63b75b822e58522fbe2bc

commit eb566a2bc3012a3d65e63b75b822e58522fbe2bc
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Wed Mar 07 17:34:06 2018

blink: Remove WebHelperPlugin and friends

This is only used to support pepper CDM, which is being deprecated now.
Hence remove all related code.

Bug:  772160 
Change-Id: Idfd2f97dd09a8be3f9aa90c998ffc18c60987057
Reviewed-on: https://chromium-review.googlesource.com/947922
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541485}
[modify] https://crrev.com/eb566a2bc3012a3d65e63b75b822e58522fbe2bc/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/eb566a2bc3012a3d65e63b75b822e58522fbe2bc/third_party/WebKit/Source/core/exported/BUILD.gn
[delete] https://crrev.com/1347fd7cbed7d0a55d38779421837eafc765f712/third_party/WebKit/Source/core/exported/WebHelperPluginImpl.cpp
[delete] https://crrev.com/1347fd7cbed7d0a55d38779421837eafc765f712/third_party/WebKit/Source/core/exported/WebHelperPluginImpl.h
[delete] https://crrev.com/1347fd7cbed7d0a55d38779421837eafc765f712/third_party/WebKit/Source/core/exported/WebHelperPluginTest.cpp
[modify] https://crrev.com/eb566a2bc3012a3d65e63b75b822e58522fbe2bc/third_party/WebKit/public/BUILD.gn
[delete] https://crrev.com/1347fd7cbed7d0a55d38779421837eafc765f712/third_party/WebKit/public/web/WebHelperPlugin.h
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f04536cae9016aabeb9e45eff1364b0e90e90838

commit f04536cae9016aabeb9e45eff1364b0e90e90838
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Wed Mar 07 20:38:48 2018

media: Remove PepperType from KeySystems

We are not using PPAPI to host CDMs anymore. Hence no need to specify
PepperType for KeySystems.

Bug:  772160 
Change-Id: Ie9d2f34ef49e93b0039e9e3718ee95392289281a
Reviewed-on: https://chromium-review.googlesource.com/947808
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541562}
[modify] https://crrev.com/f04536cae9016aabeb9e45eff1364b0e90e90838/chrome/renderer/media/chrome_key_systems.cc
[modify] https://crrev.com/f04536cae9016aabeb9e45eff1364b0e90e90838/components/cdm/renderer/external_clear_key_key_system_properties.cc
[modify] https://crrev.com/f04536cae9016aabeb9e45eff1364b0e90e90838/components/cdm/renderer/external_clear_key_key_system_properties.h
[modify] https://crrev.com/f04536cae9016aabeb9e45eff1364b0e90e90838/components/cdm/renderer/widevine_key_system_properties.cc
[modify] https://crrev.com/f04536cae9016aabeb9e45eff1364b0e90e90838/components/cdm/renderer/widevine_key_system_properties.h
[modify] https://crrev.com/f04536cae9016aabeb9e45eff1364b0e90e90838/media/base/key_system_properties.cc
[modify] https://crrev.com/f04536cae9016aabeb9e45eff1364b0e90e90838/media/base/key_system_properties.h
[modify] https://crrev.com/f04536cae9016aabeb9e45eff1364b0e90e90838/media/base/key_systems.cc
[modify] https://crrev.com/f04536cae9016aabeb9e45eff1364b0e90e90838/media/base/key_systems.h
[modify] https://crrev.com/f04536cae9016aabeb9e45eff1364b0e90e90838/media/base/key_systems_unittest.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cc3336bcc46efe134aa23d6e51416d232bde471

commit 6cc3336bcc46efe134aa23d6e51416d232bde471
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Wed Mar 07 21:07:17 2018

media: Clean up CdmHostFiles

Pepper CDM support is deprecated, so is ppapi CDM adapter binary. This
CL removes all CDM adapter related code from CdmHostFiles.

Also removes all CDM related code from PpapiThread, including CDM host
verification code that uses CdmHostFiles.

Bug:  772160 
Change-Id: I727063d60eeccc60330c10c2fa9339bdc72813a3
Reviewed-on: https://chromium-review.googlesource.com/947923
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541579}
[modify] https://crrev.com/6cc3336bcc46efe134aa23d6e51416d232bde471/content/ppapi_plugin/ppapi_thread.cc
[modify] https://crrev.com/6cc3336bcc46efe134aa23d6e51416d232bde471/media/cdm/cdm_host_files.cc
[modify] https://crrev.com/6cc3336bcc46efe134aa23d6e51416d232bde471/media/cdm/cdm_host_files.h
Project Member

Comment 19 by bugdroid1@chromium.org, Mar 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de910d0e7867371be1ad05b67286d7a90b4f646a

commit de910d0e7867371be1ad05b67286d7a90b4f646a
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Tue Mar 13 03:08:22 2018

media: Stop registering CDM adapter as a pepper plugin

Pepper CDM support is being deprecated. This CL removes all CDM
adapter (pepper plugin) registration/checking code.

Bug:  772160 
Change-Id: I5b6c538a0b96360c7c32a2d35d1dab41f0ed34c1
Reviewed-on: https://chromium-review.googlesource.com/956255
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542707}
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/chrome/browser/component_updater/widevine_cdm_component_installer.cc
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/chrome/browser/content_settings/content_settings_browsertest.cc
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/chrome/browser/load_library_perf_test.cc
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/chrome/browser/media/library_cdm_test_helper.cc
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/chrome/browser/media/library_cdm_test_helper.h
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/chrome/common/BUILD.gn
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/chrome/common/chrome_paths.cc
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/chrome/common/chrome_paths.h
[delete] https://crrev.com/5e7bb268134a9184db85439bebd08c3258772e0d/chrome/common/widevine_cdm_constants.cc
[delete] https://crrev.com/5e7bb268134a9184db85439bebd08c3258772e0d/chrome/common/widevine_cdm_constants.h
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/chrome/renderer/pepper/pepper_uma_host.cc
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/chrome/renderer/plugins/plugin_uma.cc
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/chrome/renderer/plugins/plugin_uma.h
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/chrome/renderer/plugins/plugin_uma_unittest.cc
[delete] https://crrev.com/5e7bb268134a9184db85439bebd08c3258772e0d/chrome/test/data/load_widevine_no_js.html
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/content/browser/media/key_system_support_impl.cc
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/third_party/widevine/cdm/widevine_cdm_common.h
[modify] https://crrev.com/de910d0e7867371be1ad05b67286d7a90b4f646a/tools/metrics/histograms/histograms.xml
Project Member

Comment 20 by bugdroid1@chromium.org, Mar 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30a8b634693296f232407d1adb64175b2cbf1cb2

commit 30a8b634693296f232407d1adb64175b2cbf1cb2
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Tue Mar 13 09:15:02 2018

media: Remove clearkeycdmadapter target

Pepper CDM is being deprecated. This should not be needed anywhere now.

Bug:  772160 
Change-Id: I1809ff64c4f02166218d6378a37f8698044f9ad2
Reviewed-on: https://chromium-review.googlesource.com/956415
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542746}
[modify] https://crrev.com/30a8b634693296f232407d1adb64175b2cbf1cb2/chrome/test/BUILD.gn
[modify] https://crrev.com/30a8b634693296f232407d1adb64175b2cbf1cb2/chrome/tools/build/chromeos/FILES.cfg
[modify] https://crrev.com/30a8b634693296f232407d1adb64175b2cbf1cb2/chrome/tools/build/linux/FILES.cfg
[modify] https://crrev.com/30a8b634693296f232407d1adb64175b2cbf1cb2/media/cdm/cdm_paths.cc
[modify] https://crrev.com/30a8b634693296f232407d1adb64175b2cbf1cb2/media/cdm/cdm_paths.h
[delete] https://crrev.com/ca5d8f4e56c192d11e6293ad9144b8defd463674/media/cdm/library_cdm/BUILD.gn
[delete] https://crrev.com/ca5d8f4e56c192d11e6293ad9144b8defd463674/media/cdm/library_cdm/clear_key_cdm/BRANDING
[delete] https://crrev.com/ca5d8f4e56c192d11e6293ad9144b8defd463674/media/cdm/library_cdm/clearkeycdmadapter.ver
[modify] https://crrev.com/30a8b634693296f232407d1adb64175b2cbf1cb2/tools/bisect_repackage/bisect_repackage.py

Comment 21 by wittman@chromium.org, Mar 15 2018 

FYI: commit de910d0e7867371be1ad05b67286d7a90b4f646a (Stop registering CDM adapter as a pepper plugin) has reduced startup execution time by an average of 71ms (1.1%) in Windows 64-bit canary 67.0.3369.0. Kudos!

Execution profile difference: https://uma.googleplex.com/p/chrome/callstacks?sid=8b10e2b34fcaedff193ca40099708f81 (component_updater::RegisterWidevineCdmComponent function)

Comment 22 by xhw...@chromium.org, Mar 15 2018 

Wow, thanks for noting that! The improvement probably comes from the fact that we do not need to copy the CDM adapter (and write the VERSION file) when Chrome is updated. So it affects Canary the most given the more frequent update rate. But still, simpler and faster is always better :)
Project Member

Comment 23 by bugdroid1@chromium.org, Mar 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5b69c8251c1710472d4850cf389b18a868bc6cc

commit d5b69c8251c1710472d4850cf389b18a868bc6cc
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Tue Mar 20 22:18:35 2018

media: Remove widevinecdmadapter target

Pepper CDM is being deprecated so widevinecdmadapter should not be
needed anywhere now. Targets that need Widevine CDM should depend
on "widevinecdm" target directly.

Details of change:
- Remove widevinecdmadapter from third_party/widevine/cdm/BUILD.gn
- Remove files required to build widevinecdmadapter
- Remove stub CDM since it's only needed to build the CDM adapter
- Update installer code to remove widevinecdmadapter

Bug:  772160 
Change-Id: I5c17d3d34a98839ecb48438cd09aaa8a565dd5dd
Reviewed-on: https://chromium-review.googlesource.com/957868
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Prasad Vuppalapu <prasadv@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544557}
[modify] https://crrev.com/d5b69c8251c1710472d4850cf389b18a868bc6cc/chrome/BUILD.gn
[modify] https://crrev.com/d5b69c8251c1710472d4850cf389b18a868bc6cc/chrome/installer/linux/BUILD.gn
[modify] https://crrev.com/d5b69c8251c1710472d4850cf389b18a868bc6cc/chrome/installer/linux/common/installer.include
[modify] https://crrev.com/d5b69c8251c1710472d4850cf389b18a868bc6cc/chrome/installer/mac/sign_versioned_dir.sh.in
[modify] https://crrev.com/d5b69c8251c1710472d4850cf389b18a868bc6cc/chrome/installer/mini_installer/chrome.release
[modify] https://crrev.com/d5b69c8251c1710472d4850cf389b18a868bc6cc/chrome/test/BUILD.gn
[modify] https://crrev.com/d5b69c8251c1710472d4850cf389b18a868bc6cc/chrome/tools/build/chromeos/FILES.cfg
[modify] https://crrev.com/d5b69c8251c1710472d4850cf389b18a868bc6cc/chrome/tools/build/linux/FILES.cfg
[modify] https://crrev.com/d5b69c8251c1710472d4850cf389b18a868bc6cc/chrome/tools/build/win/FILES.cfg
[delete] https://crrev.com/9be1f4858403e36a2f2001b1caf6ad14a6fa38c2/media/cdm/stub/stub_cdm.cc
[delete] https://crrev.com/9be1f4858403e36a2f2001b1caf6ad14a6fa38c2/media/cdm/stub/stub_cdm.h
[delete] https://crrev.com/9be1f4858403e36a2f2001b1caf6ad14a6fa38c2/third_party/widevine/cdm/BRANDING
[modify] https://crrev.com/d5b69c8251c1710472d4850cf389b18a868bc6cc/third_party/widevine/cdm/BUILD.gn
[delete] https://crrev.com/9be1f4858403e36a2f2001b1caf6ad14a6fa38c2/third_party/widevine/cdm/stub/manifest.json
[modify] https://crrev.com/d5b69c8251c1710472d4850cf389b18a868bc6cc/third_party/widevine/cdm/widevine.gni
[delete] https://crrev.com/9be1f4858403e36a2f2001b1caf6ad14a6fa38c2/third_party/widevine/cdm/widevinecdmadapter.ver
[modify] https://crrev.com/d5b69c8251c1710472d4850cf389b18a868bc6cc/tools/bisect_repackage/bisect_repackage.py

Comment 24 by xhw...@chromium.org, Mar 21 2018 

I verified d5b69c8251c1710472d4850cf389b18a868bc6cc on Windows/Mac Canary channel. The CDM adapter is not shipped anymore and VMP is still working.
Project Member

Comment 25 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54e8ebb090a1250b114d13c961427b59339d9e60

commit 54e8ebb090a1250b114d13c961427b59339d9e60
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Wed Mar 21 17:38:05 2018

media: Remove PpapiCdmAdapter and friends

So long!

Bug:  772160 
Change-Id: I03b8e919de477bf55d35d14ecde97b0e2524b34b
Reviewed-on: https://chromium-review.googlesource.com/971826
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544760}
[modify] https://crrev.com/54e8ebb090a1250b114d13c961427b59339d9e60/media/base/cdm_promise.h
[modify] https://crrev.com/54e8ebb090a1250b114d13c961427b59339d9e60/media/cdm/cdm_helpers.cc
[modify] https://crrev.com/54e8ebb090a1250b114d13c961427b59339d9e60/media/cdm/cdm_helpers.h
[modify] https://crrev.com/54e8ebb090a1250b114d13c961427b59339d9e60/media/cdm/cdm_wrapper.h
[delete] https://crrev.com/ed224aa6001e266e665c53bccdb506df76f111de/media/cdm/library_cdm/DEPS
[delete] https://crrev.com/ed224aa6001e266e665c53bccdb506df76f111de/media/cdm/library_cdm/cdm_file_io_impl.cc
[delete] https://crrev.com/ed224aa6001e266e665c53bccdb506df76f111de/media/cdm/library_cdm/cdm_file_io_impl.h
[delete] https://crrev.com/ed224aa6001e266e665c53bccdb506df76f111de/media/cdm/library_cdm/cdm_logging.cc
[delete] https://crrev.com/ed224aa6001e266e665c53bccdb506df76f111de/media/cdm/library_cdm/cdm_logging.h
[delete] https://crrev.com/ed224aa6001e266e665c53bccdb506df76f111de/media/cdm/library_cdm/linked_ptr.h
[delete] https://crrev.com/ed224aa6001e266e665c53bccdb506df76f111de/media/cdm/library_cdm/ppapi_cdm_adapter.cc
[delete] https://crrev.com/ed224aa6001e266e665c53bccdb506df76f111de/media/cdm/library_cdm/ppapi_cdm_adapter.gni
[delete] https://crrev.com/ed224aa6001e266e665c53bccdb506df76f111de/media/cdm/library_cdm/ppapi_cdm_adapter.h
[delete] https://crrev.com/ed224aa6001e266e665c53bccdb506df76f111de/media/cdm/library_cdm/ppapi_cdm_buffer.cc
[delete] https://crrev.com/ed224aa6001e266e665c53bccdb506df76f111de/media/cdm/library_cdm/ppapi_cdm_buffer.h
[modify] https://crrev.com/54e8ebb090a1250b114d13c961427b59339d9e60/media/cdm/supported_cdm_versions.h
Project Member

Comment 26 by bugdroid1@chromium.org, Mar 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/596cf4510b74072d847f497b0b943f4543d4e2a7

commit 596cf4510b74072d847f497b0b943f4543d4e2a7
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Wed Mar 21 18:13:07 2018

media: Use |should_bundle_widevine_cdm| in widevine cdm BUILD.gn

This replaces |is_chrome_branded| check for better readibility and
control, especially when the check is combined with the check of
|enable_widevine_cdm_host_verification|, and |enable_widevine| (in
future CLs).

This CL also removes "widevine_signature_scripts" target which was added
for Linux but not used anywhere now.

Bug:  772160 
Change-Id: Iffd10ca32534edc9e57dedf21202847c41aa3fbe
Reviewed-on: https://chromium-review.googlesource.com/971352
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544770}
[modify] https://crrev.com/596cf4510b74072d847f497b0b943f4543d4e2a7/third_party/widevine/cdm/BUILD.gn

Comment 27 by xhw...@chromium.org, Mar 21 2018 

jrummell: PpapiCdmAdapter is removed. Feel free to remove all content decryptor related code in ppapi/, as well as related implementations at the browser side:
- All PPB_contentDecryptor and PPP_contentDecryptor pepper APIs
- All other CDM specific pepper APIs (e.g. Platform Verification, Output Protection, Plugin Private File System). Note that the backend will be hooked up with related mojo services and are still needed.
Project Member

Comment 28 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a1ec7e112c5e7d0d4b24c2b98e0ad49ef1783c07

commit a1ec7e112c5e7d0d4b24c2b98e0ad49ef1783c07
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Mar 22 03:48:34 2018

chrome-sdk: Remove Widevine CDM adapter

As part of pepper CDM deprecation, we do not have the Widevine CDM
adapter binary any more.

Bug:  772160 ,  823986 
Test: Tested by deploying chrome to cros vm.
      See http://go/simple-chrome and go/cros-vm.
Change-Id: I0d7e72006b468696a4b13dafebe1de041571e1cb
Reviewed-on: https://chromium-review.googlesource.com/971665
Commit-Ready: Xiaohan Wang <xhwang@chromium.org>
Tested-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>

[modify] https://crrev.com/a1ec7e112c5e7d0d4b24c2b98e0ad49ef1783c07/lib/chrome_util.py
Project Member

Comment 29 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0141102462dab3a9e540c41032291f6433effe7b

commit 0141102462dab3a9e540c41032291f6433effe7b
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Mar 22 04:38:46 2018

media: Remove ppapi/ dependency from media/

Less dependency is better. Media code should not need to know
third_party plugins (ppapi/). This CL removes ppapi/ dependency from
media/ to enforce this.

Bug:  772160 
Change-Id: Ib4e1bf6b6a5a87dde16e5130830e589769a2ca89
Reviewed-on: https://chromium-review.googlesource.com/974574
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544978}
[modify] https://crrev.com/0141102462dab3a9e540c41032291f6433effe7b/media/BUILD.gn
[modify] https://crrev.com/0141102462dab3a9e540c41032291f6433effe7b/media/DEPS
[modify] https://crrev.com/0141102462dab3a9e540c41032291f6433effe7b/media/base/BUILD.gn
[modify] https://crrev.com/0141102462dab3a9e540c41032291f6433effe7b/media/base/cdm_promise_adapter.h
[modify] https://crrev.com/0141102462dab3a9e540c41032291f6433effe7b/media/base/media_switches.cc
[modify] https://crrev.com/0141102462dab3a9e540c41032291f6433effe7b/media/base/media_switches.h
[modify] https://crrev.com/0141102462dab3a9e540c41032291f6433effe7b/media/cdm/DEPS
[modify] https://crrev.com/0141102462dab3a9e540c41032291f6433effe7b/media/media_options.gni
[modify] https://crrev.com/0141102462dab3a9e540c41032291f6433effe7b/media/mojo/services/mojo_cdm_allocator.h
Project Member

Comment 30 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c966e00e868ad1aeaa268d7c373e7ce8e5612968

commit c966e00e868ad1aeaa268d7c373e7ce8e5612968
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Mar 22 06:36:31 2018

Roll src/third_party/chromite/ 8bf5a7243..a1ec7e112 (2 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/8bf5a724397c..a1ec7e112c5e

$ git log 8bf5a7243..a1ec7e112 --date=short --no-merges --format='%ad %ae %s'
2018-03-21 xhwang chrome-sdk: Remove Widevine CDM adapter
2018-03-17 pberny atlas: Add master builder configuration

Created with:
  roll-dep src/third_party/chromite

TBR=achuith@chromium.org,vapier@chromium.org
BUG= 772160 , 823986 

Change-Id: I12d8487657339b574b5285c6598a84e14fa4afed
Reviewed-on: https://chromium-review.googlesource.com/974798
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544987}
[modify] https://crrev.com/c966e00e868ad1aeaa268d7c373e7ce8e5612968/DEPS
Project Member

Comment 31 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a833a9a64ff54b3eee785705356a759637991a6

commit 1a833a9a64ff54b3eee785705356a759637991a6
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Mar 22 21:27:26 2018

media: Widevine CDM binary/manifest as data_deps of "cdm" target

The swarming client needs this data_deps to put the CDM files in the
isolate (send them to the swarming bot).

We still need to keep the public_deps since it's needed to build the mac
bundle.

Bug:  772160 , 824493 

Test: Tested locally on a Linux box with is_chrome_branded, following
instructions on how to generate swarming isolate locally:
https://www.chromium.org/developers/testing/isolated-testing/for-swes#TOC-Run-a-test-built-locally-on-Swarming
More specifically, I tried load_library_perf_tests, which also depend on
the "cdm" target:
- ninja -C out/Debug -j1000 load_library_perf_tests
- echo gn > out/Debug/mb_type
- tools/mb/mb.py isolate //out/Debug load_library_perf_tests
With the fix, libwidevinecdm.so is in the isolate file.

Change-Id: I68f62a819302be811944614292db447c601cadcb
Reviewed-on: https://chromium-review.googlesource.com/976384
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545256}
[modify] https://crrev.com/1a833a9a64ff54b3eee785705356a759637991a6/third_party/widevine/cdm/BUILD.gn
Project Member

Comment 32 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc665c309169a09fe5e1aee961a3c2fb4fb15563

commit fc665c309169a09fe5e1aee961a3c2fb4fb15563
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Wed Mar 28 16:46:14 2018

media: Remove ppapi dependency in third_party/widevine

TBR=jrummell@chromium.org

Bug:  772160 
Change-Id: I087f9ce68e17503680a7b8e145d99181dd4492fc
Reviewed-on: https://chromium-review.googlesource.com/982814
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546522}
[modify] https://crrev.com/fc665c309169a09fe5e1aee961a3c2fb4fb15563/third_party/widevine/cdm/DEPS
Project Member

Comment 33 by bugdroid1@chromium.org, Mar 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e16205da434f46379bd8080b1e513c6ce3b32c4f

commit e16205da434f46379bd8080b1e513c6ce3b32c4f
Author: John Rummell <jrummell@chromium.org>
Date: Fri Mar 30 16:43:58 2018

Remove content decryptor pepper APIs

Now that CDMs use mojo exclusively, remove the Pepper APIs that are
now unused.

BUG= 772160 
TEST=compiles

Change-Id: Ifa77be717e7b11ab20ae8053901dcb663b1726cc
Reviewed-on: https://chromium-review.googlesource.com/981125
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547187}
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/build/check_gn_headers_whitelist.txt
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/chrome/common/ppapi_utils.cc
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/content/renderer/pepper/pepper_plugin_instance_impl.cc
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/content/renderer/pepper/pepper_plugin_instance_impl.h
[delete] https://crrev.com/aeb7eca0a312cb0d0eefd3a8eee0931a9fad80b5/ppapi/api/private/pp_content_decryptor.idl
[delete] https://crrev.com/aeb7eca0a312cb0d0eefd3a8eee0931a9fad80b5/ppapi/api/private/ppb_content_decryptor_private.idl
[delete] https://crrev.com/aeb7eca0a312cb0d0eefd3a8eee0931a9fad80b5/ppapi/api/private/ppp_content_decryptor_private.idl
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/c/BUILD.gn
[delete] https://crrev.com/aeb7eca0a312cb0d0eefd3a8eee0931a9fad80b5/ppapi/c/private/pp_content_decryptor.h
[delete] https://crrev.com/aeb7eca0a312cb0d0eefd3a8eee0931a9fad80b5/ppapi/c/private/ppb_content_decryptor_private.h
[delete] https://crrev.com/aeb7eca0a312cb0d0eefd3a8eee0931a9fad80b5/ppapi/c/private/ppp_content_decryptor_private.h
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/cpp/BUILD.gn
[delete] https://crrev.com/aeb7eca0a312cb0d0eefd3a8eee0931a9fad80b5/ppapi/cpp/private/content_decryptor_private.cc
[delete] https://crrev.com/aeb7eca0a312cb0d0eefd3a8eee0931a9fad80b5/ppapi/cpp/private/content_decryptor_private.h
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/proxy/BUILD.gn
[delete] https://crrev.com/aeb7eca0a312cb0d0eefd3a8eee0931a9fad80b5/ppapi/proxy/content_decryptor_private_serializer.h
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/proxy/interface_list.cc
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/proxy/ppapi_messages.h
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/proxy/ppapi_param_traits.cc
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/proxy/ppapi_param_traits.h
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/proxy/ppb_instance_proxy.cc
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/proxy/ppb_instance_proxy.h
[delete] https://crrev.com/aeb7eca0a312cb0d0eefd3a8eee0931a9fad80b5/ppapi/proxy/ppp_content_decryptor_private_proxy.cc
[delete] https://crrev.com/aeb7eca0a312cb0d0eefd3a8eee0931a9fad80b5/ppapi/proxy/ppp_content_decryptor_private_proxy.h
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/shared_impl/api_id.h
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/tests/all_c_includes.h
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/tests/all_cpp_includes.h
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/thunk/BUILD.gn
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/thunk/interfaces_ppb_private.h
[delete] https://crrev.com/aeb7eca0a312cb0d0eefd3a8eee0931a9fad80b5/ppapi/thunk/ppb_content_decryptor_private_thunk.cc
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/ppapi/thunk/ppb_instance_api.h
[modify] https://crrev.com/e16205da434f46379bd8080b1e513c6ce3b32c4f/tools/ipc_fuzzer/fuzzer/fuzzer.cc
Project Member

Comment 34 by bugdroid1@chromium.org, Apr 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8682bf273c2d70d940460f270f77a8afa53beb37

commit 8682bf273c2d70d940460f270f77a8afa53beb37
Author: John Rummell <jrummell@chromium.org>
Date: Tue Apr 10 23:23:01 2018

Remove output protection pepper APIs

Now that CDMs use mojo exclusively, remove the Pepper APIs that are
now unused.

BUG= 772160 
TEST=compiles

Change-Id: I4161d7430f86f5033dd7997fb5f2cc4a04aefa22
Reviewed-on: https://chromium-review.googlesource.com/988254
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ben Smith <binji@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549671}
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/chrome/browser/BUILD.gn
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/chrome/browser/renderer_host/pepper/chrome_browser_pepper_host_factory.cc
[delete] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.cc
[delete] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/chrome/browser/renderer_host/pepper/pepper_output_protection_message_filter.h
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/chrome/common/ppapi_utils.cc
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/chrome/test/ppapi/ppapi_browsertest.cc
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/content/renderer/pepper/plugin_module.cc
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/content/renderer/pepper/resource_creation_impl.cc
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/content/renderer/pepper/resource_creation_impl.h
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/native_client_sdk/src/libraries/ppapi_cpp_private/library.dsc
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/ppapi/BUILD.gn
[delete] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/ppapi/api/private/ppb_output_protection_private.idl
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/ppapi/c/BUILD.gn
[delete] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/ppapi/c/private/ppb_output_protection_private.h
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/ppapi/cpp/BUILD.gn
[delete] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/ppapi/cpp/private/output_protection_private.cc
[delete] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/ppapi/cpp/private/output_protection_private.h
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/ppapi/proxy/BUILD.gn
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/ppapi/proxy/interface_list.cc
[delete] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/ppapi/proxy/output_protection_resource.cc
[delete] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/ppapi/proxy/output_protection_resource.h
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/ppapi/proxy/ppapi_messages.h
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/ppapi/proxy/resource_creation_proxy.cc
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/ppapi/proxy/resource_creation_proxy.h
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/ppapi/shared_impl/resource.h
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/ppapi/tests/all_c_includes.h
[delete] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/ppapi/tests/test_output_protection_private.cc
[delete] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/ppapi/tests/test_output_protection_private.h
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/ppapi/thunk/BUILD.gn
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/ppapi/thunk/interfaces_ppb_private.h
[delete] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/ppapi/thunk/ppb_output_protection_api.h
[delete] https://crrev.com/0e4e6c2d84bb046811ddec96cc4fb7ccc24b34aa/ppapi/thunk/ppb_output_protection_private_thunk.cc
[modify] https://crrev.com/8682bf273c2d70d940460f270f77a8afa53beb37/ppapi/thunk/resource_creation_api.h
Project Member

Comment 35 by bugdroid1@chromium.org, Apr 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/729d804e8f8be6c789a3112a144871baf219b38d

commit 729d804e8f8be6c789a3112a144871baf219b38d
Author: John Rummell <jrummell@chromium.org>
Date: Thu Apr 12 07:35:26 2018

Remove platform verification pepper APIs

Now that CDMs use mojo exclusively, remove the Pepper APIs that are
now unused.

BUG= 772160 
TEST=compiles

Change-Id: I1639e3ab7f6fbb3e328a8b9b7c2a2e57c6d5467e
Reviewed-on: https://chromium-review.googlesource.com/1007885
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550079}
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/chrome/browser/BUILD.gn
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/chrome/browser/renderer_host/pepper/chrome_browser_pepper_host_factory.cc
[delete] https://crrev.com/5c500489a0675663b2163bdbf3ba94f49b4771de/chrome/browser/renderer_host/pepper/pepper_platform_verification_message_filter.cc
[delete] https://crrev.com/5c500489a0675663b2163bdbf3ba94f49b4771de/chrome/browser/renderer_host/pepper/pepper_platform_verification_message_filter.h
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/chrome/common/ppapi_utils.cc
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/chrome/test/ppapi/ppapi_browsertest.cc
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/content/renderer/pepper/plugin_module.cc
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/content/renderer/pepper/resource_creation_impl.cc
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/content/renderer/pepper/resource_creation_impl.h
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/ppapi/BUILD.gn
[delete] https://crrev.com/5c500489a0675663b2163bdbf3ba94f49b4771de/ppapi/api/private/ppb_platform_verification_private.idl
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/ppapi/c/BUILD.gn
[delete] https://crrev.com/5c500489a0675663b2163bdbf3ba94f49b4771de/ppapi/c/private/ppb_platform_verification_private.h
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/ppapi/cpp/BUILD.gn
[delete] https://crrev.com/5c500489a0675663b2163bdbf3ba94f49b4771de/ppapi/cpp/private/platform_verification.cc
[delete] https://crrev.com/5c500489a0675663b2163bdbf3ba94f49b4771de/ppapi/cpp/private/platform_verification.h
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/ppapi/proxy/BUILD.gn
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/ppapi/proxy/interface_list.cc
[delete] https://crrev.com/5c500489a0675663b2163bdbf3ba94f49b4771de/ppapi/proxy/platform_verification_private_resource.cc
[delete] https://crrev.com/5c500489a0675663b2163bdbf3ba94f49b4771de/ppapi/proxy/platform_verification_private_resource.h
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/ppapi/proxy/ppapi_messages.h
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/ppapi/proxy/resource_creation_proxy.cc
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/ppapi/proxy/resource_creation_proxy.h
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/ppapi/shared_impl/resource.h
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/ppapi/tests/all_c_includes.h
[delete] https://crrev.com/5c500489a0675663b2163bdbf3ba94f49b4771de/ppapi/tests/test_platform_verification_private.cc
[delete] https://crrev.com/5c500489a0675663b2163bdbf3ba94f49b4771de/ppapi/tests/test_platform_verification_private.h
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/ppapi/thunk/BUILD.gn
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/ppapi/thunk/interfaces_ppb_private.h
[delete] https://crrev.com/5c500489a0675663b2163bdbf3ba94f49b4771de/ppapi/thunk/ppb_platform_verification_api.h
[delete] https://crrev.com/5c500489a0675663b2163bdbf3ba94f49b4771de/ppapi/thunk/ppb_platform_verification_private_thunk.cc
[modify] https://crrev.com/729d804e8f8be6c789a3112a144871baf219b38d/ppapi/thunk/resource_creation_api.h

Comment 36 by xhw...@chromium.org, Apr 13 2018

Status: Fixed (was: Started)
Most (if not all) pepper CDM code removed. More clean up (see blocking issues) will follow.

For the record: 15480 lines of code removed, with 215 new lines added.

Cheers!

------

git log --grep=772160  --numstat --pretty="%H" | awk 'NF==3 {plus+=$1; minus+=$2} END {printf("+%d, -%d\n", plus, minus)}'

+215, -15480
Project Member

Comment 37 by bugdroid1@chromium.org, Jun 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73932db2f4d577a6f304f6f6dd5b0ce7164b8b40

commit 73932db2f4d577a6f304f6f6dd5b0ce7164b8b40
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Fri Jun 08 16:24:51 2018

media: MediaBrowserTest not watching for plugin crash

Now the CDM is not running in a plugin, there's no need for
MediaBrowserTest to watch for plugin crash.

For the record, see the original CL that added this:
https://codereview.chromium.org/206693004

Bug:  772160 
Test: Remove obsolete code. No functionality change.
Change-Id: I8c0a9e74cc4c1d05b153f1e80a0882ee28287ac7
Reviewed-on: https://chromium-review.googlesource.com/1091888
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565649}
[modify] https://crrev.com/73932db2f4d577a6f304f6f6dd5b0ce7164b8b40/chrome/browser/media/encrypted_media_browsertest.cc
[modify] https://crrev.com/73932db2f4d577a6f304f6f6dd5b0ce7164b8b40/chrome/browser/media/media_browsertest.cc
[modify] https://crrev.com/73932db2f4d577a6f304f6f6dd5b0ce7164b8b40/chrome/browser/media/media_browsertest.h
Project Member

Comment 38 by bugdroid1@chromium.org, Jun 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56d3597eb46a8f02ea8eb2964940ab15b64f1f9d

commit 56d3597eb46a8f02ea8eb2964940ab15b64f1f9d
Author: Mark Pearson <mpearson@chromium.org>
Date: Fri Jun 08 18:44:08 2018

Revert "media: MediaBrowserTest not watching for plugin crash"

This reverts commit 73932db2f4d577a6f304f6f6dd5b0ce7164b8b40.

Reason for revert: caused failure in
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/3347

failures:
MSE_ExternalClearKey/EncryptedMediaTest.Playback_VideoOnly_MP4/0

[ RUN      ] MSE_ExternalClearKey/EncryptedMediaTest.Playback_VideoOnly_MP4/0
[51235:2819:0608/103709.237938:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated.
2018-06-08 10:37:09.383 browser_tests[51235:780694] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug.
BrowserTestBase received signal: Terminated: 15. Backtrace:
0   browser_tests                       0x000000010ea3aeac base::debug::StackTrace::StackTrace(unsigned long) + 28
1   browser_tests                       0x000000010efd4b45 content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 229
2   libsystem_platform.dylib            0x00007fff51ad5f5a _sigtramp + 26
3   browser_tests                       0x000000010e9b6c3f base::internal::IncomingTaskQueue::PostPendingTask(base::PendingTask*) + 111
4   CoreFoundation                      0x00007fff29e9bdc5 __CFRunLoopServiceMachPort + 341
5   CoreFoundation                      0x00007fff29e9b117 __CFRunLoopRun + 1783
6   CoreFoundation                      0x00007fff29e9a787 CFRunLoopRunSpecific + 487
7   HIToolbox                           0x00007fff291a7e26 RunCurrentEventLoopInMode + 286
8   HIToolbox                           0x00007fff291a7b96 ReceiveNextEventCommon + 613
9   HIToolbox                           0x00007fff291a7914 _BlockUntilNextEventMatchingListInModeWithFilter + 64
10  AppKit                              0x00007fff27472f5f _DPSNextEvent + 2085
11  AppKit                              0x00007fff27c08b4c -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 3044
12  browser_tests                       0x000000010eae2920 __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 64
13  browser_tests                       0x000000010e9ab94a base::mac::CallWithEHFrame(void () block_pointer) + 10
14  browser_tests                       0x000000010eae2854 -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 164
15  AppKit                              0x00007fff27467d6d -[NSApplication run] + 764
16  browser_tests                       0x000000010e9bbc0c base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 364
17  browser_tests                       0x000000010e9ba72e base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110
18  browser_tests                       0x000000010e9dee55 base::RunLoop::Run() + 53
19  browser_tests                       0x000000010effa3b9 content::WindowedNotificationObserver::Wait() + 153
20  browser_tests                       0x000000010efd5959 content::WaitForLoadStop(content::WebContents*) + 105
21  browser_tests                       0x000000010ea70771 InProcessBrowserTest::PreRunTestOnMainThread() + 161
22  browser_tests                       0x000000010efd4778 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 280
23  browser_tests                       0x000000010eae8a45 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4341
24  browser_tests                       0x000000010eae784e ChromeBrowserMainParts::PreMainMessageLoopRun() + 62
25  browser_tests                       0x000000010d57f283 content::BrowserMainLoop::PreMainMessageLoopRun() + 67
26  browser_tests                       0x000000010d96b377 content::StartupTaskRunner::RunAllTasksNow() + 39
27  browser_tests                       0x000000010d57dccd content::BrowserMainLoop::CreateStartupTasks() + 813
28  browser_tests                       0x000000010d581562 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 98
29  browser_tests                       0x000000010d57bd4c content::BrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserProcessSubThread, std::__1::default_delete<content::BrowserProcessSubThread> >) + 204
30  browser_tests                       0x000000010e92fa77 content::ContentMainRunnerImpl::Run() + 615
31  browser_tests                       0x000000011060dab5 service_manager::Main(service_manager::MainParams const&) + 2709
32  browser_tests                       0x000000010e92ea74 content::ContentMain(content::ContentMainParams const&) + 68
33  browser_tests                       0x000000010efd447b content::BrowserTestBase::SetUp() + 2571
34  browser_tests                       0x000000010ea6f8d3 InProcessBrowserTest::SetUp() + 723
35  browser_tests                       0x000000010ca9350d testing::Test::Run() + 109
36  browser_tests                       0x000000010ca941a0 testing::TestInfo::Run() + 320
37  browser_tests                       0x000000010ca94717 testing::TestCase::Run() + 279
38  browser_tests                       0x000000010ca9fd87 testing::internal::UnitTestImpl::RunAllTests() + 871
39  browser_tests                       0x000000010ca9f9fd testing::UnitTest::Run() + 109
40  browser_tests                       0x000000010ea89786 base::TestSuite::Run() + 166
41  browser_tests                       0x000000010e98b2f5 ChromeTestSuiteRunner::RunTestSuite(int, char**) + 37
42  browser_tests                       0x000000010eff5f35 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 389
43  browser_tests                       0x000000010e98b7db LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) + 347
44  browser_tests                       0x000000010e98b26e main + 94
45  libdyld.dylib                       0x00007fff51854115 start + 1
46  ???                                 0x000000000000000a 0x0 + 10


Original change's description:
> media: MediaBrowserTest not watching for plugin crash
> 
> Now the CDM is not running in a plugin, there's no need for
> MediaBrowserTest to watch for plugin crash.
> 
> For the record, see the original CL that added this:
> https://codereview.chromium.org/206693004
> 
> Bug:  772160 
> Test: Remove obsolete code. No functionality change.
> Change-Id: I8c0a9e74cc4c1d05b153f1e80a0882ee28287ac7
> Reviewed-on: https://chromium-review.googlesource.com/1091888
> Reviewed-by: Frank Liberato <liberato@chromium.org>
> Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565649}

TBR=xhwang@chromium.org,liberato@chromium.org

Change-Id: Ib80cd4be4d495c13f19196456ac621168acfa270
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  772160 
Reviewed-on: https://chromium-review.googlesource.com/1093514
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565702}
[modify] https://crrev.com/56d3597eb46a8f02ea8eb2964940ab15b64f1f9d/chrome/browser/media/encrypted_media_browsertest.cc
[modify] https://crrev.com/56d3597eb46a8f02ea8eb2964940ab15b64f1f9d/chrome/browser/media/media_browsertest.cc
[modify] https://crrev.com/56d3597eb46a8f02ea8eb2964940ab15b64f1f9d/chrome/browser/media/media_browsertest.h
Project Member

Comment 39 by bugdroid1@chromium.org, Aug 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b8b4b6867da07ca898e680e040c2c8342d5538e

commit 9b8b4b6867da07ca898e680e040c2c8342d5538e
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Wed Aug 15 17:40:24 2018

Reland "media: MediaBrowserTest not watching for plugin crash"

This reverts commit 56d3597eb46a8f02ea8eb2964940ab15b64f1f9d and
relands the original CL.

Reason for revert: The failure (revert reason) doesn't seem to be
caused by this CL.

Original change's description:
> media: MediaBrowserTest not watching for plugin crash
>
> Now the CDM is not running in a plugin, there's no need for
> MediaBrowserTest to watch for plugin crash.

Bug:  772160 
Change-Id: I387abcd37e85b703e2d0d1bf67be1f82dd68bf68
Reviewed-on: https://chromium-review.googlesource.com/1174852
Reviewed-by: John Rummell <jrummell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583304}
[modify] https://crrev.com/9b8b4b6867da07ca898e680e040c2c8342d5538e/chrome/browser/media/encrypted_media_browsertest.cc
[modify] https://crrev.com/9b8b4b6867da07ca898e680e040c2c8342d5538e/chrome/browser/media/media_browsertest.cc
[modify] https://crrev.com/9b8b4b6867da07ca898e680e040c2c8342d5538e/chrome/browser/media/media_browsertest.h
Project Member

Comment 40 by bugdroid1@chromium.org, Sep 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c7bd7624f078f34d688c11978c6a57e38056848

commit 7c7bd7624f078f34d688c11978c6a57e38056848
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Wed Sep 12 20:45:34 2018

Update PluginPrivateDataDeletionHelper documentation

Now CDM is not a plugin anymore, update the documentation to reflect the
current state.

Bug:  772160 
Test: No functionality change.
Change-Id: I91d044cf23f1331e93840c5ecf9a8ae4f654f842
Reviewed-on: https://chromium-review.googlesource.com/1220561
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590813}
[modify] https://crrev.com/7c7bd7624f078f34d688c11978c6a57e38056848/content/browser/plugin_private_storage_helper.cc
Project Member

Comment 41 by bugdroid1@chromium.org, Sep 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87aec3af8dbb1eb5bf699c0fb6a5c462385e7146

commit 87aec3af8dbb1eb5bf699c0fb6a5c462385e7146
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Tue Sep 18 05:01:36 2018

media: Remove unused Widevine CDM constants

These are not used after deprecating PPAPI CDM support.

Bug:  772160 
Change-Id: I95370a698773a7c27cc38ad331670263877c77e7
Reviewed-on: https://chromium-review.googlesource.com/1228509
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591941}
[modify] https://crrev.com/87aec3af8dbb1eb5bf699c0fb6a5c462385e7146/third_party/widevine/cdm/widevine_cdm_common.h
Project Member

Comment 42 by bugdroid1@chromium.org, Oct 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7958ff945d2d4d7ca0f4317cece2baa94d16043e

commit 7958ff945d2d4d7ca0f4317cece2baa94d16043e
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Sat Oct 06 00:59:55 2018

media: No need to copy widevinecdm.dll.lib

Now the CDM is loaded as a shared library. We do not need the .lib file
in the build process.

Bug:  772160 
Change-Id: Iee1fe3995a72b5fa79ead43f2e10880a6f4bc433
Reviewed-on: https://chromium-review.googlesource.com/c/1265909
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597387}
[modify] https://crrev.com/7958ff945d2d4d7ca0f4317cece2baa94d16043e/third_party/widevine/cdm/BUILD.gn
►

Sign in to add a comment