New issue
Advanced search Search tips

Issue 772148 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Verify manifests for service worker payment apps on desktop.

Project Member Reported by rouslan@chromium.org, Oct 5 2017

Issue description

Verify manifests for service worker payment apps on desktop.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eea9bc21c524d8de30647b2e13c1c7173434a8e

commit 4eea9bc21c524d8de30647b2e13c1c7173434a8e
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Tue Oct 10 15:18:51 2017

[Payments] Verify payment method manifest on desktop.

Before this patch, any service worker payment app could use any URL as a
payment method on desktop.

This patch filters the service worker payment apps through the payment
manifest verifier on desktop.

After this patch, payment method manifests define the origins of the
service worker payment apps that can use the payment method on desktop.

Flags:
chrome://flags/#service-worker-payment-apps
chrome://flags/#enable-experimental-web-platform-features

Specs:
https://w3c.github.io/payment-handler/
https://w3c.github.io/payment-method-manifest/

Bug:  772148 
Change-Id: Iecb870f94cedaa9ab27851b910a125c386df1fe7
Reviewed-on: https://chromium-review.googlesource.com/703555
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507671}
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/chrome/browser/payments/chrome_payment_request_delegate.cc
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/chrome/browser/payments/chrome_payment_request_delegate.h
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/content/BUILD.gn
[add] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/content/content_payment_request_delegate.h
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/content/payment_request.cc
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/content/payment_request.h
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/content/payment_request_spec.cc
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/content/payment_request_spec.h
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/content/payment_request_state.cc
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/content/payment_request_state.h
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/content/payment_request_state_unittest.cc
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/content/payment_request_web_contents_manager.cc
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/content/payment_request_web_contents_manager.h
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/content/service_worker_payment_instrument.cc
[add] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/content/test_content_payment_request_delegate.cc
[add] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/content/test_content_payment_request_delegate.h
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/core/payment_request_data_util.cc
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/core/payment_request_data_util.h
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/components/payments/core/test_payment_request_delegate.h
[modify] https://crrev.com/4eea9bc21c524d8de30647b2e13c1c7173434a8e/ios/chrome/browser/payments/payment_request.mm

Status: Fixed (was: Started)

Sign in to add a comment