Default Theme color need to be updated when detached tabs are attached.
Reported by
ltian@chromium.org,
Oct 5 2017
|
||
Issue descriptionDetach tabs are created by CCT and Browser Actions whose activity does not have bottom sheet. So when the tabs are attached to tabbed mode, default theme color could change. So when tabs are attached, default theme color should be updated.
,
Oct 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a071b83389330a024a514e5c1b0c943458ae5f9d commit a071b83389330a024a514e5c1b0c943458ae5f9d Author: Lei Tian <ltian@google.com> Date: Sat Oct 07 00:28:54 2017 Update theme color when detached tabs attached. When a detached tab attached to a ChromeActivity, the theme color could change because tabbed mode tabs' theme color relies on the bottom sheet while CCT and Browser Actions' does not. Update the default theme color and the theme color in Tab.attach() and notify all the observers if needed. Bug: 772136 Change-Id: I0aace2f84fc898e97584a33541b0af8285b373a9 Reviewed-on: https://chromium-review.googlesource.com/703933 Commit-Queue: Lei Tian <ltian@google.com> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#507241} [modify] https://crrev.com/a071b83389330a024a514e5c1b0c943458ae5f9d/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
,
Jun 7 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by ltian@chromium.org
, Oct 5 2017