New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772132 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add --unmount_all flag to M-62

Project Member Reported by kerrnel@chromium.org, Oct 5 2017

Issue description

Project Member

Comment 1 by sheriffbot@chromium.org, Oct 5 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: bhthompson@chromium.org
Labels: -Merge-Review-62 Merge-Approved-62
Approved to M62
In order to test to see if this has resolved 76007:

1) Make sure a component loaded version of PepperFlash is installed and loaded. This requires the internal version of Chrome. Chromium does not install pepperflash. This can be verified by going to chrome://version and looking at the path next to "Flash". If the path is /opt/google/chrome/pepper/libpepflashplayer.so, you may need to 1) add --ppapi-flash-version=0.0.0.0 to /etc/chrome_dev.conf 2) reboot 3) go to chrome://components and update pepper flash player 4) rename /opt/google/chrome/pepper/pepper-flash.info 5) reboot 6) Check chrome://version to verify that Flash is loaded from /run/imageloader/PepperFlashPlayer/libpepflashplayer.so

2) Reboot

3) Check to make sure /mnt/stateful_partition/shutdown_stateful_umount_failure does not exist and "dmesg | grep 'recovery'" is empty. If either of these conditions are not met, it indicates that /run/imageloader/PepperFlashPlayer or some other loaded image was not unmounted prior to trying to unmount /mnt/stateful_partition.

4) Check "cat /var/log/messages | grep imageloader". If there are errors about checking the version and mounting, that is normal if it was before the flash component update was installed. If there are any errors after that, these may indicate a failure.
Cc: gwendal@chromium.org sonnyrao@chromium.org
Components: OS>Kernel>IntStorage
re #3 - that looks reasonable to me
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 6 2017

Labels: merge-merged-release-R62-9901.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e43d8af075ffad0a1a7c690e21f5db7d13cba6c3

commit e43d8af075ffad0a1a7c690e21f5db7d13cba6c3
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Oct 06 23:53:41 2017

imageloader: add libdevmapper dep

BUG= chromium:770386 
BUG= chromium:760007 
BUG= chromium:772132 
TEST=precq passes

Change-Id: I7d0d208b03db5430f1c7a6f7485d78e4fc853c34
Reviewed-on: https://chromium-review.googlesource.com/693224
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Allen Webb <allenwebb@google.com>
(cherry picked from commit c745a92832f1f13ffaf32329306eb9c98a21a359)
Reviewed-on: https://chromium-review.googlesource.com/701574
Trybot-Ready: Allen Webb <allenwebb@google.com>
Tested-by: Allen Webb <allenwebb@google.com>
Commit-Queue: Allen Webb <allenwebb@google.com>

[modify] https://crrev.com/e43d8af075ffad0a1a7c690e21f5db7d13cba6c3/chromeos-base/imageloader/imageloader-9999.ebuild

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/06c56d3140a4bb5be69a23a274d0475400b69b1d

commit 06c56d3140a4bb5be69a23a274d0475400b69b1d
Author: Allen Webb <allenwebb@google.com>
Date: Fri Oct 06 23:53:45 2017

platform_ImageLoader: Added tests for --unmount_all and --unmount.

BUG= chromium:760007 
BUG= chromium:772132 
CQ-DEPEND=CL:701594
TEST=test_that -b amd64-generic <ip:port> platform_ImageLoaderServer

Change-Id: Ic0547aa60a7c3d69bc29a73c0cb698583d366ac4
Reviewed-on: https://chromium-review.googlesource.com/682339
Commit-Ready: Allen Webb <allenwebb@google.com>
Tested-by: Allen Webb <allenwebb@google.com>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
(cherry picked from commit 7076091b18ab7d8b14722d224b456409b89070bb)
Reviewed-on: https://chromium-review.googlesource.com/690815
Trybot-Ready: Allen Webb <allenwebb@google.com>
Commit-Queue: Allen Webb <allenwebb@google.com>

[modify] https://crrev.com/06c56d3140a4bb5be69a23a274d0475400b69b1d/client/site_tests/platform_ImageLoader/platform_ImageLoader.py

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/imageloader/+/69850078c6ab9bd3e46dc2312aa89e883adfb0dc

commit 69850078c6ab9bd3e46dc2312aa89e883adfb0dc
Author: Allen Webb <allenwebb@google.com>
Date: Fri Oct 06 23:53:52 2017

imageloader: Added an unmount_all flag.

BUG= chromium:760007 
BUG= chromium:772132 
CQ-DEPEND=CL:690815
CQ-DEPEND=CL:701574
TEST=test_that -b amd64-generic <ip:port> platform_ImageLoaderServer

Change-Id: I1739d36c086c1a124d2c4c79ed2ec05b1fdd2987
Reviewed-on: https://chromium-review.googlesource.com/677792
Commit-Ready: Allen Webb <allenwebb@google.com>
Tested-by: Allen Webb <allenwebb@google.com>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
(cherry picked from commit c1a83d303c0643d8d089d501a29a583268d3f43a)
Reviewed-on: https://chromium-review.googlesource.com/701594
Trybot-Ready: Allen Webb <allenwebb@google.com>
Reviewed-by: Allen Webb <allenwebb@google.com>
Commit-Queue: Allen Webb <allenwebb@google.com>

[modify] https://crrev.com/69850078c6ab9bd3e46dc2312aa89e883adfb0dc/imageloader.gyp
[add] https://crrev.com/69850078c6ab9bd3e46dc2312aa89e883adfb0dc/verity_mounter_impl.h
[add] https://crrev.com/69850078c6ab9bd3e46dc2312aa89e883adfb0dc/verity_mounter_impl.cc
[modify] https://crrev.com/69850078c6ab9bd3e46dc2312aa89e883adfb0dc/verity_mounter.h
[add] https://crrev.com/69850078c6ab9bd3e46dc2312aa89e883adfb0dc/verity_mounter_unittest.cc
[modify] https://crrev.com/69850078c6ab9bd3e46dc2312aa89e883adfb0dc/verity_mounter.cc
[modify] https://crrev.com/69850078c6ab9bd3e46dc2312aa89e883adfb0dc/imageloader_main.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/imageloader/+/08941abfd7fe79eb54f51f71e6fae87a3c9c619f

commit 08941abfd7fe79eb54f51f71e6fae87a3c9c619f
Author: Allen Webb <allenwebb@google.com>
Date: Fri Oct 06 23:53:55 2017

imageloader: Execute unmount_all flag on stopped ui.

BUG= chromium:760007 
BUG= chromium:772132 
CQ-DEPEND=CL:701594
TEST=test_that -b amd64-generic <ip:port> platform_ImageLoaderServer

Change-Id: I0ec96c441b238ce3b9f3a5df220e60a2b9e1e814
Reviewed-on: https://chromium-review.googlesource.com/690438
Commit-Ready: Allen Webb <allenwebb@google.com>
Tested-by: Allen Webb <allenwebb@google.com>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
(cherry picked from commit f4e8671e0ce791c7cc6ad570dfe03d695382fa30)
Reviewed-on: https://chromium-review.googlesource.com/701595
Trybot-Ready: Allen Webb <allenwebb@google.com>
Reviewed-by: Allen Webb <allenwebb@google.com>
Commit-Queue: Allen Webb <allenwebb@google.com>

[modify] https://crrev.com/08941abfd7fe79eb54f51f71e6fae87a3c9c619f/imageloader-shutdown.conf

Project Member

Comment 11 by sheriffbot@chromium.org, Oct 9 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 769970
Project Member

Comment 13 by sheriffbot@chromium.org, Oct 12 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-62
Blocking: -769970
Status: Fixed (was: Assigned)

Sign in to add a comment