New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772124 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Use net:Error instead of `int` for net errors in the committed interstitial code paths.

Project Member Reported by lgar...@chromium.org, Oct 5 2017

Issue description

I had a refactoring error that ended up passing the result of a function with an integer return value straight into a function that takes an error code.

I believe NavigationHandle takes net::Error already, and I don't see any downsides of using it throughout.
 
Cc: est...@chromium.org
Labels: Proj-CommittedInterstitials
estark@: I'm putting this in my spreadsheet under low-priority cleanup. :-)
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 8

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Owner: carlosil@chromium.org
Assigning to carlosil@, who is working on committed interstitials.
Labels: android-fe-triaged
Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment