New issue
Advanced search Search tips

Issue 772115 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

InsertText command crashes with unusual HTML

Project Member Reported by ClusterFuzz, Oct 5 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5527320994775040

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_syzyasan_chrome
Platform Id: windows

Crash Type: Null-dereference
Crash Address: 0x0000000b
Crash State:
  blink::Node::ContainsIncludingHostElements
  blink::ComputePositionForChildrenRemoval
  blink::SelectionEditor::NodeChildrenWillBeRemoved
  
Memory Tool: SYZYASAN

Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_chrome&range=483672:483687

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5527320994775040

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 5 2017

Components: Blink>DOM Blink>Editing
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 5 2017

Labels: Test-Predator-AutoOwner
Owner: r...@opera.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/7c44da721a59e6aa0b9fdcddb314175cb1e0123f (Implement lazy (re-)attachment of whitespace.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 3 by kochi@chromium.org, Oct 11 2017

Components: -Blink>DOM
With the minimized case with debug build, it hit DCHECK() before setpping
on the null pointer:

[1:1:1011/161912.735013:975010647:FATAL:SelectionTemplate.cpp(257)] Check failed: position.IsConnected(). #text "[(\"<lc]mmmmw4444444444444&&&111$"@offsetInAnchor[0]
#0 0x7fcd503fbdbd base::debug::StackTrace::StackTrace()
#1 0x7fcd503fa1ec base::debug::StackTrace::StackTrace()
#2 0x7fcd504806da logging::LogMessage::~LogMessage()
#3 0x7fcd48719300 blink::SelectionTemplate<>::Builder::Collapse()
#4 0x7fcd4871a4e7 blink::SelectionTemplate<>::Builder::SetBaseAndExtent()
#5 0x7fcd4872f4b9 blink::VisibleSelectionTemplate<>::AsSelection()
#6 0x7fcd4876ccd1 blink::CompositeEditCommand::SetEndingVisibleSelection()
#7 0x7fcd487a8e28 blink::TypingCommand::InsertText()
#8 0x7fcd487a8853 blink::TypingCommand::InsertText()
#9 0x7fcd4877ee69 blink::ExecuteInsertText()
#10 0x7fcd4877b309 blink::Editor::Command::Execute()
#11 0x7fcd487797d3 blink::Document::execCommand()
#12 0x7fcd496f2556 blink::DocumentV8Internal::execCommandMethod()
#13 0x7fcd496f1a37 blink::V8Document::execCommandMethodCallback()
#14 0x7fcd4a5342f2 v8::internal::FunctionCallbackArguments::Call()
#15 0x7fcd4a62f943 v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
#16 0x7fcd4a62db33 v8::internal::Builtin_Impl_HandleApiCall()
#17 0x7fcd4a62d4fd v8::internal::Builtin_HandleApiCall()
#18 0x3e9665d847e4 <unknown>

Given the backtrace, forwarding this to Blink>Editing.
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 19 2017

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "rune@opera.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by nainar@chromium.org, Oct 19 2017

Labels: Hotlist-Reassign-In-Nov
Owner: nainar@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by yosin@chromium.org, Oct 25 2017

Components: -Blink>Editing Blink>Editing>Command
Labels: -Pri-1 Pri-3
Owner: ----
Status: Available (was: Assigned)
Summary: InsertText command crashes with unusual HTML (was: Null-dereference in blink::Node::ContainsIncludingHostElements)
Lower to Pri-3 because real world usage of InsertText command with unusual HTML is low.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner
Labels: -Hotlist-Reassign-In-Nov
Project Member

Comment 10 by ClusterFuzz, Dec 6 2017

ClusterFuzz has detected this issue as fixed in range 521421:521451.

Detailed report: https://clusterfuzz.com/testcase?key=5527320994775040

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference
Crash Address: 0x0000000b
Crash State:
  blink::Node::ContainsIncludingHostElements
  blink::ComputePositionForChildrenRemoval
  blink::SelectionEditor::NodeChildrenWillBeRemoved
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=483672:483687
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=521421:521451

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5527320994775040

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Dec 6 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 5527320994775040 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment