New issue
Advanced search Search tips

Issue 772108 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Windows' IN6ADDR_ANY_INIT upsets clang-cl

Project Member Reported by davidben@chromium.org, Oct 5 2017

Issue description

I've been trying to get BoringSSL's standalone build working with clang-cl and ran into a warning from Windows' IN6ADDR_ANY_INIT definition. It seems to not have enough curly braces for the type it is initializing.


..\tool\transport_common.cc(173,20):  error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
  addr.sin6_addr = IN6ADDR_ANY_INIT;
                   ^~~~~~~~~~~~~~~~
C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\shared\ws2ipdef.h(229,28):  note: expanded from macro 'IN6ADDR_ANY_INIT'
#define IN6ADDR_ANY_INIT { 0 }
                           ^
..\tool\transport_common.cc(173,20):  error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
  addr.sin6_addr = IN6ADDR_ANY_INIT;
                   ^~~~~~~~~~~~~~~~
C:\Program Files (x86)\Windows Kits\10\include\10.0.10586.0\shared\ws2ipdef.h(229,28):  note: expanded from macro 'IN6ADDR_ANY_INIT'
#define IN6ADDR_ANY_INIT { 0 }
                           ^

Not sure if this is the sort of thing where you'd want to work around it or not, so I'm filing it here. (We probably should be using in6addr_any since it's not a static, so I'll just switch to that on Windows... we had to stop using it because NaCl was missing it.)
 
That sounds somewhat familiar.

...ah, yes, https://bugs.llvm.org/show_bug.cgi?id=24007 / https://codereview.chromium.org/1216413002/diff/60001/components/policy/core/common/policy_loader_win.cc#newcode86

See LLVM bug, getting this right is hard.

I'd recommend filing an MS bug and then using that pragma :-/
(also ref  bug 505297 )
Fair enough. :-) Where should I go to file a bug with MS for this sort of thing?
Cc: brucedaw...@chromium.org
That told me "You are not authorized to submit the feedback for this connection."

+brucedawson, Nico suggested I ask you to report it for me. Would you mind doing that? Thanks!
The new way of filing VS bugs is from the VS IDE. You need to go Help-> Send Feedback-> Report a Problem. It's a bit weird (it feels like a tool for reporting IDE bugs only) but it works.

This particular bug is a Windows SDK bug. I'm less clear on the process for filing these bugs. I'll investigate.

I filed a VS bug here:

https://developercommunity.visualstudio.com/content/problem/140934/in6addr-any-init-is-misdefined.html

I also emailed the details and a bug link to winsdkfeedback@microsoft.com. I'm sure they'll have it fixed in a few days ;-)

Components: Build

Sign in to add a comment