New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772095 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

server_management_lib has no tests?

Project Member Reported by dgarr...@chromium.org, Oct 5 2017

Issue description

The server management libraries broke because of a puppet directory rename.

Allen found the that the problem is in:
  venv/server_management_lib/constants.KEY_FILENAME

I updated that value locally and went looking for where to add a test to catch problems in the future before they are submitted.

But I can't seem to find the unittests for the server management library. If they exist, can you add instructions for running them to the README?

If not.... we need some. At least enough to catch syntax errors and to give us a place to add tests over time as things break. I can help make sure they are run on builders before changes are submitted.
 
This describes the breakage I tried to add a test for:  https://crbug.com/772097 

Just a check for "does this file exist" would be enough to prevent future problems.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 18 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-admin/+/75279b81d218badddc9262dbe5cad7085770f293

commit 75279b81d218badddc9262dbe5cad7085770f293
Author: Don Garrett <dgarrett@google.com>
Date: Wed Oct 18 03:49:10 2017

Status: WontFix (was: Untriaged)

Sign in to add a comment