Add heuristics for survey info bar |
||||
Issue descriptionIn its current implementation, the survey bar is very basic. The info bar should keep track of: If it was seen by the user How long it was visible What infobars were also visible
,
Oct 6 2017
,
Oct 25 2017
,
Nov 27 2017
This patch will change the way an infobar is displayed s.t. it appears on the first tab where the following criteria are met. The tab must be: 1. Non-incognito & not-null 2. Fully loaded 3. User interactable (i.e. not in tab switcher) If the current tab is closed or switched before any of these criteria are met, the system will wait for these criteria to be met on the next tab.
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/076bdd57453d84599ca47a3cc12026d5c8ee96b4 commit 076bdd57453d84599ca47a3cc12026d5c8ee96b4 Author: Daniel Park <danielpark@chromium.org> Date: Thu Nov 30 00:18:42 2017 [Chrome Home Survey] Improve Infobar triggering logic Uses a handler to start a timer for 5 seconds before logging an infobar as displayed Stores in shared preferences if infobar was displayed & closed. Checks with shared preferences before showing infobar. Adds animation listener to track frontmost infobar. Handles whether to log as displayed in cases where - Survey Infobar was dismissed - Survey Infobar was ignored (for threshold time) - Tab containing survey infobar was hidden before threshold was reached - Survey Infobar is hidden behind another infobar Bug: 772081 Change-Id: I16c8904b89820cf186919d8ba1d8d4eebcff0648 Reviewed-on: https://chromium-review.googlesource.com/708035 Commit-Queue: Daniel Park <danielpark@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#520323} [modify] https://crrev.com/076bdd57453d84599ca47a3cc12026d5c8ee96b4/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java [modify] https://crrev.com/076bdd57453d84599ca47a3cc12026d5c8ee96b4/chrome/android/java/src/org/chromium/chrome/browser/infobar/SurveyInfoBar.java [modify] https://crrev.com/076bdd57453d84599ca47a3cc12026d5c8ee96b4/chrome/android/java/src/org/chromium/chrome/browser/infobar/SurveyInfoBarDelegate.java [modify] https://crrev.com/076bdd57453d84599ca47a3cc12026d5c8ee96b4/chrome/android/java/src/org/chromium/chrome/browser/survey/ChromeHomeSurveyController.java [modify] https://crrev.com/076bdd57453d84599ca47a3cc12026d5c8ee96b4/chrome/android/junit/src/org/chromium/chrome/browser/survey/ChromeHomeSurveyControllerTest.java
,
Nov 30 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by danielpark@chromium.org
, Oct 5 2017