New issue
Advanced search Search tips

Issue 772076 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 772407



Sign in to add a comment

Web Animations: WPT test fails because finished event doesn't fire quickly enough

Project Member Reported by smcgruer@chromium.org, Oct 5 2017

Issue description

The following WPT test fails because the finished promise is not received by the script within 2 rAFs:

external/wpt/web-animations/interfaces/Animation/finish.html
  - Test normally finished animation resolves finished promise synchronously with an animation without a target

I've been unable to determine yet what happens. For some reason, it looks like when running as a promise_test it takes ~10 rAFs for the time to go from 9999 to 10000 (which is EffectEnd()). However when I took the code apart to run it manually it completes the animation within a single rAF and fires the finished event.

I'm not sure yet whether this is indicative of something wrong with our code, or if it's just a bad test.
 
Summary: Web Animations: WPT test fails because finished event doesn't fire quickly enough (was: Web Animations: WPT test fails because )

Comment 2 by shend@chromium.org, Oct 5 2017

Labels: Hotlist-Interop Update-Quarterly
Blocking: 772407
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c48db31689105ce81dcbe640416e45860299c248

commit c48db31689105ce81dcbe640416e45860299c248
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Thu Oct 12 20:34:35 2017

Update crbug links for some failing WPT web-animations tests

Bug:  600248 , 771722, 771751, 771977,  771985 ,  772014 , 772048, 772060, 772076 
Change-Id: Ie08474f751fd45484627c8a52d84db13ca6b39ac
Reviewed-on: https://chromium-review.googlesource.com/702536
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508447}
[modify] https://crrev.com/c48db31689105ce81dcbe640416e45860299c248/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e34f95209d584a16169a9343b4e4220c37a5616b

commit e34f95209d584a16169a9343b4e4220c37a5616b
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Tue Feb 20 19:08:37 2018

Add -expected.txt for web-anim finishing-an-animation.html WPT test

This test has non-flaky failures, so we can track them directly and
don't need to disable the test in TestExpectations.

Bug: 772076
Change-Id: Idd071879e02acfff7e77a3b4e923d4fe98f34cbc
Reviewed-on: https://chromium-review.googlesource.com/926721
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537840}
[modify] https://crrev.com/e34f95209d584a16169a9343b4e4220c37a5616b/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/e34f95209d584a16169a9343b4e4220c37a5616b/third_party/WebKit/LayoutTests/external/wpt/web-animations/timing-model/animations/finishing-an-animation-expected.txt

Cc: smcgruer@chromium.org
Owner: ----
Status: Available (was: Assigned)
Not planning to work on this in the near future, dropping to Available.

Sign in to add a comment