New issue
Advanced search Search tips

Issue 772069 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
I



Sign in to add a comment

Don't create SkShaders for PaintShaders at record time

Project Member Reported by khushals...@chromium.org, Oct 5 2017

Issue description

With this change: https://chromium-review.googlesource.com/c/chromium/src/+/701974, we would always create the SkShader for a PaintShader at construction/record time to have this be cached on the PaintShader itself and make the creation thread-safe for raster. This suboptimal for OOP raster which will never use these shaders, and even for raster in the renderer where some of the recording may never be rasterized.

Eventually we want a shader cache, so the SkShader caching is external to the PaintShader. This would also be nice for cases where we create new SkShaders from PaintShaders to replace decodes, and which depend on the raster scale. So having a shader cache that can include these additional bits in the cache key would also be better.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Oct 8

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: vmi...@chromium.org
Components: Internals>Compositing>OOP-Raster
Status: Available (was: Untriaged)
I think this is still an optimization that would help record time.

Sign in to add a comment