Create Bluetooth stability metrics |
|||||||||||
Issue descriptionIn order to quantify how stable Tether is as a Bluetooth client, we should add metrics around the following Bluetooth API calls: - Advertisement (un)registration - Scanning - GATT connection creation - GATT "StartNotify" operation - GATT Characteristic writing - Various timeouts
,
Oct 5 2017
Unfortunately I forgot to create this bug before submitting the CL: https://chromium-review.googlesource.com/c/chromium/src/+/701373. This change needs to be merged into M62.
,
Oct 5 2017
,
Oct 5 2017
This bug requires manual review: We are only 11 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 5 2017
Consider this merge approved however before merging please verify that this CL makes it through the Chrome OS PFQ, and that a resulting canary build works as you expect it to.
,
Oct 6 2017
,
Oct 6 2017
This bug requires manual review: We are only 10 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 9 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 9 2017
This was already approved, why was the request label added back in comment 6?
,
Oct 9 2017
Hey Bernie - I think Ryan accidentally removed the request. We are merging the CL to 62 now. Note that it won't show up as part of this bug because the original CL didn't have a BUG= line.
,
Oct 9 2017
Ah ok, no problem, the bot might pick up on this and ask you to merge but we can just remove the label to avoid that. It is still merge approved.
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/70b9e1d59ebebda20e5c986633fe7b601481da6d commit 70b9e1d59ebebda20e5c986633fe7b601481da6d Author: Ryan Hansberry <hansberry@chromium.org> Date: Wed Oct 11 22:14:28 2017 Refine metrics for Bluetooth operations. This CL accounts for future additions to Bluetooth error codes, and creates a histogram that captures all possible results of a BLE connection attempt. Bug: 772068 Change-Id: I50d3c6f05dc6e69fd18dfb9ef09ff6cabe56144b Reviewed-on: https://chromium-review.googlesource.com/710799 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#508143} [modify] https://crrev.com/70b9e1d59ebebda20e5c986633fe7b601481da6d/chromeos/components/tether/ble_synchronizer.cc [modify] https://crrev.com/70b9e1d59ebebda20e5c986633fe7b601481da6d/chromeos/components/tether/ble_synchronizer.h [modify] https://crrev.com/70b9e1d59ebebda20e5c986633fe7b601481da6d/chromeos/components/tether/ble_synchronizer_unittest.cc [modify] https://crrev.com/70b9e1d59ebebda20e5c986633fe7b601481da6d/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.cc [modify] https://crrev.com/70b9e1d59ebebda20e5c986633fe7b601481da6d/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.h [modify] https://crrev.com/70b9e1d59ebebda20e5c986633fe7b601481da6d/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc [modify] https://crrev.com/70b9e1d59ebebda20e5c986633fe7b601481da6d/tools/metrics/histograms/enums.xml [modify] https://crrev.com/70b9e1d59ebebda20e5c986633fe7b601481da6d/tools/metrics/histograms/histograms.xml
,
Oct 11 2017
,
Oct 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5cd4b2109a605bbe8b9b873dc5d4cb2b35e6d44 commit f5cd4b2109a605bbe8b9b873dc5d4cb2b35e6d44 Author: Kyle Horimoto <khorimoto@google.com> Date: Wed Oct 11 22:30:44 2017 Refine metrics for Bluetooth operations. This CL accounts for future additions to Bluetooth error codes, and creates a histogram that captures all possible results of a BLE connection attempt. TBR=hansberry@chromium.org (cherry picked from commit 70b9e1d59ebebda20e5c986633fe7b601481da6d) Bug: 772068 Change-Id: I50d3c6f05dc6e69fd18dfb9ef09ff6cabe56144b Reviewed-on: https://chromium-review.googlesource.com/710799 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508143} Reviewed-on: https://chromium-review.googlesource.com/714381 Cr-Commit-Position: refs/branch-heads/3202@{#661} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/f5cd4b2109a605bbe8b9b873dc5d4cb2b35e6d44/chromeos/components/tether/ble_synchronizer.cc [modify] https://crrev.com/f5cd4b2109a605bbe8b9b873dc5d4cb2b35e6d44/chromeos/components/tether/ble_synchronizer.h [modify] https://crrev.com/f5cd4b2109a605bbe8b9b873dc5d4cb2b35e6d44/chromeos/components/tether/ble_synchronizer_unittest.cc [modify] https://crrev.com/f5cd4b2109a605bbe8b9b873dc5d4cb2b35e6d44/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.cc [modify] https://crrev.com/f5cd4b2109a605bbe8b9b873dc5d4cb2b35e6d44/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection.h [modify] https://crrev.com/f5cd4b2109a605bbe8b9b873dc5d4cb2b35e6d44/components/cryptauth/ble/bluetooth_low_energy_weave_client_connection_unittest.cc [modify] https://crrev.com/f5cd4b2109a605bbe8b9b873dc5d4cb2b35e6d44/tools/metrics/histograms/enums.xml [modify] https://crrev.com/f5cd4b2109a605bbe8b9b873dc5d4cb2b35e6d44/tools/metrics/histograms/histograms.xml |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by hansberry@chromium.org
, Oct 5 2017