New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772056 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in new_len >= old_len in heap.cc

Project Member Reported by ClusterFuzz, Oct 5 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6169570892316672

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  new_len >= old_len in heap.cc
  v8::internal::AllocationResult v8::internal::Heap::CopyArrayAndGrow<v8::internal
  v8::internal::Factory::CopyFixedArrayAndGrow
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=47138:47139

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6169570892316672

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 6 2017

Components: Blink>JavaScript>GC Blink>JavaScript>Runtime
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 6 2017

Labels: Test-Predator-AutoOwner
Owner: rossberg@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/5614747680d189bb51cffe29cb79b884bb265a73 ([wasm] Fix index range checking in table accessors).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Cc: clemensh@chromium.org rossberg@chromium.org
Components: -Blink>JavaScript>Runtime -Blink>JavaScript>GC -Blink>JavaScript Blink>JavaScript>WebAssembly
Labels: Test-Predator-Wrong-CLs Test-Predator-Wrong-Components
Owner: mstarzinger@chromium.org
This is most likely due to undefined behavior of {new_size64 += old_size} in the {WebAssemblyTableGrow}. The regression range is a red herring. Also the component are completely off.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/158dbb8b6bbdbe222d96c1b639b2bf1992627b56

commit 158dbb8b6bbdbe222d96c1b639b2bf1992627b56
Author: Michael Starzinger <mstarzinger@chromium.org>
Date: Fri Oct 06 12:54:53 2017

[wasm] Fix undefined behavior in WebAssembly.Table.grow.

R=clemensh@chromium.org
TEST=mjsunit/regress/regress-crbug-772056
BUG= chromium:772056 

Change-Id: I199262aa128ab395382520b1439ecc60ed141d4a
Reviewed-on: https://chromium-review.googlesource.com/704582
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48341}
[modify] https://crrev.com/158dbb8b6bbdbe222d96c1b639b2bf1992627b56/src/wasm/wasm-js.cc
[add] https://crrev.com/158dbb8b6bbdbe222d96c1b639b2bf1992627b56/test/mjsunit/regress/regress-crbug-772056.js

Status: Fixed (was: Assigned)
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 6 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -Security_Impact-Head
Are any merges necessary here? The impact label applied by ClusterFuzz may be incorrect.
Project Member

Comment 8 by ClusterFuzz, Oct 7 2017

ClusterFuzz has detected this issue as fixed in range 48340:48341.

Detailed report: https://clusterfuzz.com/testcase?key=6169570892316672

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  new_len >= old_len in heap.cc
  v8::internal::AllocationResult v8::internal::Heap::CopyArrayAndGrow<v8::internal
  v8::internal::Factory::CopyFixedArrayAndGrow
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=47138:47139
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_dbg&range=48340:48341

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6169570892316672

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Oct 7 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6169570892316672 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner
Project Member

Comment 12 by sheriffbot@chromium.org, Jan 12 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Jul 28

Labels: Pri-1

Sign in to add a comment