Web Animations: blink::Animation does not fire onfinish after calling finish() |
|||
Issue description
The following test currently times out:
external/wpt/web-animations/timing-model/animations/updating-the-finished-state.html
- Finish notification steps run when the animation completes with .finish() even if we then seek away
I have not yet root-caused the reason, but it appears that we do not fire an onfinish event in this test once finish() is called:
[1:1:1005/133447.157750:10892766873719:INFO:Animation.cpp(646)] Animation::finish() called
[1:1:1005/133447.157909:10892766873812:INFO:Animation.cpp(1151)] ResolvePromiseMaybeAsync for finished_promise_
[1:1:1005/133447.158902:10892766874871:INFO:Animation.cpp(941)] Animation::Update: idle ? 0, Limited() ? 0, finished_ ? 0
The final log above is from Animation::Update, which is responsible for generating the onfinish event (as well as setting finished_):
bool Animation::Update(TimingUpdateReason reason) {
...
if ((idle || Limited()) && !finished_) {
...
timeline_->GetDocument()->EnqueueAnimationFrameEvent(
pending_finished_event_);
...
}
In the code, idle, Limited(), and finished_ are all false so the 'if' statement is never entered. I'm not yet clear what the correct solution is here - not sure what Limited() is about.
,
Oct 6 2017
,
Oct 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c48db31689105ce81dcbe640416e45860299c248 commit c48db31689105ce81dcbe640416e45860299c248 Author: Stephen McGruer <smcgruer@chromium.org> Date: Thu Oct 12 20:34:35 2017 Update crbug links for some failing WPT web-animations tests Bug: 600248 , 771722, 771751, 771977, 771985 , 772014 , 772048, 772060, 772076 Change-Id: Ie08474f751fd45484627c8a52d84db13ca6b39ac Reviewed-on: https://chromium-review.googlesource.com/702536 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#508447} [modify] https://crrev.com/c48db31689105ce81dcbe640416e45860299c248/third_party/WebKit/LayoutTests/TestExpectations
,
Apr 25 2018
Not planning to work on this in the near future, dropping to Available. |
|||
►
Sign in to add a comment |
|||
Comment 1 by shend@chromium.org
, Oct 5 2017