New issue
Advanced search Search tips

Issue 772032 link

Starred by 1 user
Status: Fixed
Owner:
jbudorick@chromium.org
Closed: Dec 2017
Cc:
peconn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature



Sign in to add a comment

Add support for local results details pages

Project Member Reported by jbudorick@chromium.org, Oct 5 2017 
Prior to leaving, mikecase wrote https://codereview.chromium.org/2933993002/ to add support for having local results details pages. Doing so will let devs view test results in the same manner in which they view them on the bots. Images and logs get stored in <output directory>/{suite}_{timestamp} rather than GS&Logdog, and the results details HTML page points to those.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/40561daf316841e45b83db273aeac2c52ada29b5

commit 40561daf316841e45b83db273aeac2c52ada29b5
Author: John Budorick <jbudorick@chromium.org>
Date: Thu Oct 05 19:32:26 2017

[devil] Add support for line transformation to LogcatMonitor.

Basically porting logdog_logcat_monitor's deobfuscate_func.

TBR=agrieve@chromium.org
Bug:  chromium:772032 
Change-Id: Ic57b38e522f93690d52eb090881b77c540aefb8f
Reviewed-on: https://chromium-review.googlesource.com/702922
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/40561daf316841e45b83db273aeac2c52ada29b5/devil/devil/android/logcat_monitor.py
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/425294bf256cbdaf307502effde7bd4ecd7b6c8e

commit 425294bf256cbdaf307502effde7bd4ecd7b6c8e
Author: John Budorick <jbudorick@chromium.org>
Date: Mon Oct 16 18:33:40 2017

[android] Add local results details pages.

Bug:  772032 
Change-Id: Ieca8a24e1f2d4bfbae1bef4a1a4ebb0a67365710
Reviewed-on: https://chromium-review.googlesource.com/702682
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Zhiling Huang <hzl@chromium.org>
Reviewed-by: Yoland Yan <yolandyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509116}
[delete] https://crrev.com/52a5f746be7a3540612c900653f0fca3fdd4e645/build/android/pylib/android/logdog_logcat_monitor.py
[modify] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/base/environment.py
[modify] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/base/environment_factory.py
[add] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/base/output_manager.py
[add] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/base/output_manager_factory.py
[modify] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/gtest/gtest_test_instance.py
[modify] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/local/device/local_device_environment.py
[modify] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/local/device/local_device_gtest_run.py
[modify] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/local/machine/local_machine_environment.py
[add] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/output/__init__.py
[add] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/output/local_output_manager.py
[add] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/output/noop_output_manager.py
[add] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/output/remote_output_manager.py
[modify] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/results/presentation/template/main.html
[modify] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/results/presentation/test_results_presentation.py
[modify] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/pylib/utils/google_storage_helper.py
[modify] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/test_runner.py
[modify] https://crrev.com/425294bf256cbdaf307502effde7bd4ecd7b6c8e/build/android/test_runner.pydeps
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d18897dac5186f5f6b24f07e1a4afebd172713c5

commit d18897dac5186f5f6b24f07e1a4afebd172713c5
Author: Juan Antonio Navarro Pérez <perezju@chromium.org>
Date: Tue Oct 17 10:29:00 2017

Revert "[android] Add local results details pages."

This reverts commit 425294bf256cbdaf307502effde7bd4ecd7b6c8e.

Reason for revert: Broke chrome_public_test_apk

Original change's description:
> [android] Add local results details pages.
> 
> Bug:  772032 
> Change-Id: Ieca8a24e1f2d4bfbae1bef4a1a4ebb0a67365710
> Reviewed-on: https://chromium-review.googlesource.com/702682
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Zhiling Huang <hzl@chromium.org>
> Reviewed-by: Yoland Yan <yolandyan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509116}

TBR=yolandyan@chromium.org,hzl@chromium.org,jbudorick@chromium.org

Change-Id: I9c20ed803802cae8db453282f43008019103618f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  772032 , 775448 
Reviewed-on: https://chromium-review.googlesource.com/722642
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509346}
[add] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/android/logdog_logcat_monitor.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/base/environment.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/base/environment_factory.py
[delete] https://crrev.com/e228732b4a18721df9398bcd0900347b331e4420/build/android/pylib/base/output_manager.py
[delete] https://crrev.com/e228732b4a18721df9398bcd0900347b331e4420/build/android/pylib/base/output_manager_factory.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/gtest/gtest_test_instance.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/local/device/local_device_environment.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/local/device/local_device_gtest_run.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/local/machine/local_machine_environment.py
[delete] https://crrev.com/e228732b4a18721df9398bcd0900347b331e4420/build/android/pylib/output/__init__.py
[delete] https://crrev.com/e228732b4a18721df9398bcd0900347b331e4420/build/android/pylib/output/local_output_manager.py
[delete] https://crrev.com/e228732b4a18721df9398bcd0900347b331e4420/build/android/pylib/output/noop_output_manager.py
[delete] https://crrev.com/e228732b4a18721df9398bcd0900347b331e4420/build/android/pylib/output/remote_output_manager.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/results/presentation/template/main.html
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/results/presentation/test_results_presentation.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/pylib/utils/google_storage_helper.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/test_runner.py
[modify] https://crrev.com/d18897dac5186f5f6b24f07e1a4afebd172713c5/build/android/test_runner.pydeps
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/611646dc1b2211c58095b11c263864fedbd40fe9

commit 611646dc1b2211c58095b11c263864fedbd40fe9
Author: John Budorick <jbudorick@chromium.org>
Date: Tue Oct 17 20:39:46 2017

[android] Add local results details pages. (RELAND)

Bug:  772032 , 775448 
Change-Id: I784723c37a3d4e2c4adeec407170e5d0094c439a
Reviewed-on: https://chromium-review.googlesource.com/723659
Reviewed-by: Zhiling Huang <hzl@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509511}
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/PRESUBMIT.py
[delete] https://crrev.com/b7915657bdb0890748dd74c55743f9c3bbde6ecc/build/android/pylib/android/logdog_logcat_monitor.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/base/environment.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/base/environment_factory.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/base/output_manager.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/base/output_manager_factory.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/base/output_manager_test_case.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/gtest/gtest_test_instance.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/instrumentation/instrumentation_test_instance.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/local/device/local_device_environment.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/local/device/local_device_gtest_run.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/local/device/local_device_instrumentation_test_run.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/local/machine/local_machine_environment.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/output/__init__.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/output/local_output_manager.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/output/local_output_manager_test.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/output/noop_output_manager.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/output/noop_output_manager_test.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/output/remote_output_manager.py
[add] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/output/remote_output_manager_test.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/results/presentation/template/main.html
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/results/presentation/test_results_presentation.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/pylib/utils/google_storage_helper.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/test_runner.py
[modify] https://crrev.com/611646dc1b2211c58095b11c263864fedbd40fe9/build/android/test_runner.pydeps

Comment 5 by jbudorick@chromium.org, Dec 1 2017

Status: Fixed (was: Started)
►

Sign in to add a comment