New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772023 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

CHECK in crtc_controller.cc

Project Member Reported by sky@chromium.org, Oct 5 2017

Issue description

I was trying --mus on device. I copied the image for R63-9972.0.0 and locally Chrome is at b35515dfbe21f74c4c48a65a3630337219fd490b 506441.

I was switching from virtual terminal back into chrome and hit a CHECK (couple of lines earlier may be relevent).

[6364:6429:1005/093737.585605:ERROR:drm_display_host_manager.cc(192)] TakeDisplayControl called while display already owned
[6364:6429:1005/093750.785679:ERROR:drm_display_host_manager.cc(192)] TakeDisplayControl called while display already owned
[6364:6435:1005/093750.887154:FATAL:crtc_controller.cc(81)] Check failed: !page_flip_request_.get() || test_only.
#0 0x7f866659410c base::debug::StackTrace::StackTrace()
#1 0x7f86665afc4e logging::LogMessage::~LogMessage()
#2 0x7f8663fd59e4 ui::CrtcController::SchedulePageFlip()
#3 0x7f8663ff4637 ui::HardwareDisplayController::ActualSchedulePageFlip()
#4 0x7f8663ff48cf ui::HardwareDisplayController::SchedulePageFlip()
#5 0x7f8663fecb90 ui::DrmWindow::SchedulePageFlip()
#6 0x7f8663fe2643 ui::DrmThread::SchedulePageFlip()
#7 0x7f8663fed94f _ZN4base8internal7InvokerINS0_9BindStateIMN2ui9DrmThreadEFviRKSt6vectorINS3_12OverlayPlaneESaIS6_EENS_12OnceCallbackIFvN3gfx10SwapResultEEEEEJNS0_17UnretainedWrapperIS4_EEiS8_SF_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#8 0x7f8666594909 base::debug::TaskAnnotator::RunTask()
#9 0x7f86666535e6 base::internal::IncomingTaskQueue::RunTask()
#10 0x7f86665b82ce base::MessageLoop::RunTask()
#11 0x7f86665b8a59 base::MessageLoop::DoWork()
#12 0x7f86665bb3d9 base::MessagePumpLibevent::Run()
#13 0x7f86665b7d1e base::MessageLoop::Run()
#14 0x7f86665e55cc base::RunLoop::Run()
#15 0x7f8666613ffa base::Thread::Run()
#16 0x7f8666614553 base::Thread::ThreadMain()
#17 0x7f866660d0cf base::(anonymous namespace)::ThreadFunc()
#18 0x7f8662a712b8 <unknown>
#19 0x7f86619c0fad clone
 
Components: UI>Shell>MultipleMonitor OS>Kernel>Display
I guess that means you were running with DCHECKs on?

Comment 3 by sky@chromium.org, Oct 5 2017

That's right. Release build with dcheck_always_on=true.
I can reproduce the problem. It actually DCHECKs here in all configurations, although running cash it hits the DCHECK on the next line (crtc_controller.cc:81) instead.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66782d2a8d72c4b2126c481d410983e86b35d6dc

commit 66782d2a8d72c4b2126c481d410983e86b35d6dc
Author: kylechar <kylechar@chromium.org>
Date: Wed Nov 01 17:04:43 2017

Fix switching to VT2 with mus/mash.

Switching to VT2 on Chrome OS with --mus or --mash was broken on some
boards due to copy and paste errors calling the wrong function.

Bug:  777571 ,  772023 
Change-Id: I4f77ae795bd5cd19b767e6bb9e40c4a28d08c2c3
Reviewed-on: https://chromium-review.googlesource.com/748812
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513160}
[modify] https://crrev.com/66782d2a8d72c4b2126c481d410983e86b35d6dc/ui/display/manager/forwarding_display_delegate.cc
[modify] https://crrev.com/66782d2a8d72c4b2126c481d410983e86b35d6dc/ui/ozone/platform/drm/host/host_drm_device.cc

Status: Fixed (was: Assigned)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment