New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 772019 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

We should merge TextViewWithLeading and TextViewWithClickableSpans

Project Member Reported by mvanouwe...@chromium.org, Oct 5 2017

Issue description

We should merge TextViewWithLeading and TextViewWithClickableSpans. Currently we can't have both good leading and accessible clickable spans at the same time.
 
My vote would be to make TextViewWithClickableSpans extend from TextViewWithLeading since as it stands TVWithLeading is fairly lightweight and only adds some XML processing on startup.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adb2242fa2f2ed33f66cf15f1ff0871bb22d2e2b

commit adb2242fa2f2ed33f66cf15f1ff0871bb22d2e2b
Author: Peter E Conn <peconn@chromium.org>
Date: Mon Oct 09 09:28:39 2017

✒️ Extend TextViewWithClickableSpans from TextViewWithLeading.

This allows text leading to be set in TextViewWithClickableSpans.

TextViewWithLeading is a lightweight extension of TextView, so
using it as the superclass of TextViewWithClickableSpans should add
only negligable complexity, easily ignored in the case we don't need
to set leading,

Bug:  772019 
Change-Id: I03d759c77c9d78ee934e0635762448ff5ed8c354
Reviewed-on: https://chromium-review.googlesource.com/704814
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507342}
[modify] https://crrev.com/adb2242fa2f2ed33f66cf15f1ff0871bb22d2e2b/ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java
[modify] https://crrev.com/adb2242fa2f2ed33f66cf15f1ff0871bb22d2e2b/ui/android/java/src/org/chromium/ui/widget/TextViewWithLeading.java

Status: Fixed (was: Available)

Sign in to add a comment