We should merge TextViewWithLeading and TextViewWithClickableSpans |
||
Issue descriptionWe should merge TextViewWithLeading and TextViewWithClickableSpans. Currently we can't have both good leading and accessible clickable spans at the same time.
,
Oct 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adb2242fa2f2ed33f66cf15f1ff0871bb22d2e2b commit adb2242fa2f2ed33f66cf15f1ff0871bb22d2e2b Author: Peter E Conn <peconn@chromium.org> Date: Mon Oct 09 09:28:39 2017 ✒️ Extend TextViewWithClickableSpans from TextViewWithLeading. This allows text leading to be set in TextViewWithClickableSpans. TextViewWithLeading is a lightweight extension of TextView, so using it as the superclass of TextViewWithClickableSpans should add only negligable complexity, easily ignored in the case we don't need to set leading, Bug: 772019 Change-Id: I03d759c77c9d78ee934e0635762448ff5ed8c354 Reviewed-on: https://chromium-review.googlesource.com/704814 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#507342} [modify] https://crrev.com/adb2242fa2f2ed33f66cf15f1ff0871bb22d2e2b/ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java [modify] https://crrev.com/adb2242fa2f2ed33f66cf15f1ff0871bb22d2e2b/ui/android/java/src/org/chromium/ui/widget/TextViewWithLeading.java
,
Oct 9 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by peconn@chromium.org
, Oct 5 2017