New issue
Advanced search Search tips

Issue 772015 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , iOS
Pri: 3
Type: Bug



Sign in to add a comment

Calculator suggestions on phones should include '=' prefix

Project Member Reported by jdonnelly@chromium.org, Oct 5 2017

Issue description

Calculator suggestions are responses from the search backend that provide the result of a mathematical expression. For example, if the user types "2 ^ 3" in the omnibox, one of the suggestions shown in the dropdown will be "8". In order to make it clearer that this is the result of the expression, an '=' suggestion-type icon is shown (rather than the magnifying glass icon normally shown for search suggestions).

On phones, however, suggestion-type icons are not displayed. We should instead show '=' as text in front of the result text (e.g. "= 8"). As it happens, this text actually appears in the response from the server. But we added logic to remove it when we introduced the '=' icon:

https://cs.chromium.org/chromium/src/components/omnibox/browser/search_suggestion_parser.cc?l=518-520&rcl=7171bc6ff5be63301e024db28fd44c87e6f7988a

At that time, I believe that the type icons were being displayed on phones. Now that they're not, we should skip removing the '=' text on phones. In other words, that logic above should include an exception on phones.
 
Labels: -Pri-2 Hotlist-Polish Pri-3
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6658ed8bda74b440e447bcaf58bbc3d0def4e520

commit 6658ed8bda74b440e447bcaf58bbc3d0def4e520
Author: Justin Donnelly <jdonnelly@google.com>
Date: Fri Oct 06 16:07:13 2017

Show the "= " text in calculator suggestions on phones.

This prefix text was removed when we introduced the calculator
icon (looks like '=') but then suggestion type icons were removed
from the phone UIs. Reintroducing the "= " text makes it clearer
that these are the result of the mathematical expression that the
user has input.

Bug:  772015 
Change-Id: If60f462a688b0f39288df0c7c713e21170d971e2
Reviewed-on: https://chromium-review.googlesource.com/703435
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507086}
[modify] https://crrev.com/6658ed8bda74b440e447bcaf58bbc3d0def4e520/components/omnibox/browser/search_suggestion_parser.cc

Status: Fixed (was: Assigned)

Sign in to add a comment