Consider inlining empty functions in libchrome.so |
|||
Issue descriptionFrom https://chromium-review.googlesource.com/c/chromium/src/+/702301, we have out-of-line empty destructors, causing unnecessary code bloat. Consider moving other such cases inline.
,
Oct 5 2017
Thanks! I already have a script that finds all these symbols, sorry, forgot to mention it: https://chromium-review.googlesource.com/c/chromium/src/+/702383 It leverages ICF in the linker to get all the 2 byte symbols that are necessarily just an empty return.
,
Oct 5 2017
Awesome! Any ideas on how to count the number of calls to each of these functions in order to see which would be good to inline? Alternatively - maybe use clang's refactoring tool to convert all of these methods to being inlined?
,
Oct 10 2017
Does this affect 'git cl lint'?
,
Jan 21
(2 days ago)
I'd guess this is obsoleted by ThinLTO (it should inline empty functions so long as they are not virtual). Not sure how to validate this though. |
|||
►
Sign in to add a comment |
|||
Comment 1 by agrieve@chromium.org
, Oct 5 2017