Issue metadata
Sign in to add a comment
|
skia_unittests is failing in official builds |
||||||||||||||||||||
Issue descriptionStarted here; https://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/17001 Likely due to https://chromium-review.googlesource.com/688656 https://chromium-review.googlesource.com/c/chromium/src/+/688656/10/skia/ext/skia_utils_base_unittest.cc#38 tests for the string "check failed", but in official builds we strip the output strings of CHECK(false). The fix is likely to replace the two "check failed" with just "".
,
Oct 5 2017
Thanks for the pointer!
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0de0d3dbd357fb9655f95d0b573759e227afaf45 commit 0de0d3dbd357fb9655f95d0b573759e227afaf45 Author: Khushal <khushalsagar@chromium.org> Date: Thu Oct 05 18:15:43 2017 skia: Fix death test assert in ImageSerializationTest. Since we strip out strings on official release builds, don't use "Check Failed" for EXPECT_DEATH asserts. R=thakis@chromium.org Bug: 771998 Change-Id: Id9e65c699fdae2fab8354ea64cae82b5d0691109 Reviewed-on: https://chromium-review.googlesource.com/702647 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#506790} [modify] https://crrev.com/0de0d3dbd357fb9655f95d0b573759e227afaf45/skia/ext/skia_utils_base_unittest.cc
,
Oct 5 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by khushals...@chromium.org
, Oct 5 2017