Extension uninstall reports are broken |
||||||||
Issue descriptionAll extension uninstall pings are broken (the client transmits invalid XML). Regressed @ 4ab7c29b4c7ad38decdacfe842d8986886ee70cd , first shipped in 61.0.3132.0 Sample request: <?xml version="1.0" encoding="UTF-8"?><request protocol="3.1" dedup="cr" acceptformat="crx2,crx3" version="chromecrx-61.0.3163.100" prodversion="61.0.3163.100" requestid="{8a62ef30-77e7-471f-b6a5-fd7634844eae}" lang="en-US" updaterchannel="" prodchannel="" os="win" arch="x86" nacl_arch="x86-32"><hw physmemory="3"/><os platform="Windows" arch="x86" version="10.0.10586.0"/><app appid="mallpejgeafdahhflmliiahjdpgbegpk" version="12.703.11.56348" nextversion="0"><event eventtype="4" extracode1="1" extracode1="1"/></app></request> The problem occurs at: <event eventtype="4" extracode1="1" extracode1="1"/> (XML requires all attributes to be uniquely named.) I am prepping a CL now. Merges to M61 and M62 will be requested after confirming fix on canary and should be low risk.
,
Oct 5 2017
,
Oct 9 2017
,
Oct 9 2017
This bug requires manual review: We are only 7 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 9 2017
Is the change verified/baked in Canary and confirm safe to merge to M62?
,
Oct 9 2017
Yes, I've verified the fix in canary and don't see any regresions. Thank you for checking.
,
Oct 9 2017
Approving merge to M62 branch 3202 based on comment #7. Please merge ASAP. Thank you.
,
Oct 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0a9df7d1af48341e681ca73ba79f076bb46ca80 commit a0a9df7d1af48341e681ca73ba79f076bb46ca80 Author: Joshua Pawlicki <waffles@google.com> Date: Mon Oct 09 19:14:57 2017 Fix extension uninstall ping XML. Bug: 771987 Change-Id: If0293e9c73d575719544fbbdcb1f40fbf6df4962 Reviewed-on: https://chromium-review.googlesource.com/702057 Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#506761}(cherry picked from commit 426e47187f129a742e3c38200b4ff071e861e262) Reviewed-on: https://chromium-review.googlesource.com/707514 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#619} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/a0a9df7d1af48341e681ca73ba79f076bb46ca80/components/update_client/protocol_builder.cc
,
Oct 11 2017
waffles@ Could you please help us with repro steps to verify the fix from TE-end.
,
Oct 11 2017
1 • Install Adblock: https://chrome.google.com/webstore/detail/adblock/gighmmpiobklfepjocnamgkkbiglidom 2 • Open chrome://net-internals in a tab 3 • Uninstall Adblock (can be done from chrome://extensions) 4 • in chrome://net-internals, filter requests for /service/update2. Verify that the URL_REQUEST got an HTTP 200
,
Oct 11 2017
waffles@, thank you for providing repro steps. The above fix has been verified on Latest M62 Beta#62.0.3202.52 for Win10, Mac OS X 10.12.6 & Linux Ubuntu 14.04 and it is working as intended. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 5 2017